tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

bootctl: replace readdir() loops with FOREACH_DIRENT

bootctl: use DRAW_TREE_RIGHT rather than hard-coded UTF-8 character Fixes #2384

util-lib: split out allocation calls into alloc-util.[ch]

util-lib: move more locale-related calls to locale-util.[ch]

util-lib: move more file I/O related calls into fileio.[ch]

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

util: introduce common version() implementation and use it everywhere This also allows us to drop build.h from a ton of files, hence do so. Since we touched the #includes of those files, let's order them properly according to CODING_STYLE.

bootctl: fix path in log message

tree-wide: port everything over to fflush_and_check() Some places invoked fflush() directly with their own manual error checking, let's unify all that by using fflush_and_check(). This also unifies the general error paths of fflush()+rename() file writers.

bootctl: add missing newline

sd-boot: ignore missing /etc/machine-id If /etc/machine-id is missing (eg., gold images), we should not fail installing sd-boot. This is a perfectly fine use-case and we should simply skip installing the default loader config in that case.

bootctl: fix sdboot to systemd-boot sdboot was renamed to systemd-boot Fixes: e7dd673d1e0a ("gummiboot/sd-boot/systemd-boot: rename galore") Signed-off-by: Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>

bootctl: fix an error check

bootctl: ferror must be called before FILE is closed Otherwise it will not show any error stored

bootctl: try to catch all errors Do not print garbage on non-EFI installations.

bootctl: modernization Use strjoina to avoid error handling, and openat to simplify things. Some fixes on the way: - ferror does not set errno, so the return value was wrong in some cases - errors are propagated in more cases - EFI/systemd was created, but EFI/systemd-boot was deleted - something is always printed on error - when checking the version, comparison was done against "systemd-bo" for some reason - return value was converted from negative to EXIT_SUCCESS/EXIT_FAILURE twice, resulting in EXIT_SUCCESS all the time

remove duplicated includes

util: rework rm_rf() logic - Move to its own file rm-rf.c - Change parameters into a single flags parameter - Remove "honour sticky" logic, it's unused these days

bootctl: drop redundant parse_argv() We already call parse_argv() from main(), don't call it here again.

bootctl: avoid NULL pointer dereference

bootctl: check that partition uuid is valid It probably is but check anyway to make coverity happy. CID#1271354

bootctl: fix mem leaks CID#1271347/1271348

remove unused includes This patch removes includes that are not used. The removals were found with include-what-you-use which checks if any of the symbols from a header is in use.

gummiboot/sd-boot/systemd-boot: rename galore What used to be gummiboot, was renamed sd-boot when it was merged into systemd. Let's try to be a bit more consistent with the rest of systemd and rename it again as follows: The EFI bootloader is now called 'systemd-bootx64.efi', and its sources are in 'src/boot/efi/'. The drop-in directory where bootctl will find EFI loaders is now /usr/lib/systemd/boot/efi/.

bootctl: add sd-boot support

Unify parse_argv style getopt is usually good at printing out a nice error message when commandline options are invalid. It distinguishes between an unknown option and a known option with a missing arg. It is better to let it do its job and not use opterr=0 unless we actually want to suppress messages. So remove opterr=0 in the few places where it wasn't really useful. When an error in options is encountered, we should not print a lengthy help() and overwhelm the user, when we know precisely what is wrong with the commandline. In addition, since help() prints to stdout, it should not be used except when requested with -h or --help. Also, simplify things here and there.

bootctl: remove unused options from getopt_long

clients: unify how we invoke getopt_long() Among other things this makes sure we always expose a --version command and show it in the help texts.

bootctl: typo fix in help message

bootctl: fix help text It currently says 'time settings', change that to 'boot settings'.

bootctl: ESP --> Partition

bootctl: Binary: --> File:

bootctl: rename status output header

bootctl: print Options only when found

bootctl: print secure boot flags

bootctl: show "n/a" for empty boot option labels

bootctl: print partition uuids as /dev/disk/by-partuuid/...

bootctl: add boot loader and firmware interface tool