BUILD: Fix variable substitution in cwrap.m4 Add another dollar sign to have variable name substituted by m4 in "cwrap.m4" further substituted with its value by shell in "configure". Before, this: [ test x$2 = xyes] would produce this in "configure" for uid_wrapper test: test xHAVE_UID_WRAPPER = xyes which is always false. Now the changed code: [ test x$$2 = xyes] Would produce this in "configure" instead: test x$HAVE_UID_WRAPPER = xyes which will properly process the test result. This fixes uid_wrapper and nss_wrapper detection, which were considered missing otherwise, resulting in cwrap tests not running. Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>

Add integration tests Add "intgcheck" make target. Update CI to use it. The "intgcheck" target configures and builds sssd in a sub-directory, installs it into a prefix in another sub-directory, and then makes the "intgcheck-installed" target from within src/tests/intg in that separate build. The "intgcheck-installed" target in src/tests/intg runs py.test for all tests it can find in that directory, under fakeroot and nss_wrapper/uid_wrapper environments emulating running under root. It also adds the value of INTGCHECK_PYTEST_ARGS environment/make variable to the py.test command line. You can use it to pass additional py.test options, such as specifying a subset of tests to run. See "py.test --help" output. There are only two test suites in src/tests/intg at the moment: ent_test.py and ldap_test.py. The ent_test.py runs tests on ent.py - a module of assertion functions for checking entries in NSS database (passwd and group), for use in actual tests. The ent_test.py suite can be used as ent.py usage reference. The ldap_test.py suite sets up and starts a slapd instance, adds a few user and group entries, configures and starts sssd and verifies that those users and groups are retrieved correctly using various NSS functions. The tests are very basic at the moment. Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com> Reviewed-by: Michal Židek <mzidek@redhat.com>

BUILD: Detect nss_wrapper and uid_wrapper during configure Unit testing the utilities to become another user requires the use of the cwrap libraries. This patch augments our build system with macros to detect the nss_wrapper and and uid_wrapper libraries. Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>