mmap_cache: Remove unnecessary memchr in client code Corrupting of memory cache was fixed in the ticket https://pagure.io/SSSD/sssd/issue/2049. We have some fast sanity check for length of strings and memchr is not used in responder. We should remove it also from client code. Related to: https://pagure.io/SSSD/sssd/issue/3592 Reviewed-by: Sumit Bose <sbose@redhat.com>

Fix minor spelling mistakes in sss_client/* Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>

mmap_cache: make checks independent of input size Currently the consistency checks for the mmap_cache payload data on the client and the responder side include the length of the input string of the current request. Since there might be hash collisions which other much longer or much shorter names those checks might fail although there is no data corruption. This patch removes the checks using the length of the input and adds a check if the name found in the payload is zero-terminated inside of the payload data. Resolves https://pagure.io/SSSD/sssd/issue/3571 Reviewed-by: Michal Židek <mzidek@redhat.com> Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>

Moving headers used by both server and client to special folder These are the header files which are used by both client and server: src/util/io.h src/util/murmurhash3.h src/util/util_safealign.h This patch is about moving these header files to special folder (src/shared). It will be easier to identify these headers when looking for them in the src tree. util_safalign.h is renamed as safalign.h because util_ namespace is appropriate when this file belonged to the util's folder which is no longer the case. Resolves: https://pagure.io/SSSD/sssd/issue/1898 Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>

sss_client: Update integrity check of records in mmap cache The function sss_nss_mc_get_record return copy of record from memory cache in last argument. Because we should not access data directly to avoid problems with consistency of record. The function sss_nss_mc_get_record also check whether length of record is within data area (with macro MC_CHECK_RECORD_LENGTH) However we also tried to do the same check in functions sss_nss_mc_get{gr, pw}* Pointer to end of strings in record was compared to pointer to the end of data table. But these two pointers are not within the same allocated area and does not make sense to compare them. Sometimes record can be allocated before mmaped area and sometime after. Sometimes it will return cached data and other time will fall back to responder. Resolves: https://fedorahosted.org/sssd/ticket/2743 Reviewed-by: Michal Židek <mzidek@redhat.com>

mmap_cache: "Override" functions for initgr mmap cache Functions sss_mc_get_strs_offset and sss_mc_get_strs_len provides data about strings for individual memory caches (passwd, ...) Their are used in generic responder mmap cache code to find a record in mmap cache (sss_mc_find_record). Data provided from functions sss_mc_get_* are used for checking the validity of record. So in case of corrupted record the whole mmap cache can be invalidated. Functions sss_mc_get_strs_offset and sss_mc_get_strs_len did not provide data for initgroups mmap cache and therefore particular record could not be invalidated. Resolves: https://fedorahosted.org/sssd/ticket/2716 Reviewed-by: Michal Židek <mzidek@redhat.com>

mmap_cache: Rename variables Reviewed-by: Michal Židek <mzidek@redhat.com>

sss_client: Use initgr mmap cache in client code Resolves: https://fedorahosted.org/sssd/ticket/2485 Reviewed-by: Michal Židek <mzidek@redhat.com>