CI: Ignore E722 pep8 issues on debian machines For now, let's ignore E722 (do not use bare except) in the debian_testing machines that are part of our CI. Resolves: https://pagure.io/SSSD/sssd/issue/3605 Reviewed-by: Michal Židek <mzidek@redhat.com> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>

CI: Enable pep8 check CI can now check pep8 issues for all .py files but the ones under src/config (for those, there's an issue already filed[0]). [0]: https://pagure.io/SSSD/sssd/issue/3514 Resolves: https://pagure.io/SSSD/sssd/issue/3605 Reviewed-by: Michal Židek <mzidek@redhat.com> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>

CI: Ignore source file generated by systemtap There are some changes in systemtap 3.2 which generate temporary source files and remove them later. We are not interested in code coverage in this area. Lets ignore them. ... genhtml: failure 00:00:01 ci-build-coverage/ci-genhtml.log FAILURE sh$ cat ci-build-coverage/ci-genhtml.log Start: Mon Oct 30 13:43:52 UTC 2017 + eval 'genhtml --output-directory \ "$coverage_report_dir" \ --title "sssd" --show-details \ --legend --prefix "$BASE_DIR" \ ci.info |& tee ci-genhtml.out' ++ genhtml --output-directory ci-report-coverage --title sssd \ --show-details --legend --prefix /home/build/sssd ci.info ++ tee ci-genhtml.out Reading data file ci.info Found 447 entries. Using user-specified filename prefix "/home/build/sssd" Writing .css and .png files. Generating output. genhtml: ERROR: cannot read /home/build/sssd/stap_generated_probes.o.dtrace-temp.c Processing file stap_generated_probes.o.dtrace-temp.c End: Mon Oct 30 13:43:53 UTC 2017 sh$ ls -l /home/build/sssd/stap_generated_probes.o.dtrace-temp.c ls: cannot access '/home/build/sssd/stap_generated_probes.o.dtrace-temp.c': No such file or directory Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>

Revert "CI: Use /bin/sh as a CONFIG SHELL" This reverts commit 35f29b17699c3d52f77857c530300318b14148f8. Workaround is not required anymore. Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>

CI: Do not use valgrind for dummy-child There was a bug in valgrind < 3.13 which override some log files and therefore there was missing errors for shell wrappers generated by libtool for dummy-child. https://bugs.kde.org/show_bug.cgi?id=162848 We could add more suppressions for errors/leaks in bash to our suppression file but dummy child is built just for test purposes. Another possible solution would to avoid linking dummy-child with internal libraries; So libtool would not generate shell wrapper for dummy-child. But the simplest think is to ignore all errors for dummy-child. Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>

CI: Remove dlopen-test from valgrind blacklist Dlopen test was added to blacklist due to following reason: > Disable running dlopen-tests under Valgrind as their use of dlclose > makes Valgrind drop symbols and produce meaningless backtraces, which > cannot be matched with specific suppressions. It's true that dlclose makes meaningless backtraces but backtraces should not be generated otherwise there is a bug in some library which need to be fixed and not suppressed. Reviewed-by: Nikolai Kondrashov <Nikolai.Kondrashov@redhat.com>

TESTS: Add simple test for double semicolon Reviewed-by: Pavel Březina <pbrezina@redhat.com>

CI: Use /bin/sh as a CONFIG SHELL There is a bug on debian_testing in bash. sh$ valgrind /bin/bash ==25145== Memcheck, a memory error detector ==25145== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al. ==25145== Using Valgrind-3.12.0.SVN and LibVEX; rerun with -h for copyright info ==25145== Command: /bin/bash ==25145== ==25145== Invalid read of size 1 ==25145== at 0x4B90B1: ??? (in /bin/bash) ==25145== by 0x43FE9B: initialize_shell_variables (in /bin/bash) ==25145== by 0x41E4C0: ??? (in /bin/bash) ==25145== by 0x41F722: main (in /bin/bash) ==25145== Address 0x58307f8 is 8 bytes before a block of size 31 alloc'd ==25145== at 0x4C2BBCF: malloc (vg_replace_malloc.c:299) ==25145== by 0x475D1A: xmalloc (in /bin/bash) ==25145== by 0x4B7F4A: tilde_expand (in /bin/bash) ==25145== by 0x42E63D: bash_tilde_expand (in /bin/bash) ==25145== by 0x43FE79: initialize_shell_variables (in /bin/bash) ==25145== by 0x41E4C0: ??? (in /bin/bash) ==25145== by 0x41F722: main (in /bin/bash) ==25145== malloc: .././variables.c:570: assertion botched free: called with unallocated block argument last command: (null) Aborting...==25145== And /bin/bash was used as a default SHELL in scripts generated by configure+libtool. It starting to fail with the latest valgrind valgrind-3.12.0~svn20160714-1 Workaround is to use /bin/sh which is a symlink to /bin/dash Reviewed-by: Petr Cech <pcech@redhat.com>

CI: Exclude files in /tmp during coverage runs Exclude files from /tmp during coverage generation to avoid issues with (presumably) files generated by dtrace that couldn't otherwise be opened or parsed. Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>

CI: Use make check instead of make-check-wrap make-check-wrap had to be used due to missing LOG_COMPILER on rhel6 which is enabled with parallel test harness Reviewed-by: Nikolai Kondrashov <Nikolai.Kondrashov@redhat.com>

CI: Enforce coverage make check failures Fail CI coverage build, if make-check stage fails. Previously make-check stage failures were ignored for coverage build for the sake of collecting coverage data in any case. However, catching extra test failures seems more important than getting coverage data in all cases, thus the change. Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>

CI: Workaroung for code coverage with old gcc It's fixed in upstream gcc >= 4.6.0 Resolves: https://fedorahosted.org/sssd/ticket/2819 Reviewed-by: Nikolai Kondrashov <Nikolai.Kondrashov@redhat.com>

CI: Exclude whitespace_test from Valgrind checks Exclude whitespace_test from Valgrind checks in contrib/ci/run to prevent it from failing the tests due to Bash bugs. Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>

Add integration tests Add "intgcheck" make target. Update CI to use it. The "intgcheck" target configures and builds sssd in a sub-directory, installs it into a prefix in another sub-directory, and then makes the "intgcheck-installed" target from within src/tests/intg in that separate build. The "intgcheck-installed" target in src/tests/intg runs py.test for all tests it can find in that directory, under fakeroot and nss_wrapper/uid_wrapper environments emulating running under root. It also adds the value of INTGCHECK_PYTEST_ARGS environment/make variable to the py.test command line. You can use it to pass additional py.test options, such as specifying a subset of tests to run. See "py.test --help" output. There are only two test suites in src/tests/intg at the moment: ent_test.py and ldap_test.py. The ent_test.py runs tests on ent.py - a module of assertion functions for checking entries in NSS database (passwd and group), for use in actual tests. The ent_test.py suite can be used as ent.py usage reference. The ldap_test.py suite sets up and starts a slapd instance, adds a few user and group entries, configures and starts sssd and verifies that those users and groups are retrieved correctly using various NSS functions. The tests are very basic at the moment. Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com> Reviewed-by: Michal Židek <mzidek@redhat.com>

CI: Remove Clang analyzer Remove Clang analyzer run from contrib/ci/run as it takes a long time (5-8 minutes) and its results are unused. Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>

CI: Use default config for mock build The mock config with name default is usually symbolic link to the configuration file of local architecture. The side effect of this patch is that we will not try to rebuild on old architectures src.rpm for new architectures(fedora). It caused issues with mock tmpfs plugin. Resolves: https://fedorahosted.org/sssd/ticket/2441 Signed-off-by: Lukas Slebodnik <lslebodn@redhat.com> Reviewed-by: Nikolai Kondrashov <Nikolai.Kondrashov@redhat.com>

CI: Remove disabling of Valgrind gdb invocation Remove --vgdb=no option from CI's Valgrind invocation, as default condition for starting gdb (--vgdb-error=999999999) is highly unlikely and therefore this option is unnecessary. Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>

CI: Enforce Valgrind check Add check for Valgrind test result to contrib/ci/run. Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>

CI: Add Valgrind suppression support Add an empty Valgrind suppressions file, use it when invoking Valgrind. This prepares for addition of Valgrind suppressions for current false positives and issues that cannot be fixed, preparing for enforcing Valgrind check. Make Valgrind output a suppression for every error and make it output used suppression names and counts at the end of each run. This simplifies discovery and addition of new suppressions and removal of unused ones. Related to https://fedorahosted.org/sssd/ticket/2428 Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>

CI: Don't run dlopen-tests under Valgrind Disable running dlopen-tests under Valgrind as their use of dlclose makes Valgrind drop symbols and produce meaningless backtraces, which cannot be matched with specific suppressions. Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>

CI: Preserve mock config timestamps Preserve timestamps of mock configuration files when customizing them in CI to avoid unnecessary cache rebuilds. This reduces CI run time. Reviewed-by: Michal Židek <mzidek@redhat.com>

CI: Consider libcmocka-devel always present Add explicit dependency on libcmocka-devel when running on any Red Hat distros, as it turns out it exists everywhere, if only in EPEL distros, and even though the spec file doesn't require it. This makes the contrib/ci/run consider cmocka present on all the supported distros, so remove the corresponding condition as well. Reviewed-by: Michal Židek <mzidek@redhat.com>

Add basic support for CI test execution Add basic support for executing continuous integration (CI) tests on RHEL6, RHEL7, Fedora 20, Fedora Rawhide and Debian Testing. This adds two front-end scripts which can be executed either locally by developers, or on a CI server: contrib/ci/run and contrib/ci/clean. The first one will run the tests and the second will wipe out the artifacts. See contrib/ci/README.md for further details. Reviewed-by: Michal Židek <mzidek@redhat.com> Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>