core, modules: like r1657897 but for core and other modules than mod_proxy. More uses of ap_map_http_request_error() and AP_FILTER_ERROR so that we never return an HTTP error status from a handler if some filter generated a response already. That is, from a handler, either ap_get_brigade() (an input filter) returned AP_FILTER_ERROR and we must forward it to ap_die(), or ap_pass_brigade() (an output filter) failed with any status and we must return AP_FILTER_ERROR in any case for ap_die() to determine whether a response is needed or not.

Use apr_pstrmemdup instead of apr_pstrndup when this is safe.

mod_lbmethod_heartbeat, mod_heartmonitor: Respect DefaultRuntimeDir/ DEFAULT_REL_RUNTIMEDIR for the heartbeat storage file.

remove some dead code found by clang statical analyzer

Further clarify the naming of the entity that directly connects to us by calling that entity a client instead of a peer.

Various fixes for log message tags: - Remove tags in ssl_log_ssl_error() and ssl_log_cert_error() - Instead add tags to various ssl_log_xerror, ssl_log_cxerror calls (ssl_log_rxerror is unused). - likewise for modssl_proxy_info_log() - Fix spelling of APLOG_NOERRNO in coccinelle script - add support for ssl_log_*error and ap_log_cserror - add some more tags missing due to APLOG_NOERRNO spelling error - Remove tags from example modules (we don't want people to blindly copy those)

Remove usage of APLOG_NOERRNO. It has been a no-op since at least 2.0.x

Change the provider names to match the module names: mod_slotmem_shm: shared -> shm mod_socache_memcache: mc -> memcache

Add lots of unique tags to error log messages

Remove more log message prefixes that are now redundant as the the error log format includes the module name.

Replace a missed version of remote_addr with the new peer_addr.

Cleanup effort in prep for GA push: Trim trailing whitespace... no func change

fix spelling error in a couple of log messages

Continue if the platform doesnt support file perms.

fix def'n of AP_SLOTMEM_PROVIDER_VERSION, use it

Various code cleanup PR: 51398 Submitted by: Christophe Jaillet <christophe jaillet wanadoo fr>

fix some dead assignments found by the clang analyzer

Use ap_state_query() to fix many modules that were not correctly initializing if they were not active during server startup but got enabled later during a graceful restart (in which case they need to do all work during a single config run).

Fix spelling of the handler.

Avoid unnecessariy initialisation before we test handler name.

Use the new APLOG_USE_MODULE/AP_DECLARE_MODULE macros everywhere to take advantage of per-module loglevels

Make the error message correspond to the code, which sets APR_SO_NONBLOCK.

Elaborate on low hanging XXX fruit

change the callable functions in the mod_watchdog API to optional hooks to avoid module ordering or other symbol resolution issues; affected: ap_watchdog_get_instance ap_watchdog_register_callback ap_watchdog_set_callback_interval

Add port in the logic.

Add slotmem storage logic for multicast logic.

Oops my bad: Stop copying and pasting code. Remove argstr_to_table and use qs_to_table.

Fix warnings.

Add the file logic for the handler. (Next step add the slotmem logic for the multicast socket).

mark some private module data as "static", resolving a duplicate definition error from the linker

Align logic and message :)

Put the hm_slot_server_t in a common include.

* Silence compiler warnings about unused variables.

fixed types, fixed NetWare build.

Add use slotmem. Directive HeartbeatMaxServers > 10 to activate the logic. Otherwise it uses the file logic to store the heartbeats.

cleanup truncation

* Add missing include to fix compiler warnings

write Ok to tomcat.

Add a logic to use an handler and HTTP.

Remove the C++ style comment and use 1 for keep_running. (Thanks Rüdiger).

Arrange traces.

Set keep_running and clean pool if not.

clean up apr_time_from_msec() compatibility macros * where needed, base on APR_VERSION_AT_LEAST() so we remember what this is about * where not, axe

Use named watchdog for heartmonitor. The watchdog has zero interval, leaving to the callback to determine the running loop.

* modules/cluster/mod_heartmonitor.c (hm_update_stats): Flush heartbeat file before closing, to make sure the file is always written correctly, and check for errors on flush or close.

Use cmd->temp_pool for temp allocations during configuration. Suggested by: Takashi Sato <takashi lans-tv.com>

Make ctx:status an apr_status_t, and be consistent about checking and setting it. Suggested by: Takashi Sato <takashi lans-tv.com>

Use APR_THREAD_FUNC for heart{beat,monitor} thread workers. Suggested by: Takashi Sato <takashi lans-tv.com>

Also init mutex_path in hm_create_config. Suggested by: Ruediger Pluem

Print the correct enum value for the lock mech. Suggested by: Ruediger Pluem

Add a comment explaining the start mutex.

Log the correct function name. Suggested by: Ruediger Pluem

D'oh. Fix r723672 and use the correct define.

Make the frequency with how often we write the stats file a compile time option. Suggested by: Ruediger Pluem

Make hm_ctx_t:keep_running a volatile. Suggested by: Ruediger Pluem

When not configured, don't do anything by default.

Move the variable declarations to the beginning of the code blocks to avoid compiler errors on netware.

Move variable declartions to the top of functions for c89'ness.

Add two new modules to handle load balancing across multiple apache servers within the same datacenter. mod_heartbeat generates multicast status messages with the current number of clients connected, but the formated can easily be extended to include other things. mod_heartmonitor collects these messages into a static file, which then can be used for other modules to make load balancing decisions on. This module was originally written at Joost by Sander Striker, Justin Erenkrantz, and myself. We have been given permission by our employer to contribute this module.