Updated copyright notices to include the year 2018.

lib-storage: Add reason to mailbox_transaction_begin() Remove mailbox_transaction_set_reason().

global: Log internal storage error on failure

Updated copyright notices to include the year 2017.

global: Make sure *_malloc() calculations won't cause integer overflows.

lib: API change - var_expand*() now returns error string. This allows callers to fail properly if the format string is invalid.

global: Try to initialize var_expand_tab[] directly. This avoids accidents with the array numbering being wrong.

Use mail_get_*stream_because() wherever possible.

global: Require comparisons to be strict boolean expressions * No implicit integer -> boolean or pointer -> boolean conversions * !expr can be used only if expr is boolean type These were checked with a patched clang. It found various actual bugs, which were fixed by the previous commits.

global: Use hash_table_update() instead of _insert() where necessary.

Remove t_malloc in favour of t_malloc_no0 Using either t_malloc_no0 or t_malloc0 makes it clear whether the allocated memory is zeroed or not.

lib: istream - migrate to i_stream_read_more() Scripted to find all the low-hanging-fruit (single line calls), but hand-checked: git grep i_stream_read_data.*,\ 0\) | sed s/:.*// | \ xargs sed -i -e 's/i_stream_read_data(\(.*\), \(.*\), \(.*\), 0)/i_stream_read_more(\1, \2, \3)/' Signed-off-by: Phil Carmody <phil@dovecot.fi>

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

pop3: Fixed buffer overflow with handling pop3_deleted_flag setting. This has been broken since v2.2.10, although the setting wasn't working completely correctly before that version either. Afterwards it should have become obvious quickly enough that the setting is broken, because it started crashing POP3 sessions in normal use quite soon. So I doubt there are any installations that are accidentally exploitable.

lib-storage: Renamed MAIL_FETCH_UIDL_FILE_NAME to MAIL_FETCH_STORAGE_ID. Keep MAIL_FETCH_UIDL_FILE_NAME for backwards compatibility for now.

pop3: If transcation commit failed at QUIT, don't log any messages as expunged.

pop3: Added pop3_delete_type setting with values "default", "expunge" or "flag". This is related to pop3_deleted_flag setting. The main behefit here is that you can now hide messages from POP3 by setting pop3_deleted_flag, but without changing the actual deletion behavior by setting pop3_delete_type=expunge.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

pop3: Optimize POP3 UIDL processing when duplicate renaming is not active.

pop3: satisfy some strict parsing rules in RFC 1939 "Commands in the POP3 consist of a case-insensitive keyword, possibly followed by one or more arguments. All commands are terminated by a CRLF pair. Keywords and arguments consist of printable ASCII characters. Keywords and arguments are each separated by a single SPACE character." "A server MUST respond to an unrecognized, unimplemented, or syntactically invalid command by responding with a negative status indicator." Therefore the following commands must be rejected: LIST 2600Hz LIST 99 red balloons TOP 1 2 buckle-my-shoe Signed-off-by: Phil Carmody <phil@dovecot.fi>

pop3: fix msgnum/size parsers The outer if()s are completely unnecessary, and permit `num' to remain uninitialised. Spotted by clang's static analysis. Bug introduced in changeset: 17563:2ed2ab04b63d Note that the lack of a parameter from a broken client is no longer treated as "0". Before the bug was introduced: DELE -ERR There's no message 0. After this patch: DELE -ERR Invalid message number: Signed-off-by: Phil Carmody <phil@dovecot.fi>

pop3: pop3-commands - harden integer parsers against integer overflow In get_msgnum(), the invalid input "4772185884" (2^32*10/9) would be parsed as being valid. In get_size(), the invalid input "204963823041217240178" (2^64*10/9) would be parsed as being valid. We have helpers now, so use them. Signed-off-by: Phil Carmody <phil@dovecot.fi>

pop3: Remove dead assignment detected by scan-build.

pop3: Fixed assert-crash with some settings when there are 0 mails.

pop3: Fixed off-by-one bug in the sequence number fix of d20059f7d3a1.

pop3: Access sequence numbers correctly.

pop3: Use POP3 order sorting only when directly listing UIDLs. "Message ordering changed unexpectedly" errors can be completely avoided by using either pop3_lock_session=yes or adding %u to pop3_logout_format.

Updated copyright notices to include year 2014.

pop3: Handle UIDL failures by disconnecting the client instead of killing the whole process.

pop3: Avoid assert-crash if client disconnects during LIST.

pop3: Added pop3_deleted_flag setting.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.