imap, pop3: Remove unnecessary call to mail_storage_service_io_deactivate() The context is automatically deactivated when service user is freed.

pop3: move pop3 session locking out of client_create As a result, we can directly return the client structure (instead of passing it back via a _r arg). This makes the pop3 client_create look more like the imap version.

pop3: Add client.destroyed boolean

global: Make sure *_malloc() calculations won't cause integer overflows.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

pop3: Send "OK Logged in" before reading mailbox. This way if the reading takes a long time, the client still sees that the login itself was successful. This is especially useful to avoid unnecessary errors logged by proxies.

pop3: Fixed buffer overflow with handling pop3_deleted_flag setting. This has been broken since v2.2.10, although the setting wasn't working completely correctly before that version either. Afterwards it should have become obvious quickly enough that the setting is broken, because it started crashing POP3 sessions in normal use quite soon. So I doubt there are any installations that are accidentally exploitable.

pop3: If transcation commit failed at QUIT, don't log any messages as expunged.

imap, pop3: Show user's proper log prefix when deinitializing users at exit.

pop3: Added pop3_deleted_flag setting.

pop3: Fixed infinite looping

pop3_lock_session: Use a separate dovecot-pop3-session.lock file instead of mailbox lock. This changes the behavior in a way that it's now possible for IMAP sessions to expunge mails during a POP3 session. But now it's no longer possible for POP3 sessions to hang new mail deliveries.

pop3: Minor code cleanup

Array API changed: ARRAY_DEFINE(name, type) -> ARRAY(type) name Easy way to update your existing code: perl -i -pe 's:ARRAY_DEFINE\(([^,]+), *([^)]+)\);:ARRAY($2) $1;:' **/*.[ch]

Make sure we check all the functions' return values. Minor API changes to simplify this. Checked using a patched clang that adds attribute(warn_unused_result) to all functions. This commit fixes several error handling mistakes.

Marked functions parameters that are allowed to be NULL. Some APIs were also changed. The non-obvious APIs where NULL parameter was changed to "" are master_service_init() and auth_master_user_list_init(). These checks can currently be enabled only on a patched clang: http://llvm.org/bugs/show_bug.cgi?id=6786

pop3: Added pop3_uidl_duplicates setting.

Added a "session ID" string for imap/pop3 connections, available in %{session} variable. The session ID passes through Dovecot IMAP/POP3 proxying to backend server. The same session ID is can be reused after a long time (currently a bit under 9 years).

pop3: Added module contexts to struct client, and made client_destroy() a virtual method.

pop3: Added support for showing messages in "pop3 order".

pop3: Small code cleanup.

pop3: Added %u=old/new UIDL hash to pop3_logout_format. It expands to "<old msg count>/<old hash> -> <new msg count>/<new hash>" or if they're the same, simply "<msg count>/<hash>". The idea is that if previous session's <new hash> doesn't match next one's <old hash> and prev.new_msg_count = next.old_msg_count, it could indicate that the UIDLs changed for some reason. But if they do match and client still redownloaded messages, it's most likely a client side problem. --HG-- branch : HEAD

pop3: Added support for verbose_proctitle=yes --HG-- branch : HEAD

Merged single and multi mail_storage_service_*() functions. --HG-- branch : HEAD

Redesigned how login process passes connections to mail processes and changed related APIs. Master process is no longer in the middle. --HG-- branch : HEAD

imap, pop3: Moved imap/pop3_client_workarounds setting parsing to config checking. --HG-- branch : HEAD

imap, pop3 no longer assume that there's only a single client in process. --HG-- branch : HEAD

Implemented anvil service, which is used to implement mail_max_userip_connections. --HG-- branch : HEAD

Renamed headers to prevent collision if they were flattened on an install. --HG-- branch : HEAD