Updated copyright notices to include the year 2018.

imap, pop3: Remove unnecessary call to mail_storage_service_io_deactivate() The context is automatically deactivated when service user is freed.

pop3: Include mail user variables in logout format

global: Fix spelling mistakes in comments Original work by @andreasschulze and @jsoref

lib-storage: Add reason to mailbox_transaction_begin() Remove mailbox_transaction_set_reason().

global: start relying on pool_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - pool_unref(&E); - } + pool_unref(&E);

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

global: start relying on io_remove{,_closed}(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - io_remove(&E); - } + io_remove(&E); @@ expression E; @@ - if (E != NULL) { - io_remove_closed(&E); - } + io_remove_closed(&E);

pop3: initialize namespaces explicitly (instead of relying on mail user initialization to instantiate them for us)

pop3: move pop3 session locking out of client_create As a result, we can directly return the client structure (instead of passing it back via a _r arg). This makes the pop3 client_create look more like the imap version.

global: Add mailbox_set_reason() calls Added to the most important places.

lib-storage: Replace MAIL_STORAGE_SERVICE_FLAG_AUTOEXPUNGE with explicit mail_user_autoexpunge() This allows better control of which users are being autoexpunged. This patch changes behavior at least in two ways now: 1) After shared folder access, the owner user isn't autoexpunged at deinit. Although this is a bit questionable of whether it should be or not. 2) LMTP's quota check at RCPT TO stage doesn't trigger autoexpunging.

pop3: Start autoexpunging only after client is disconnected

global: Log internal storage error on failure

global: Log mailbox_list internal errors

imap, pop3, indexer-worker: Add (deinit) to process title before autoexpunging runs. lmtp should also do this, but it needs a bit larger changes.

pop3: Add client.destroyed boolean

pop3: Set process title before syncing mailbox. The syncing could be taking a long time, so it's useful to have the username in the process title during that.

global: Replace mail_storage_service_user_free() with _unref()

lib-storage: Add explicit MAIL_ERROR_LOOKUP_ABORT error The MAIL_ERROR_NOTPOSSIBLE was a bit too generic to assume to mean the same thing. It doesn't look like there are any external plugins that break because of this change.

Updated copyright notices to include the year 2017.

global: Use fd_close_maybe_stdio()

lib: API change - var_expand*() now returns error string. This allows callers to fail properly if the format string is invalid.

global: Try to initialize var_expand_tab[] directly. This avoids accidents with the array numbering being wrong.

pop3: Fix pop3_logout_format=%{deleted_size} expansion when there are no deletions Should be "0", not empty string.

imap, pop3: Added rawlog_dir setting to store IMAP/POP3 traffic logs. This at least partially replaces the "rawlog" post-login binary. For now the "rawlog" binary supports some parameters, which aren't configurable for rawlog_dir.

pop3: Fix deleted_count expansion

global: Removed redundant corking in ostream flush callbacks.

global: Require comparisons to be strict boolean expressions * No implicit integer -> boolean or pointer -> boolean conversions * !expr can be used only if expr is boolean type These were checked with a patched clang. It found various actual bugs, which were fixed by the previous commits.

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

Remove t_malloc in favour of t_malloc_no0 Using either t_malloc_no0 or t_malloc0 makes it clear whether the allocated memory is zeroed or not.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

pop3: Make sure pop3_lock_session=yes creates the lock's directory if it's missing. This happened at least with mbox if the root .imap/ didn't exist yet.

pop3: When creating session lock file, prefer to write it to the index root dir. This is especially important for mail storage backends that don't have a mail root directory.

pop3: Send "OK Logged in" before reading mailbox. This way if the reading takes a long time, the client still sees that the login itself was successful. This is especially useful to avoid unnecessary errors logged by proxies.

pop3: Fixed buffer overflow with handling pop3_deleted_flag setting. This has been broken since v2.2.10, although the setting wasn't working completely correctly before that version either. Afterwards it should have become obvious quickly enough that the setting is broken, because it started crashing POP3 sessions in normal use quite soon. So I doubt there are any installations that are accidentally exploitable.

Remove now-unnecessary direct stdlib.h #includes.

Use io_stream_get_disconnect_reason() instead of duplicating its code all over the place.

pop3: Added %{deleted_bytes} variable to pop3_logout_format

pop3: If transcation commit failed at QUIT, don't log any messages as expunged.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

imap, pop3, lmtp: If client gets disconnected due to iostream error, log the full error.

imap, pop3: Show user's proper log prefix when deinitializing users at exit.

pop3: Fixed potential assert-crash on disconnect.

Handle "out of disk space" and "out of user quota" as separate cases. "Out of disk space" is a temporary error that should be logged as error and the failure should be sent to user as "Internal server error". Obsolete the use of MAIL_ERROR_NOSPACE and MAIL_ERRSTR_NO_SPACE. Use the clearer MAIL_ERROR_NOQUOTA and MAIL_ERRSTR_NO_QUOTA instead.

imap, pop3: Remove the client from clients-list at the very end of the destroy function. Especially with imap code the process title could have been refreshed too early.

Use io_add_istream() wherever possible. This shouldn't fix anything, but might make some functionality easier to implement in future.

Updated copyright notices to include year 2014.

pop3: Fixed crash at deinit

pop3: Added pop3_deleted_flag setting.

pop3: Fixed infinite looping

pop3_lock_session: Use a separate dovecot-pop3-session.lock file instead of mailbox lock. This changes the behavior in a way that it's now possible for IMAP sessions to expunge mails during a POP3 session. But now it's no longer possible for POP3 sessions to hang new mail deliveries.

pop3: Minor code cleanup

pop3: Use RFC 3206 [SYS/*] and [AUTH] response codes.

pop3: Code cleanup: INBOX always exists, no need to check for it here.

Oops :) Update copyrights to 2013 without breaking all .c files.