zlib: Contexts are now required or checked Satisfies static analyzers

Updated copyright notices to include the year 2018.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

zlib: zlib_mailbox_open_input() can't fail - remove dead code

global: start relying on [io]_stream_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_unref(&E); - } + i_stream_unref(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_unref(&E); - } + o_stream_unref(&E);

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

plugins: Remove unnecessary mail_save_context.dest_mail==NULL checks It can never be NULL after the previous change: "lib-storage: Always create mail_save_context.dest_mail".

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

zlib-plugin: Check that UID is assigned When caching, code has to check whether UID is assigned to avoid reusing cache for different email since they all have UID = 0 before they are actually committed.

zlib: Compiling fix to a1630a3b3 - don't return a void function

zlib plugin: Make sure we don't keep mail istream referenced after mail is closed.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

zlib: Fixed copying causing cache corruption when zlib_save wasn't set. dovecot.index.cache entries were broken/missing if: - The zlib plugin is enabled; - The zlib_save/zlib_save_level options are NOT enabled; - The source message being copied is compressed; - The mail_log plugin is logging "copy" events; - The mail_log_fields setting includes at least one message header; - The destination mailbox folder has an index file that is recording the logged headers; - The source mailbox folder does NOT have an index file recording the logged headers. Found by Robert L Mathews.

Remove now-unnecessary direct stdlib.h #includes.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Use the new [io]_stream_create_fd_*autoclose() functions wherever possible.

Updated copyright notices to include year 2014.

zlib: Give a name to zlib istreams

Fixed file descriptor leaks in rather unimportant places. Found by Coverity scan.

zlib: Enable only for storages that support MAIL_STORAGE_CLASS_FLAG_BINARY_DATA

zlib plugin: Removed explicit checks for maildir/sdbox/mdbox.

zlib: Keep the last read mail cached uncompressed in a temp file. This fixes performance problems with partial IMAP FETCH commands.

zlib: Don't crash when trying to use zlib_save for handler that isn't compiled in.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.