virtual: Contexts are now required or checked Satisfies static analyzers

Updated copyright notices to include the year 2018.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

virtual: Fix crash when saving to virtual mailbox whose physical box doesn't exist For example if using "!foo" in dovecot-virtual and "foo" doesn't exist, it crashed. Now it gives a nice error message instead.

virtual: Do not remove mailbox notify if the mailbox is closed The backend mailbox close/open status is not related to the notify API usage. The notify is removed in virtual_mailbox_close_internal instead when we are actually deinitializing.

virtual: Optimize mailbox_notify_changes() when there's only a single backend mailbox

virtual: Stop watching notification on backend box close Fixes Panic: file mail-index.c: line 662 (mail_index_close_nonopened): assertion failed: (index->views == NULL)

virtual: Stop notifications only if they were started Fixes Panic: file mail-storage.c: line 1950: assertion failed: (box->opened)

virtual: Append virtual mailbox name to open reason on box alloc

virtual: Use mailbox_notify_list API when mailbox_list_index is enabled

virtual: Generate GUID for virtual folder GUID is generated when index is first created or the rules change.

virtual: Avoid assert-crash if backend mailbox's have_guid lookup fails The MAIL_ERROR_NOTFOUND can happen if the mailbox was already deleted. Other errors aren't expected to happen and possibly point to a bug. Fixes: Panic: file mail-storage.c: line 1831: unreached

global: Add mailbox_set_reason() calls Added to the most important places.

global: Ignore unnecessary return values.

Updated copyright notices to include the year 2017.

lib-storage: Add mail_storage.list_index_corrupted() The actual implementation is in the next commit.

virtual: Compiler warning fix for list_index_has_changed() API change

virtual: Moved virtual_mailbox_vfuncs to lib-storage. This allows implementing other virtual storage backends.

virtual plugin: Fixed off-by-one in virtual_max_open_mailboxes check.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

virtual: Fixed assert-crash when opening virtual mailbox triggered backend mailbox autocreation. Fixes assert: Panic: file virtual-storage.c: line 335 (virtual_mailbox_opened_hook): assertion failed: (!bbox->open_tracked)

virtual plugin: Fixed assert-crash on mailbox_status() if virtual mailbox wasn't opened yet. We no longer require that mailboxes must not be auto-opened.

virtual plugin: Fixed crash on mailbox_status() if virtual mailbox wasn't opened yet. mbox->backend_boxes is initialized only when mailbox is opened.

virtual plugin: Auto-close mailboxes by hooking into backend's mailbox_open() This is a more reliable way of doing it. The earlier version had problems that all the backend mailboxes could be opened when doing a search on the virtual mailbox (for getting the GUID of the mailboxes).

virtual plugin: Fixed assert-crash when closing a virtual mailbox consisting of many real mailboxes.

Remove now-unnecessary direct stdlib.h #includes.

virtual plugin: Disable caching via mailbox list indexes. Otherwise e.g. STATUS can give stale replies.

virtual: Added more asserts.

virtual plugin: Read virtual index header when opening virtual mailbox. This allows doing some mailbox accessing without actually syncing the mailbox. For example MAIL_FETCH_MAILBOX_NAME can be used without crashing.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

virtual plugin: Fixed assert-crash when backend mailbox was auto-closed while it had pending expunges.

virtual: Make sure modseqs are always enabled for backend mailboxes. mailbox_get_status() wasn't adding a missing highestmodseq otherwise to the mailbox list index.

virtual: Fixed assert-crashes where trying to open an already opened backend mailbox.

virtual: Never keep more than specified number of physical mailboxes open. This should make virtual mailboxes work for users who have a a ton of mailboxes with a ton of mails. Earlier code would likely have failed either with "Too many open files" or crashed with "Out of memory". You can change the max number of open mailboxes with: plugin { virtual_max_open_mailboxes = 64 } The default is 64.

virtual: Recent flags dropping wasn't working as intended. In the old code '+' meant that \Recent flags were dropped also when the virtual mailbox was EXAMINEd. SELECTing a mailbox always dropped \Recent flags regardless of the '+' flag. What should have happened (and does in new code) is that the \Recent flags are dropped only on SELECT and only if '+' flag is set.

virtual: Crashfix: Don't deinitialize search args that haven't been initialized.

virtual: Fixed assert-crash in IDLE caused by earlier changes. This change negates all the improvements of the earlier changes when IDLE is used. This could be fixed by using mailbox-list-notify.h API.

virtual: Delay initializing search args until the mailbox is actually opened. Fixes assert-crash caused by recent changes when virtual mailbox search args contained e.g. keywords.

virtual: Delay opening the backend mailboxes until it's really necessary. This should improve the performance a lot with mailbox_list_index=yes when opening virtual mailboxes whose backend mailboxes are mostly unchanged.

Updated copyright notices to include year 2014.

lib-storage: Added mailbox_status.have_save_guids.

lib-storage: Added mailbox_status.have_guids flag

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.