quota-clone: Contexts are now required or checked Satisfies static analyzers

Updated copyright notices to include the year 2018.

quota: Add QUOTA_GET_RESULT_BACKGROUND_CALC enum value

quota-clone: Rename ret_bytes and ret_count to bytes_res and count_res This is because the variables do not contain the actual quota resource values but whether the lookup was successful.

quota: Add error_r to quota_get_resource()

global: Use PRI* macros and %zu instead of casting

quota: quota_get_resource() - return enum to make the result more exact This is mainly to differentiate between "resource name unknown" and "unlimited quota". This also fixes quota_clone plugin to update quota even when quota is unlimited. It was supposed to have been skipped only when the resource names weren't known. The private quota.get_resource() API is unchanged. The backends were already returning 0 only when the resource name was unknown.

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

quota-clone: Don't clone quota resources that aren't enabled. They would always just be zeros anyway, so this makes the update slightly more efficient. Although practically this only matters with dirsize and fs quotas, which people generally don't use with quota_clone.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

quota-clone: Flush quota-clone 10s after quota update if it's not already done This way a long-running IMAP session can't keep the quota-clone desynced for a long time.

quota-clone: Code cleanup - moved recursion check to quota_clone_flush()

quota_clone plugin: quota_clone_mail_user_created warned without debug "The quota_clone_dict setting is missing from configuration" warning would be thrown when debug mode was not enabled. This warning happens under normal circumstances when prefix="" namespace is not defined (usually when set to INBOX.) See http://dovecot.org/list/dovecot-cvs/2012-October/021981.html for more details on the automagic prefix="" namespace. This change suppresses the spurious warning.

lib-dict: dict_transaction_commit*() returns now error string

lib-dict: Renamed dict_init_full() to dict_init()

quota-clone: Avoid leaving a dict transaction open for unnecessarily long. Even though the earlier change should fix the dict assert crash due to opening multiple transactions when recursing back, this makes sure of it. It could also be helpful for some dict backends to not keep the transaction open for unnecessarily long.

quota-clone: Fixed update-recursion crash when closing mailbox. We need to avoid recursing for all mailboxes that quota recalculation might open and close, not just the one that triggered the recalculation.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

quota-clone: Avoid assert-crash when quota recalculation is triggered. Quota recalculation opened all mailboxes and got us back to quota_clone_flush(), which caused another dict transaction to be opened, which caused a crash with some dict backends.

quota-clone: Memory leak fix when mailbox had no quota roots.

Added quota-clone plugin.