lazy-expunge: Fix context checking Was not done properly in 462a3d92adcde4bfa9a575875bd8ae740b89ce9e

lazy-expunge: Contexts are now required or checked Satisfied static analyzers

Updated copyright notices to include the year 2018.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

lazy-expunge: Fix spelling mistakes Original work by @jsoref

lib-storage: Add reason to mailbox.transaction_begin()

lib-storage: Add reason to mailbox_transaction_begin() Remove mailbox_transaction_set_reason().

global: start relying on pool_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - pool_unref(&E); - } + pool_unref(&E);

lazy-expunge: Log internal errors instead of just "Internal error occurred"

global: Add mailbox_set_reason() calls Added to the most important places.

global: Log internal storage error on failure

lazy-expunge: Use mailbox_move() instead of mailbox_copy() This allows some optimizations to be performed that are only possible when moving messages. It's slightly strange now that mail_expunge() is triggered twice for the same source mail, but lazy_expunge plugin is called very early so most plugins won't see it called twice. Currently only acl plugin sees it, and it doesn't care.

lazy-expunge: Fix error handling for GUID lookups If the mail is already expunged, the error should be ignored. In other situations the original error string should be preserved as part of the logged error message.

Updated copyright notices to include the year 2017.

lazy-expunge: If lazy-expunge transaction failed already, stop further expunges. Most importantly if the lazy-expunge mailbox opening fails, we don't now retry opening the mailbox for each expunged mail.

lazy-expunge: Fixed crash when copying from internal namespace Most importantly fixes crash in LDA.

lazy_expunge: Optimize checking for last instance when moving a mail. It's never the last instance, so we don't need to even check it.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

lazy-expunge: Fixed crash on error handling

lib-storage: Added MAILBOX_FLAG_DELETE_UNSAFE

lazy-expunge: Don't fail expunge if mail was already expunged.

lazy-expunge: Fixed error logging.

lazy-expunge: Handle mailbox create race conditions. Don't log an error if another process just created the lazy-expunge mailbox.

global: Use mail_user_plugin_getenv_bool() wherever possible New API is used to check boolean setting OR exsitence of an env variable.

lazy-expunge: Open the mailbox with ACLs ignored.

lazy-expunge: Open mailbox with MAILBOX_FLAG_SAVEONLY flag.

lazy-expunge: Fixed using a mailbox (instead of namespace) as lazy_expunge destination. The initial implementation in f2d7ae020bda762f78e8e639a69fb129230cbb7d was completely broken.

lazy-expunge: Allow lazy_expunge setting to point to a mailbox in any namespace. This way we can use an existing namespace without having to create a new one just for a single lazy_expunge mailbox.

lazy-expunge: Fixed crash if lazy_expunge-namespace was not found.

lazy-expunge: If lazy_expunge is set to namespace root, save all mails to the root mailbox. So the difference is: namespace { prefix = expunged/ .. } plugin { # Move expunged mails to expunged/INBOX, expunged/Trash, etc. mailboxes lazy_expunge = expunged/ # Move all expunged mails to "expunged" mailbox, which is the namespace root. lazy_expunge = expunged }

lazy-expunge: Code cleanup - move destination mailbox name generation to its own function

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Remove now-unnecessary direct stdlib.h #includes.

lazy-expunge: If MAIL_FETCH_REFCOUNT fails because mail is expunged, ignore the error.

lazy-expunge: If MAIL_FETCH_REFCOUNT fails, log the storage error.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Replaced mail_get_real_mail() callers with mail_get_backend_mail()

lazy_expunge: If setting is empty, disable the plugin. Instead of assuming that we want to use prefix="" as the lazy_expunge namespace, which is highly unlikely anyone will ever want to do.

lazy_expunge: If lazy-expunge mailbox open/create fails, show the mailbox name in error message.

Updated copyright notices to include year 2014.

lazy-expunge: If lazy_expunge_only_last_instance is set, copy only last instances of mails. Requires storage backend to support refcounts.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.