Updated copyright notices to include the year 2018.

plugin-fts: Fix spelling mistakes Original work by @jsoref

global: start relying on [io]_stream_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_unref(&E); - } + i_stream_unref(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_unref(&E); - } + o_stream_unref(&E);

global: start relying on i_close_fd(-1) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != -1) - i_close_fd(&E); + i_close_fd(&E);

Updated copyright notices to include the year 2017.

plugins: fts - replace i_assert under _expunge_log_subtract with warning (API change) The helper whose interface is changing currently has no other known clients (there's little need for it to be exposed at all). This should never happen, but if it does, just tally the number of times it happened, and squirt out a warning message after the whole subtract. If it happens at all, there's no reason not to expect a lot, so only warn once per file. In particular - do not assert crash when this is seen - it has been seen on live test systems where file corruption seems to have occured. As this can only be associated with corrupt fts indexes, seeing this error implies that the whole FTS index should be rebuilt for that user. Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

global: Use [io]_stream_get_error() insted of %m

global: Fixed slighty wrong i_stream_read_data() with _read_bytes() These calls were reading one byte more than they were intended to read. This didn't really cause any problems, but now they're correct.

lib: istream - more migration to i_stream_read_bytes() This time a coccinelle semantic patch, again hand checked: git grep 'i_stream_read_data' | sed s/:.*// | \ while read f; do spatch --sp-file istream.cocci --in-place "$f" ; done -- 8< --- istream.cocci --- @@ expression e1, e2, e3, e4; @@ - i_stream_read_data(e1, e2, e3, e4 - 1) + i_stream_read_bytes(e1, e2, e3, e4) -- 8< --- end Signed-off-by: Phil Carmody <phil@dovecot.fi>

plugins: fts-expunge-log - subtraction from and dumping of a flattened log This permits you to read a whole expunge log, remove records from the in-memory copy of it, and write it back out to file. NOTE: Inefficiently implemented. The hash is effectively rebuilt, this time backed by a file, a record at a time, which implies O(n^2) possibilities. Signed-off-by: Phil Carmody <phil@dovecot.fi>

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Replaced unlink() calls with i_unlink*() wherever possible.

fts: Added back fts_expunge_log_uid_count() This was accidentally removed by commit 5091f03d70e1

plugins/fts: use common guid_128 helpers Signed-off-by: Phil Carmody <phil@dovecot.fi>

plugins/fts: expunge-log - query function to lookup GUID/UID Constant time hash lookup for GUID. Log time lookup in seq_range array. Signed-off-by: Phil Carmody <phil@dovecot.fi>

plugins/fts: expunge-log - create flattened in-RAM log with no backing storage Combine each record in a source expunge log. This source log does not get deleted afterwards. Signed-off-by: Phil Carmody <phil@dovecot.fi>

plugins/fts: expunge-log - pull mailbox finding/creating into a helper There will be more clients than just this one. Signed-off-by: Phil Carmody <phil@dovecot.fi>

plugins/fts: expunge-log - permit append helpers to have no log to write to This is for creating an in-RAM, later queriable, structure which you do not want to be written to backing storage. As when you've finished with one, there's no concept of a "commit", provide an alternative "abort" way out. These are identical apart from the call to the write() routine, so refactor the two. Signed-off-by: Phil Carmody <phil@dovecot.fi>

plugins/fts: expung-log - add the concept of not unlinking at the end No behavioural differences, the default is to unlink. Signed-off-by: Phil Carmody <phil@dovecot.fi>

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

fts: dovecot-expunges.log wasn't closed at deinit

fts: If we detect corrupted fts expunge log, unlink it. This avoids the same error repeating forever.

Updated copyright notices to include year 2014.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.

Renamed buffer_create_*data() to buffer_create_from_*data() for consistency. Especially i_stream_create_from_data() was a very similar function, which made it difficult to remember which one should have "from" and which one shouldn't.

Reverted "support for non-pointers" part of the hash table API changes. Originally I wrote it using clang, which didn't give as many warnings as gcc did. I guess this way is safer anyway..

Hash table API is now (mostly) type safe.