global: start relying on str_free(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - str_free(&E); - } + str_free(&E);

acl: Contexts are now required or checked Satisfies static analyzers

Updated copyright notices to include the year 2018.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-storage: remove unused internal_attribute argument from attribute_{get,set} This removes an argument added in 9f37ef2a9192e7d47e3d7ac959080fd01120f2e9 but obsoleted (but not removed) in d1147c225f64596fc5eeb1cb2aab31b3c57d5215. Not only does this change simplify the codebase, it actually brings the API closer to what it was back in 2.2.

acl-plugin: Whitespace fixes

acl-plugin: Deinit acl_iter on deinit too

acl-plugin: Make iterators more conforming The *_next functions return true/false, deinit will report errors and end result.

global: Update mailbox_attribute_get API usage

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

acl: Fixed handling mailbox deletion when only "delete" right was available. So especially when there were no "lookup" or "read" rights.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.

Removed ambiguous mail_user.admin flag. dsync shouldn't sync mailboxes without +r ACL.

lib-storage: Mailbox attributes can now be accessed via istreams. The idea is to use istreams for larger values.

acl: Don't iterate ACL attributes if prefix has no chance of matching them.

acl: Preserve dovecot-acl file's mtime when dsyncing.

lib-storage: mailbox_attribute_set() now uses struct mail_attribute_value. This allows settig the last_change value, as well as using streams and setting other flags in future.

acl: Added ACL checks for attributes. Added ACL <-> mailbox attribute mapping. The ACL checks will be useful once IMAP METADATA extension is finished. The mapping is used by dsync to sync ACLs via generic attribute syncing.