Updated copyright notices to include the year 2018.

global: stop including fd-set-nonblock.h & fd-close-on-exec.h directly

master: Don't throttle services that are already being destroyed If process couldn't be created, because the service_list is already being destroyed (e.g. due to reload), also don't enable unnecessary throttling for the service. Hopefully fixes these random errors that are logged alone: master: Error: service(...): command startup failed, throttling for 2 secs

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

global: start relying on io_remove{,_closed}(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - io_remove(&E); - } + io_remove(&E); @@ expression E; @@ - if (E != NULL) { - io_remove_closed(&E); - } + io_remove_closed(&E);

global: start relying on i_close_fd(-1) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != -1) - i_close_fd(&E); + i_close_fd(&E);

global: use i_rand_limit() and i_rand_minmax() when possible

global: Replace rand with i_rand

master: Change service "connections are being dropped" warning interval to 1 second When this is happening, it's often accompanied with all kinds of other errors and these warnings drown in them. Make them easier to notice by reducing the interval from 60 seconds to 1 second.

master: Send SIGQUIT to processes running at deinit to close socket listeners. This allows Dovecot to be restarted even when some lmtp/doveadm process is running for a long time. Otherwise it would keep the inet_listener socket open and prevent the new Dovecot from binding to the port.

master: Wait more precisely 5 secs at deinit for child processes to die. Use milliseconds granularity instead of seconds.

master: Don't crash if master socket couldn't be re-opened after settings reload.

master: Remove unnecessary service listener start The listening was already started later on in the same function. Also in some cases it would have been started unnecessarily, like when service was stopped or more processes were created immediately.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

master: Add master socket's io listener later. Most importantly this fixes startup failure with kqueue: Panic: kevent(EV_ADD, READ, 56) failed: Bad file descriptor kqueue doesn't survive a fork(), so this change delays its creation until after fork().

master: Stopping didn't close dead-pipes early enough. This caused stopping to be too slow. Broken by 0153cf542.

master: Allow stopping specific services via master socket.

master: Added service_monitor_stop_close() to stops service and close its listeners.

master: Added support for stopping specific services. We need to have a per-service fd for detecting a dead master.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Remove now-unnecessary direct stdlib.h #includes.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

master: Don't start new processes while shutting down.

master: If log process crashes, restart it immediately. The regular service_monitor_listen_start() doesn't work for it, because the log fds aren't in the listeners.

Updated copyright notices to include year 2014.

master: Fix to previous pre-forking change.

master: Pre-fork processes only while master doesn't have more important things to do.

Replaced all -1U and (unsigned int)-1 with UINT_MAX. It's somewhat clearer this way. Also clang's -fsanitize=integer gives runtime errors about -1U (but not about explicit casts, so no need to change (type)-1 casts).

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.