Updated copyright notices to include the year 2018.

master,stats: Use time_t instead of unsigned long to count seconds

global: stop including fd-set-nonblock.h & fd-close-on-exec.h directly

global: Remove dead code Found with clang static analyzer.

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

global: use i_rand_limit() and i_rand_minmax() when possible

master: Write all the early warnings to log file after logging is initialized Any warnings (or errors) logged before settings were read and logging was initialized caused them to be only written to stderr. This caused them to be lost too easily. Now they are also buffered in memory and then flushed to log files once logging is initialized.

global: Replace rand with i_rand

master: Improve killing processes when they don't die after reload The old behavior was: 1. Send SIGTERM to all processes, except log 2. Send SIGTERM to all processes, including log 3. Send SIGKILL to all processes, including log The new behavior is now: 1. Send SIGTERM to all processes, except log 2. Send SIGKILL to all processes, except log Only after there aren't any processes left except log, send SIGTERM to it. If that doesn't work, send SIGKILL.

lib-master: master_service_import_environment() - use a data stack frame This way the caller doesn't have to do it.

master: Move master_set_import_environment() to lib-master

master: Append to existing DOVECOT_PRESERVE_ENVS instead of overwriting it

master: Move import_environment setting to lib-master's master_service_settings

dovecot --build-options: Add missing linefeed

configure: Remove --with-storages parameter Just compile all the storages, since the only benefit in limiting them is to save a tiny bit of disk space. The recently added imapc quota code fails to link if imapc storage isn't compiled in. This is the simplest way to fix that.

master: add cassandra to printed build options

lib: Add error_r to t_abspath and its callers

lib: Rename abspath to path-util

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

master: Update assert to make sure optind != 0 Hopefully prevents Coverity warning about "doubleops[optind]" access being uninitialized.

master: Removed unused process_exec(extra_args) parameter Removes unnecessarily complicated code marked with @UNSAFE.

global: use dev_null_fd instead of opening /dev/null

master: Don't unlink login sockets at startup if someone is listening to them. The original check there never worked, because null_fd was always set. Normally the master.pid file would prevent this happening, but if it didn't exist, the sockets would be unlinked and usually also created back.

master: Remove redundant check to guarantee stdin/stdout/stderr fd existence. The previous method also wasn't correct, since it was setting close-on-exec flag for the fds. Although this didn't normally make any difference, since stdin & stdout was explicitly dup2()ed to /dev/null and for all except the log process stderr was also being dup2()ed.

master: Allow stopping specific services via master socket.

lib-master: Add automatic data stack frame to init unless disabled.

Require IPv6 to build

master: Do not close stdout if going foreground This lets one to use /dev/stdout for logging. Mainly useful for testing purposes where we can generate log output to stdout and use tee to write it to a file for later examination.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Remove now-unnecessary direct stdlib.h #includes.

Replaced unlink() calls with i_unlink*() wherever possible.

Removed all invocations of strtoll() and friends.

Removed all invocations of atoi().

Removed support for dnotify. Everybody should be using inotify by now.

Removed mountpoint checking and updating code. After a few years it seems like it has just caused more problems than it has actually fixed. The only thing it's been used for is to make sure that Dovecot can't create empty user directories when the user's mail filesystem isn't mounted. But that's supposed to be normally prevented already if the mount root directory permissions are only writable by root. For now the mountpoint listing code and doveadm mount code still exists just in case people have some scripts using those. Those could be removed in v2.3. If we somehow figured out which mountpoints existed (not so easy because they could be only visible in userdb lookups for different users), we could maybe create some kind of a script that checks the permissions at startup. This would work with Linux at least: mkdir test mount / -o bind test ls -ld test/var/mail # assuming /var/mail mountpoint umount test

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Check for syscall errors that are quite unlikely to happen. Flagged by Coverity.

Added various asserts to try to silence Coverity false positives.

lib: pair VA_COPY with va_end A va_copy creates a initialised va_list, as if a va_start had been done on it. Therefore, pedantically, a va_end should also be done on it. On most platforms this is a no-op, and for those where it isn't, the pairing is important. Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.

master: Include used protocols in the "starting up" log message.

master: Make sure new processes aren't created after stop signal is received.

Fixed off-by-one buffer overflows (practically non-exploitable). Found by Coverity scan.

master: Added --hostdomain to the help message.

master: Added --hostdomain setting to show the current hostdomain.

master: Don't close stderr. If log process fails at startup, the errors are logged there.

Oops :) Update copyrights to 2013 without breaking all .c files.