lmtp: Move common recipient handling code to separate file.

lmtp: Removed useless ssl_start parameter for client_create(). The same information is already contained in the conn parameter.

lmtp: Changed message data handling to use iostream-temp. The existing code predates iostream-temp.

lmtp: client: Made client_remote_id() static.

lmtp: Ported to use lib-smtp/server. Implicitly fixes handling of multi-line replies from proxy backend. Implicitly adds support for mixing local and proxy recipients. Implicitly adds support for SMTP CHUNKING. RCPT failures are reported back to the client immediately, rather than waiting for the DATA command.

lmtp: Split off local delivery in a struct separate from the client. This mimics proxy delivery, making the implementation better structured.

lmtp: client: Dropped useless rcpt_idx state. Recent refactoring made it obsolete.

lmtp: Renamed struct mail_recipient to struct lmtp_recipient.

lmtp: client: Moved soon-to-be-obsolete output handling functions to end of the file.

lmtp: client: Moved soon-to-be-obsolete input handling functions to end of the file.

lmtp: Moved client_rcpt_anvil_disconnect() from client.c to lmtp-local.c.

lmtp: proxy: Changed implemention to use lib-smtp/smtp-client.

lib-lda: Added SMTP parameter fields to struct mail_deliver_context. This moves the original recipient field inside the SMTP parameters. This also affects both lda and lmtp. Changes are applied there accordingly.

lib-lda: Changed struct mail_deliver_context address fields to use the new struct smtp_address type.

lmtp: Increase user's concurrency limit already after RCPT TO. This way it's not possible for a lot of mails to arrive to user concurrently and bypass the lmtp_user_concurrency_limit.

lmtp: If user has rached lmtp_user_concurrency_limit, fail at RCPT TO stage. Otherwise LMTP client would have to send the entire email body before getting the failure.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

lmtp: Use separate session ID suffixes for each RCPT TO delivery. Otherwise each delivery will use the same session ID when talking to stats process, which results in errors like: Error: stats: FIFO input error: CONNECT: Duplicate session ID ME3ZHCi+A1dUDQAAvAUe3g for user foobar service lmtp Warning: stats: Couldn't find session ID: ME3ZHCi+A1dUDQAAvAUe3g (There was a DISCONNECT for the session ID between these two log lines.)

Changed type of internet port values to in_port_t everywhere. Created special SET_IN_PORT setting type for internet port values. Created net_str2port() for parsing internet port values. Removed several atoi() invocations in the process.

lda, lmtp: Added delivery_time and session_time variables to deliver_log_format session_time is meaningful only with LMTP. The delivery_time is separate for each mail delivery. The results are in milliseconds now. If needed we could add a new %modifier that converts it into secs.millisecs.

lmtp: Added lmtp_user_concurrency_limit setting. This allows limiting the number of concurrent deliveries to a single user. Useful in case one user is receiving a lot of mails and causing other deliveries to be delayed. If the limit is reached, Dovecot returns temporary failure error at DATA stage.

lmtp: Changed rcpt_to array to contain pointers to struct mail_recipient This allow storing the pointers so they don't change.

lmtp: Added support for DSN ORCPT parameter. If the parameter is specified, it's used as the original recipient address in Sieve. The ORCPT parameter is also proxied to destination LMTP server if used (without checking if it supports it). We don't currently advertise DSN extension, so this feature won't be enabled automatically.

lmtp: Show more information in process title. Most importantly show the username while messages are being delivered.

lmtp: Added support for STARTTLS command.

lmtp: Put back the deduplication code. Too dangerous after all to change it in the middle of v2.2.x. It's also not causing that much trouble even when it breaks..

lmtp: Small code cleanup

lmtp: Removed code that attempts to deduplicate mail files by copying them between user mailboxes. This sometimes started failing if the mail that was being used for copying was deleted by the user. There's no good way for lmtp code to fix that situation. If deduplication is needed, it could be implemented in a more generic way inside mailbox_copy() where after initial copy it would store the destination struct mail to src_mail->last_copy_dest_mail. If another mail is copied, the last_copy_dest_mail could be attempted to be used for the copying and if that doesn't work it would fallback to regular copying. This should probably be attempted only for lda/lmtp processes as it would just cause extra overhead for others.

lmtp: Make it clear that the lda_settings is unexpanded in struct client.

lmtp: Log a bit nicer message when client QUITs. I did think about removing the connect and successful disconnect messages entirely, but these may be useful when debugging problems with MTA.

lmtp: If verbose_proctitle=yes, update the process state in the title.

Renamed network.[ch] to net.[ch]. The function prefixes already started with net_ instead of network_. And icecap wants to use network.h for other purpose. :)

lmtp proxy: Forward proxy_timeout to backend and set mail_max_lock_timeout based on it. This automatically avoids duplicate mail deliveries caused by long lock waits.

Array API changed: ARRAY_DEFINE(name, type) -> ARRAY(type) name Easy way to update your existing code: perl -i -pe 's:ARRAY_DEFINE\(([^,]+), *([^)]+)\);:ARRAY($2) $1;:' **/*.[ch]

Marked functions parameters that are allowed to be NULL. Some APIs were also changed. The non-obvious APIs where NULL parameter was changed to "" are master_service_init() and auth_master_user_list_init(). These checks can currently be enabled only on a patched clang: http://llvm.org/bugs/show_bug.cgi?id=6786

imap/pop3/lmtp proxy: Implemented detection of proxy loops with TTL. If proxying tries to continue after 5 forward connections, it fails. The limit of 5 is hard coded currently.

lmtp: Implemented Postfix-compatible XCLIENT extension for changing client's ip/port.

lmtp: Code cleanup.

lmtp: Log the current state in disconnect message.

lmtp: Don't forget LHLO host when sending multiple messages in session.

lmtp: Recent change broke accessing mail_temp_dir. Also when it happened, an error message wasn't always logged.

lmtp: Reverted accidentally committed debug code

Added mail_temp_dir setting, used by deliver and lmtp for creating temp mail files.

lmtp: BODY=* setting wasn't reset with RSET --HG-- branch : HEAD

lmtp: Add Return-Path: header. Also with only one RCPT TO, add Delivered-To: header. --HG-- branch : HEAD

Added recipient_delimiter setting that LMTP server now uses. --HG-- branch : HEAD

lmtp: Disable idle timeout while proxying. --HG-- branch : HEAD

lmtp: Add Received: header, with a session ID. Log the session ID also. --HG-- branch : HEAD

lib-storage: Changed APIs to fix reading settings for multiple users. --HG-- branch : HEAD

Merged single and multi mail_storage_service_*() functions. --HG-- branch : HEAD

lmtp: Added lmtp_proxy setting (it's no longer hardcoded to yes). --HG-- branch : HEAD

lmtp: Added initial support for proxying mails to other LMTP/SMTP servers. --HG-- branch : HEAD

lmtp: Use dot istream for reading DATA input. --HG-- branch : HEAD

Initial implementation of LMTP server. Master process doesn't yet execute it though. --HG-- branch : HEAD