lib-smtp: server: Only accept XCLIENT command when the XCLIENT capability is active. Report "502 Unsupported command" otherwise. Before, it would complain about the client not being trusted, which is confusing.

Updated copyright notices to include the year 2018.

lib-smtp: server: Moved ssl_start argument from smtp_server_connection_start() to smtp_server_connection_create(). This frees smtp_server_connection_start() for general use.

lmtp: Fix segfault occurring in client_read_settings(). This problem is caused by recent changes. The code attempts to access client->conn to obtain connection security info, which is not yet assigned at that point. It is doubtful whether assigning those security flags is useful at that stage, but it now uses the ssl flag from the master_service_connection instead.

lmtp: Removed useless ssl_start parameter for client_create(). The same information is already contained in the conn parameter.

lib-storage: mail-user: Added more information about the client connection. Submission service will need it to pass to the backend MTA in XCLIENT and for creating the "Received:" header.

lmtp: Changed message data handling to use iostream-temp. The existing code predates iostream-temp.

lmtp: Removed structural comments that are now useless.

lmtp: client: Made client_remote_id() static.

lmtp: Ported to use lib-smtp/server. Implicitly fixes handling of multi-line replies from proxy backend. Implicitly adds support for mixing local and proxy recipients. Implicitly adds support for SMTP CHUNKING. RCPT failures are reported back to the client immediately, rather than waiting for the DATA command.

lmtp: Split off local delivery in a struct separate from the client. This mimics proxy delivery, making the implementation better structured.

lmtp: client: Moved recipient deinitialization to lmtp-local.c.

lmtp: local: Renamed client_rcpt_anvil_disconnect() to lmtp_local_rcpt_anvil_disconnect().

lmtp: Renamed struct mail_recipient to struct lmtp_recipient.

lmtp: client: Moved soon-to-be-obsolete output handling functions to end of the file.

lmtp: client: Moved soon-to-be-obsolete input handling functions to end of the file.

lmtp: client: Moved client_state_reset().

lmtp: Moved client_rcpt_anvil_disconnect() from client.c to lmtp-local.c.

lmtp: client: Use client_remote_id() to construct proctitle.

lmtp: client: Moved client_remote_id().

lmtp: client: Restructured client_state_set() to match imap_refresh_proctitle().

lmtp: client: Restructured handling of verbose_proctitle setting.

global: use i_close_fd{,_path}() instead of open-coding them

global: start relying on buffer_free(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - buffer_free(&E); - } + buffer_free(&E);

global: start relying on [io]_stream_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_unref(&E); - } + i_stream_unref(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_unref(&E); - } + o_stream_unref(&E);

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

global: start relying on io_remove{,_closed}(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - io_remove(&E); - } + io_remove(&E); @@ expression E; @@ - if (E != NULL) { - io_remove_closed(&E); - } + io_remove_closed(&E);

global: Replace mail_storage_service_user_free() with _unref()

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

global: Use fd_close_maybe_stdio()

lib: API change - var_expand*() now returns error string. This allows callers to fail properly if the format string is invalid.

lmtp: Increase user's concurrency limit already after RCPT TO. This way it's not possible for a lot of mails to arrive to user concurrently and bypass the lmtp_user_concurrency_limit.

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Use io_stream_get_disconnect_reason() instead of duplicating its code all over the place.

lmtp, *-login: Use ip/port values from struct master_service_connection instead of from the socket. This way, a proxy protocol like HAProxy can transparently override these addresses with what is seen by the proxy.

lmtp: Added lmtp_user_concurrency_limit setting. This allows limiting the number of concurrent deliveries to a single user. Useful in case one user is receiving a lot of mails and causing other deliveries to be delayed. If the limit is reached, Dovecot returns temporary failure error at DATA stage.

lmtp: Changed rcpt_to array to contain pointers to struct mail_recipient This allow storing the pointers so they don't change.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lmtp: Show more information in process title. Most importantly show the username while messages are being delivered.

lmtp: Added support for STARTTLS command.

imap, pop3, lmtp: If client gets disconnected due to iostream error, log the full error.

lmtp: Reduce corking so we get command replies more quickly even if they are pipelined. This may help avoid some LMTP client timeouts.

Updated copyright notices to include year 2014.

lmtp: Make sure output is flushed before disconnection.

lmtp: Make it clear that the lda_settings is unexpanded in struct client.

net_ip2addr() changed to return "" instead of NULL on failure. Pretty much everything in the code assumed that it would never fail, which it normally doesn't except if the ip_addr was created for UNIX sockets.

lmtp: Log a bit nicer message when client QUITs. I did think about removing the connect and successful disconnect messages entirely, but these may be useful when debugging problems with MTA.

lmtp: If verbose_proctitle=yes, update the process state in the title.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.