lib/printf-format-fix: fix rejection of "%.0f" as a valid string Sometimes you want to calculate in floats, but don't want the decimals printed. Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include the year 2018.

lib: Use test_expect_fatal_string() for all fatal unit tests

lib: printf_format_fix*() - Support '*' in precision We're commonly using "%.*s"

lib: printf_format_fix*() - Use the same 4 digits as maximum precision length I forgot the precision can also be used to truncate strings, not just specify the precision for floating point numbers. So it makes more sense that the limit is the same as for minimum field width.

lib: printf_format_fix*() - Be over-strict in what format strings are allowed The checks could have been bypassed by some invalid format strings that were handled differently by the printf_format_fix*() code and libc. For example "%**%n" was passed through as ok, but glibc handled the %n in it. Found by cPanel Security Team.

Updated copyright notices to include the year 2017.

lib: Fix %n detection in printf_format_fix_noalloc() It's undefined how flags, precision or length modifiers are handled with %n, so make sure we catch all of them to detect an unwanted %n.

global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)"

lib-test: Change test_fatal_func_t to take unsigned int stage as parameter. It could never be -1, so this makes it clearer. It also removes annoying casts when comparing stage to e.g. N_ELEMENTS().

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib: Replaced two test_assert()s checking for NULLs with i_assert()s These can never happen anyway, and keeping them as test_assert()s cause static analyzer to give warnings.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: test fatal cases for printf_format_fix Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: test printf_format_fix() Signed-off-by: Phil Carmody <phil@dovecot.fi>