lib: Add file_lock_from_dotlock() The dotlock creation requires various settings, so the file-lock.h API can't easily be used to create it. But once created, it's simpler to keep all lock types in the same struct file_lock, which can be unlocked/freed once finished.

global: start relying on file_lock_free(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - file_lock_free(&E); - } + file_lock_free(&E);

Updated copyright notices to include the year 2018.

lib: Make file_lock_free(NULL) no-op

lib: file_lock_set_unlink_on_free() - Avoid unlink() if another process is waiting on the lock

lib: Add file_lock_set_close_on_free()

lib: Add file_lock_set_unlink_on_free()

lib: Add file_lock_set_path()

lib: Add file_lock_get_path() This allows getting the file path from the lock without having to preserve it separately.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib: With FILE_LOCK_SLOW_WARNING_MSECS log a warning also when keeping lock for long. This can help catching which process kept the lock for too long.

lib: Add FILE_LOCK_SLOW_WARNING_MSECS environment. Log a warning if any locking takes longer than the specified number of milliseconds. This can be enabled globally with: import_environment = $import_environment FILE_LOCK_SLOW_WARNING_MSECS=1000

Fix control flow and T_BEGIN/T_END hygiene You mustn't goto, break, continue, or return from out of a T_BEGIN {...} T_END block, as that will lose a t_pop(). This has been seen in the wild: Panic: Leaked t_pop() call Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: Track how much time has been spent on waiting for locks.

global: Require comparisons to be strict boolean expressions * No implicit integer -> boolean or pointer -> boolean conversions * !expr can be used only if expr is boolean type These were checked with a patched clang. It found various actual bugs, which were fixed by the previous commits.

global: Fixed mismatched bool vs. int/pointer handling I don't think these fix any actual bugs.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib: s/EDEADLOCK/EDEADLK/ It felt wrong since the beginning, but my first attempt at EDEADLCK didn't work and EDEADLOCK did. Of course, not everywhere.

lib: file_wait_lock*(): Improve the panic log message on EDEADLOCK.

lib: file_wait_lock_error() assert-crashes now on EDEADLOCK It's always a bug and a crash can help debug it.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: Compiler warning fix in 32bit systems to previous change

lib: file_wait/try_lock() treats EINTR differently now for timeouts and for actual signals.

lib: Added file_lock_find() to find which process has a file locked.

lib: If file_wait_lock*() fails, try to include the current pid holding the lock in error message. This is currently supported via fcntl(F_GETLK) and also via Linux /proc/locks.

lib: Added file_wait_lock_error() and file_try_lock_error()

lib: file_*_lock() with flock() timeouts should have returned errno=EAGAIN (Instead of EINTR.)

Updated copyright notices to include year 2014.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.