lib-storage: Add and use MAILBOX_LIST_PROP_NO_INTERNAL_NAMES Use it to replace Maildir++ check to see if mailbox_list.is_internal_name() is wanted to be used.

lib-storage: Add NO-FS-VALIDATION flag

lib-storage: Never prevent using '/' in mailbox names with mail_full_filesystem_access=yes It was already allowed with LAYOUT=fs, but not with e.g. LAYOUT=Maildir++. Now it's possible to use e.g. SELECT /home/shareduser/Maildir/test.box

lib-storage: Add mailbox_list_[un]lock()

Updated copyright notices to include the year 2018.

lib-storage: Make sure index root is created when it's the same as root directory This is required by the following commit.

lib-storage: Add a fall through comment to fix gcc-7 warning

lib-storage: Add INDEXCACHE=<path> to mail_location This allows configuring a different directory for dovecot.index.cache files than the rest of the index files.

lib-storage: Add setting to disable \NoSelect mailboxes Enabled using mail_location = ...:NO-NOSELECT Trying to create \NoSelect "dir/" will result just creating "dir", similar to how Maildir++ layout already did it. Deleting a mailbox will delete all of its \NoSelect parents.

lib-storage: If root dir already exists as file, log better error message.

lib-storage: Allow LISTINDEX to point to a different directory Most importantly because the mailbox list index is only a cache, it could be safely pointed to e.g. tmpfs to save disk I/O.

lib-storage: Add mailbox_list_last_error_push/pop() These are similar to mail_storage_last_error_push/pop()

lib-storage: mailbox_list_get_permissions() - Use index dir with ITERINDEX

lib-storage: mailbox_list_get_permissions() - Use index dir for storage without mails The index dir might still exist.

lib-storage: Cleanup - move code to mailbox_list_get_permissions_stat() Comments changed also a bit, but no functional changes.

lib-storage: Cleanup - Use mailbox_permissions_copy() instead of duplicating it

lib-storage: Add mailbox_permissions_copy()

lib-storage: Add mail_location=..:ITERINDEX This changes mailbox list iteration to work using INDEX directory instead of the normal mail directory. This can be helpful when the indexes are stored on a faster storage.

lib-storage: Add BROKENCHAR to mail_location This makes the mailbox_list_settings.broken_char configurable. Mainly useful with imapc when remote server doesn't contain valid mUTF-7 mailbox names.

lib-storage: Add mailbox_list_get_last_mail_error()

lib-storage: Add VOLATILEDIR setting to mail_location This is useful for creating temporary locks that could exist in tmpfs. Currently this is used for .vsize.lock and dovecot.autoexpunge.lock.

lib-storage: Add mailbox_list_get_last_internal_error() This returns the error given to mailbox_list_set_critical().

lib: Add error_r to t_readlink and its callers

lib: Rename abspath to path-util

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

global: Make sure *_malloc() calculations won't cause integer overflows.

global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)"

lib-storage: Make dovecot.list.index's filename configurable. This is useful when there are multiple namespaces pointing to the same mail root directory. For example mdbox with lazy-expunge: namespace { prefix = Expunged/ location = mdbox:~/mdbox:MAILBOXDIR=expunged:LISTINDEX=expunged.list.index .. }

lib-storage: Deduplicate code into mailbox_list_settings_init_defaults()

global: Use i_strchr_to_next() wherever useful.

lib-storage: clean up mailbox_list_create to improve readability There is no reason to use mailbox_list_driver_find() here instead of mailbox_list_find_class() as (1) we do not need the index into the list driver array, and (2) dealing with double-pointers is harder than regular pointers.

lib-storage: Limit folder full name only Before we had limit of 16 levels and 255 bytes per name which is same as 4096 bytes. Now we limit only the total length of the name to MAILBOX_LIST_NAME_MAX_LENGTH. For compability reasons, we are restricting individual component names to 255 characters.

global: Fixed mismatched bool vs. int/pointer handling I don't think these fix any actual bugs.

Remove t_malloc in favour of t_malloc_no0 Using either t_malloc_no0 or t_malloc0 makes it clear whether the allocated memory is zeroed or not.

lib-storage: Clear list error before mailbox_list_get_hierarchy_sep() With ACL plugin enabled the call could have triggered dovecot-acl-list rebuild, which in turn could have set list errors if it didn't have permissions to all the mailboxes. This caused IMAP logins to fail.

lib-storage: Added mailbox_list_[un]escape_name_params() This allows calling the mailbox_list_[un]escape_name() with wanted parameters instead of taking them from mailbox_list.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-storage: mailbox_list_[un]escape_name() can now be called globally

lib-storage: escape_char and broken_char settings weren't copied on mailbox_list_create()

lib-storage: After mailbox_list_init_fs() is finished, notify fs about it. Creating a separate fs_init_finish() would perhaps have been clearner, but it's a lot more work and usually isn't even necessary for most backends. So I simply chose to use fs_get_properties() which is a fast call in all fs backends and the few ones that actually care about the initialization finish can then do their work in there.

lib-storage: mailbox_list_fs_get_list() shouldn't crash if fs wasn't created by mailbox_list_init_fs()

lib-storage: Added mailbox_list_fs_get_list() Using mailbox_list_init_fs() now sets the mailbox_list pointer to root fs, which allows the fs backends to lookup the list. Although this can't be done in the init() function since the list is set only afterwards.

Removed mountpoint checking and updating code. After a few years it seems like it has just caused more problems than it has actually fixed. The only thing it's been used for is to make sure that Dovecot can't create empty user directories when the user's mail filesystem isn't mounted. But that's supposed to be normally prevented already if the mount root directory permissions are only writable by root. For now the mountpoint listing code and doveadm mount code still exists just in case people have some scripts using those. Those could be removed in v2.3. If we somehow figured out which mountpoints existed (not so easy because they could be only visible in userdb lookups for different users), we could maybe create some kind of a script that checks the permissions at startup. This would work with Linux at least: mkdir test mount / -o bind test ls -ld test/var/mail # assuming /var/mail mountpoint umount test

lib-storage: mailbox_list_mailbox() now copies the mailbox_exists() error. Instead of assuming it has to be an internal error.

lib-storage: Allow up to 255 chars in a single mailbox hierarchy name. This also reduces the max number of hierarchy levels, but 16 should still be enough for normal uses.

lib-storage: Added mail_user_init_fs_settings() Also changed mailbox_list_init_fs() to use it internally.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-storage: Don't allow '/' for filesystem based mailbox list backends if their internal separator isn't '/'. Basically this means that Maildir++ shouldn't be allowed to create mailboxes with '/' in the name.

lib-fs: Added fs_settings.username and .session_id

lib-storage: mailbox_settings_find() now takes namespace parameter instead of user. This fixes an infinite (until stack gets full) loop with shared mailboxes: mail_namespace_find() -> mailbox_list_get_storage() -> mailbox_settings_find() -> mail_namespace_find() -> ...

Updated copyright notices to include year 2014.

lib-storage: Non-crashing way of avoiding fs lookups for storages without mail root.

lib-storage: Don't do filesystem permission lookups if storage has no mailbox root dir.

lib-storage: Improved EACCES error messages for some stat() calls

lib-storage: Added mailbox_list_init_fs() to easily initialize fs. Use it for dbox's attachment_fs.

lib-storage: Added FULLDIRNAME=name to mail_location. The difference to DIRNAME is that the name is used also for index and control directories.

lib-storage: Fixed listescape when escape_char was the same as namespace separator.

lib-storage: Fixed crash with some autocreated (e.g. shared) namespaces.

lib-storage: Added mailbox { driver } setting to specify which storage to use.

Avoid using mail_namespace.storage directly.

lib-storage: Renamed mailbox_list_get_closest_storage() to ..._get_default_storage() This function wasn't previously used by anyone.

lib-storage: mailbox_list_settings.broken_char wasn't escaping 8bit chars correctly.

lib-storage: Empty mailbox name isn't valid.

lib-storage: If INDEX=MEMORY, return index root dir as nonexistent instead of as "".

lib-storage: Reverted previous change after all.

lib-storage: Don't try to mkdir() empty directory with INDEX=MEMORY

lib-storage: Make sure index root dir is created when mailbox list index is created.

lib-storage: dovecot.mailbox.log should have used file permissions, not dir Although this didn't actually make any difference since 0666 mask was used.

lib-storage: Compiling fix

lib-storage: Added mailbox_list_get_settings()

lib-storage: Write dovecot.mailbox.log entries using virtual names, not storage names. This file is used only by dsync, and the new dsync design uses only virtual names everywhere. This of course means that now it's not easily possible to use different virtual names for the same user, but nobody really did that before anyway. The only other fully working solution would be to send both the virtual and the storage names in dsync, but that's a bit of a waste.

Oops :) Update copyrights to 2013 without breaking all .c files.