lib-storage: Unless LAYOUT=index, don't rebuild list index on missing INBOX

lib-storage: mailbox_list_index_handle_corruption() - Lock mailbox list while rebuilding This guards against simultaneous mailbox create/delete/rename.

lib-storage: mailbox_list_index_handle_corruption() - Move actual handling to its own function

lib-storage: Add and use INDEX_LIST_CONTEXT_REQUIRE Satisfies static analyzers

Updated copyright notices to include the year 2018.

LAYOUT=index: Fix updating STATUS changes in mailbox list index Mailbox list index backend code was overriding sync_init and sync_deinit methods, which STATUS handling had already already overridden. They both used the same super struct, so STATUS's sync_* were never called.

lib-index: Add mail_index.event

lib-storage: Log an error when mailbox list index is rebuilt due to header fsck flag

LAYOUT=index: Rebuild list index if INBOX is missing on inbox=yes namespace This avoids having to manually rebuild the list index afterwards if it becomes lost.

lib-storage: Rename mail_storage.list_index_corrupted() to list_index_rebuild() Also add a new parameter to it to specify the rebuild reason.

lib-storage: Remove obsolete comment

lib-storage: mailbox-list-index - disable if MAILBOX_LIST_PROP_NO_LIST_INDEX set

lib-index: Replace mail_index_set_log_rotation() with mail_index_set_optimization_settings() This allows more easily adding optimization-related settings.

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

lib-storage: Support LISTINDEX= to disable it

lib-storage: Try to get mailbox list index's permissions from its parent directory This avoids stat()ing the mail/index root directory, which is especially useful when mailbox list index is stored in tmpfs.

lib-storage: Allow LISTINDEX to point to a different directory Most importantly because the mailbox list index is only a cache, it could be safely pointed to e.g. tmpfs to save disk I/O.

lib-storage: Ensure list index is present Otherwise we end up with signal 11 crash later on.

lib-storage: Avoid index refresh with mailbox_list_index_very_dirty_syncs=yes

lib-storage: Refresh mailbox list index if mailbox's existence differs from index

lib-storage: Set mailbox list index to be refreshed after changes, not before Mailbox deletion and rename set the refresh-flag before the change was done. This was unnecessary if the change didn't happen. Also there was a race condition that another process could have done the refresh before the change was even done.

lib-storage: Implement mailbox_list_notify_flush() This flushes any pending notifications. For now it only checks if there's a pending notification waiting for a timeout. It could also stat() the files to make sure, but that's probably unnecessary.

lib-storage: Fix mailbox list index records without guid having invalid flags With LAYOUT=index the mailbox is found with its GUID. If it doesn't exist, the mailbox has to be either \NonExistent or \NoSelect. It probably doesn't make much difference which one, so we'll fix them by adding \NoSelect. With other layouts the GUID is allowed to be empty, because it can be looked up from the actual mailbox.

lib-storage: Fix mailbox list index records with name_id=0 name_id=0 isn't valid, so it needs to be changed and writen to the disk. The write-to-disk part wasn't working.

lib-storage: Fix assert-crash on corrupted dovecot.list.index with name_id==0 Fixes: Panic: file hash.c: line 213 (hash_table_insert_node): assertion failed: (key != NULL)

lib-storage: Fix mailbox list index hook usage The previous method appeared to work, but not if the internal hooks were used more than once.

LAYOUT=index: Fix duplicate mailbox name renaming to actually work

LAYOUT=index: Rename mailbox_list_index_node.corrupted_parent to corrupted_ext The code will be useful for other purposes also besides updating corrupted parents.

Updated copyright notices to include the year 2017.

lib-storage: Make dovecot.list.index's filename configurable. This is useful when there are multiple namespaces pointing to the same mail root directory. For example mdbox with lazy-expunge: namespace { prefix = Expunged/ location = mdbox:~/mdbox:MAILBOXDIR=expunged:LISTINDEX=expunged.list.index .. }

lib-storage: Do not try to recover missing list index Fixes Panic: file mailbox-list-index.c: line 342 (mailbox_list_index_parse_records): assertion failed: (node != NULL)

lib-storage: Fix error handling in mailbox_list_index_refresh_force() Broken by recent changes.

lib-storge: Call mail_storage.list_index_corrupted() when needed The callback is called whenever mailbox list index appears to be corrupted with LAYOUT=index. The storage is responsible for adding to the index any mailboxes that are missing.

lib-storage: Rename mailbox_list_index.corrupted to corrupted_names_or_parents Makes it clearer what exactly the flag means.

lib-storage: Rotate dovecot.list.index.log* more often. The history in these files isn't as important as in mailbox indexes. Reduce disk space usage by rotating them more often and deleting the .log.2 more quickly.

LAYOUT=index: Don't write corrupted mailbox names to box-name header. This way when opening a mailbox the box-name header isn't overwritten by a corrupted name. Keep track of the corrupted names with MAILBOX_LIST_INDEX_FLAG_CORRUPTED_NAME flag in list index records. The flag isn't removed until the mailbox is renamed.

lib-storage: Prevent parent loops in mailbox list index

lib-storage: Fix invalid parents in LAYOUT=index Previously it just kept complaining without fixing the errors.

lib-storage: Improve mailbox list index corruption errors

lib-storage: If LAYOUT=index loses mailbox names, write the generated ones to index. Previously it just kept complaining and regenerating new names, without actually fixing up the situation.

lib-storage: Fix handling LAYOUT=index losing mailbox names It lost all the mailbox names.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

imapc: Don't crash with mailbox_list_index=yes

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-storage: Mailbox list index now detects duplicate mailbox names. With LAYOUT=index the duplicates are renamed.

lib-storage: Make sure mailbox names are valid UTF-8 with LAYOUT=index

lib-storage: Fixed some race condition crashes with LAYOUT=index

lib-storage: Fixed parsing corrupted mailbox list index header. Duplicate IDs should have caused an error instead of being silently ignored. Found by Coverity

lib-storage: Avoid refreshing mailbox list index too often.

lib-storage: Mailbox list indexes didn't use mail_fsync setting.

lib-storage: Fixed assert-crash in mailbox rename with layout=index

Updated copyright notices to include year 2014.

mailbox_list_index: Fixed assert-crash sometimes when deleting a mailbox.

layout=index: Allow mailbox create/delete/rename during mailbox list iteration.

lib-storage: Fixed crash with mailbox_list_index=yes after re-reading index.

lib-storage: mailbox_list_index=yes was broken by previous change. Reverted the previous change and fixed it the right way.

lib-storage: mailbox_list_index=yes wasn't working with ACLs.

lib-storage: Fixed mailbox list index crashes with shared mailboxes.

lib-storage: Make sure index root dir is created when mailbox list index is created.

lib-storage: mailbox list index didn't get its permissions from the root dir.

Replaced all -1U and (unsigned int)-1 with UINT_MAX. It's somewhat clearer this way. Also clang's -fsanitize=integer gives runtime errors about -1U (but not about explicit casts, so no need to change (type)-1 casts).

mailbox_list_index=yes: Don't crash if destroying list before its init finished.

lib-storage: Fixed crash with mailbox_list_index=no

mailbox_list_index: Delay allocating the index so mbox can override the index path.

lib-storage: Fixed mailbox_update() when using mailbox_list_index=yes

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.