lib-storage: Add and use INDEX_LIST_CONTEXT_REQUIRE Satisfies static analyzers

Updated copyright notices to include the year 2018.

lib-storage: mailbox_list_index - Don't overwrite INBOX's flags with prefix/INBOX's This made the real INBOX appear as if it was \NoSelect

lib-storage: mailbox_list_index - indentation cleanup

global: Use t_buffer_create sed -i -e 's/buffer_create_dynamic(pool_datastack_create(), */t_buffer_create(/g'

lib-storage: If mailbox_list_index_very_dirty_syncs=yes, still rebuild empty list index

lib-storage: Avoid index refresh with mailbox_list_index_very_dirty_syncs=yes

lib-storage: Fix mailbox list index records without guid having invalid flags With LAYOUT=index the mailbox is found with its GUID. If it doesn't exist, the mailbox has to be either \NonExistent or \NoSelect. It probably doesn't make much difference which one, so we'll fix them by adding \NoSelect. With other layouts the GUID is allowed to be empty, because it can be looked up from the actual mailbox.

LAYOUT=index: Rename mailbox_list_index_node.corrupted_parent to corrupted_ext The code will be useful for other purposes also besides updating corrupted parents.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-storge: Call mail_storage.list_index_corrupted() when needed The callback is called whenever mailbox list index appears to be corrupted with LAYOUT=index. The storage is responsible for adding to the index any mailboxes that are missing.

lib-storage: Rename mailbox_list_index.corrupted to corrupted_names_or_parents Makes it clearer what exactly the flag means.

lib-storage: Fix rotation of dovecot.list.index.log After b9da8540e665138b3cad0b637c08c0ab7d7a7eeb the tail offsets weren't being updated anymore when mail_index_sync_next() wasn't used to skip over all the data. Mailbox list index wasn't doing this, and so the log was never rotated since tail_offset was never equal to head_offset.

lib-storage: Fix compiler warnings about enum mismatches

LAYOUT=index: Don't write corrupted mailbox names to box-name header. This way when opening a mailbox the box-name header isn't overwritten by a corrupted name. Keep track of the corrupted names with MAILBOX_LIST_INDEX_FLAG_CORRUPTED_NAME flag in list index records. The flag isn't removed until the mailbox is renamed.

lib-storage: Fix invalid parents in LAYOUT=index Previously it just kept complaining without fixing the errors.

lib-storage: If LAYOUT=index loses mailbox names, write the generated ones to index. Previously it just kept complaining and regenerating new names, without actually fixing up the situation.

lib: move sort and search from strfuncs.h to sort.h

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib: extract sort-helpers into separate sort.h file The macro definition was nothing to do with strings, and we can put trivial common-type comparators here. They didn't need to be static inline, as they can never be inlined anyway, being only used via function pointers, but that preserves the closest equivalent to the current code. Signed-off-by: Phil Carmody <phil@dovecot.fi>

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-storage: Partially reverted previous change. Added mailbox_list_index_sync_delete() instead.

lib-storage: Added mailbox_list_index_delete_entry()

Added various asserts to try to silence Coverity false positives.

lib-storage: Fixed assert-crash in mailbox rename with layout=index

Updated copyright notices to include year 2014.

LAYOUT=index: Fixed race condition during mailbox creation.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.