lib-storage: Replace mail_transaction_commit_changes.changed with changes_mask This allows better finding out what changed in the transaction.

lib-storage: Add and use INDEX_LIST_CONTEXT_REQUIRE Satisfies static analyzers

Updated copyright notices to include the year 2018.

LAYOUT=index: Fix updating STATUS changes in mailbox list index Mailbox list index backend code was overriding sync_init and sync_deinit methods, which STATUS handling had already already overridden. They both used the same super struct, so STATUS's sync_* were never called.

global: Fix spelling mistakes in comments Original work by @andreasschulze and @jsoref

lib-storage: Add reason to mailbox_transaction_begin() Remove mailbox_transaction_set_reason().

lib-storage: Fix updating mailbox GUID in mailbox list index when it's empty Normally the GUID shouldn't be empty at this point. Updating mailbox GUID is also very rare. So this was unlikely to cause any problems in practise.

lib-storage: Add mailbox_list_index_include_inbox setting This controls whether to update INBOX's STATUS information in the mailbox list index. It can be useful especially if LISTINDEX points to a tmpfs, but perhaps also in other situations. I considered adding a more generic setting to exclude other mailboxes, but the namespace prefixes and hierarchy separators get a bit complicated with shared mailboxes. It's probably also not very useful to change this for anything but the INBOX.

lib-storage: Don't update INBOX's sync status to mailbox list index It's not actually used so there's no need to update it either. Broken by 70092709cdc803c87b8f4ef1b0548eb45515bdae

lib-storage: Fix mailbox_update() to always update mailbox list index. It previously was updating it only if the list index for the mailbox was already fully up-to-date. But that doesn't really matter, because mailbox_update() is supposed to be changing the values regardless. This fixes mailbox_update() to always work with LAYOUT=index. It also fixes mailbox_update() for INBOX to update UIDVALIDITY/GUID.

lib-storage: Don't use mailbox list index if it has refresh_flag set For example if INBOX is deleted, looking up its GUID shouldn't be returned from the list index since it contains the old GUID.

lib-storage: Track INBOX UIDVALIDITY and GUID in mailbox list index This allows existence checks and GUID lookups for INBOX to be done from the index.

lib-storage: Try to avoid opening mailbox list index on mailbox access Perform the STATUS (and other relevant) updates only if syncing or transaction commits changed anything. This could be optimized further to check even more strongly whether the seen changes could cause changes to the list index, but it's probably not worth the effort.

lib-storage: Always update highestmodseq in mailbox list index This is required for mailbox-list-notify API to work correctly. For example IMAP NOTIFY session with CONDSTORE enabled could be listening for FlagChanges, but another session without CONDSTORE enabled could be updating flags in a mailbox that has never been opened with CONDSTORE enabled. NOTIFY wouldn't see this change, unless it was always written to dovecot.list.index.

lib-storage: Fix mailbox list index hook usage The previous method appeared to work, but not if the internal hooks were used more than once.

lib-storage: Fix mailbox's vsize header check for mailboxes not in dovecot.list.index If mailbox wasn't yet in the dovecot.list.index, mailbox_list_index_status() for it returns FALSE and doesn't initialize the status. In some situations this may have caused a non-empty mailbox's vsize to be returned as 0.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-storage: Return vsize=0 from mailbox list index for empty mailboxes. If it's known that the mailbox has no mails, there's no reason to open the mailbox to see that its size is 0.

lib-storage: Fix rotation of dovecot.list.index.log After b9da8540e665138b3cad0b637c08c0ab7d7a7eeb the tail offsets weren't being updated anymore when mail_index_sync_next() wasn't used to skip over all the data. Mailbox list index wasn't doing this, and so the log was never rotated since tail_offset was never equal to head_offset.

LAYOUT=index: Existence or GUID lookups don't need to refresh mailboxes.

lib-storage: Added quick parameter to list_index_has_changed()

global: Use only explicit int -> bool conversions These were checked with a patched clang.

lib-storage: Fixed looking up MAILBOX_METADATA_FIRST_SAVE_DATE from mailbox list index. If the mailbox was cached as empty, we didn't check if it had since received new messages. This caused the first-save-date to be returned as nonexistent, which caused autoexpunging to not always work.

lib-storage: Fixed updating first-saved-uid to mailbox list index when first mails were just expunged.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Compiler warning fix for 32bit systems

lib-storage: Don't add first_saved to mailbox list index unless autoexpunge is set.

Added mailbox { autoexpunge } setting. This can be used to automatically expunge mails from specified mailboxes after they're old enough. The expunges are done when the user is being deinitialized. mailbox_list_index=yes should be enabled to have the best performance with this setting. Example: namespace inbox { mailbox Spam { auto = create special_use = \Junk autoexpunge = 30d } }

Make static analyzer happier.

lib-storage: If mailboxes' vsizes are used, keep them updated also in mailbox list index. This allows looking them up quickly without opening the actual mailbox indexes.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-storage: Don't update mailbox list index status fields when deleting a mailbox.

mailbox_list_index=yes: Make sure storage error doesn't change when updating STATUS info.

mailbox_list_index=yes: Don't update INBOX's STATUS information to index. This should reduce disk I/O

lib-storage: Mailbox list index updating didn't check properly if modseq tracking is enabled. mail_index_modseq_enable() can be enabled (e.g. by virtual plugin) without enabling MAILBOX_FEATURE_CONDSTORE. (Actually the MAILBOX_FEATURE_* probably should be removed from lib-storage entirely. They're too much of an IMAP feature.)

lib-storage: Optimize mailbox_exists() with mailbox_list_index=yes We can return the existence from the index itself to avoid stat()s.

lib-storage: Avoid rebuilding the whole mailbox list index when one mailbox changes.

Updated copyright notices to include year 2014.

lib-storage: Fixed crash with mailbox_list_index=yes and out-of-date index.

mailbox_list_index: Delay allocating the index so mbox can override the index path.

mailbox_list_index: Removed race conditions from index updates.

lib-storage: Fixed mailbox_update() when using mailbox_list_index=yes

lib-storage: Don't unnecessarily clear mailbox_status multiple times.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.