LAYOUT=index: Don't mkdir index root directory at init It's not really needed, since anything that needs it will automatically mkdir it later as well. This also breaks using LAYOUT=index with mbox, because the mbox code hasn't yet had a chance to override the index root path so it was mkdired without the .imap/ suffix.

LAYOUT=index: Don't prevent using internal mailbox names For example with Maildir it wasn't possible to create mailboxes named "new", "cur" or "tmp".

lib-storage: Add and use INDEX_LIST_CONTEXT_REQUIRE Satisfies static analyzers

Updated copyright notices to include the year 2018.

LAYOUT=index: Fix crash in doveadm force-resync if storage doesn't implement list_index_rebuild() Broken by recent changes.

LAYOUT=index: Fix updating STATUS changes in mailbox list index Mailbox list index backend code was overriding sync_init and sync_deinit methods, which STATUS handling had already already overridden. They both used the same super struct, so STATUS's sync_* were never called.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

lib-storage: Rebuild list index when doing doveadm force-resync

lib-storage: Fix MAILBOX_LIST_INDEX_HIERARHCY_SEP spelling Original work by @jsoref

global: Fix spelling mistakes in comments Original work by @andreasschulze and @jsoref

global: remove unnecessary ENOENT checks from unlink_directory() calls

lib-storage: Allow LISTINDEX to point to a different directory Most importantly because the mailbox list index is only a cache, it could be safely pointed to e.g. tmpfs to save disk I/O.

lib-storage: Add UIDVALIDITY to mailbox list index on mailbox create This avoids an unnecessary secondary write later on when opening the mailbox.

lib-storage: Explicitly name function pointers in mailbox lists This allows adding more fields to struct mailbox_list_vfuncs without compiler warnings.

global: Log mailbox_list internal errors

lib-storage: Fix mailbox list index hook usage The previous method appeared to work, but not if the internal hooks were used more than once.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)"

lib-storage: Fix crash in obox's dsync-merge

lib-storage: Try harder to rename a corrupted mailbox name to its old name. If the old name exists, use it as a prefix for the new name. This is especially useful when restoring autocreated mailboxes. A new mailbox could have already been autocreated, but it's still useful to have the broken one renamed with the same prefix, so it'll be clear that these mailboxes should be merged.

lib-storage: Fix compiler warnings about enum mismatches

LAYOUT=index: Try to rename corrupted mailbox name during mailbox open.

lib-storage: Added struct mailbox.corrupted_mailbox_name This allows backends that are adding lost mailboxes to mailbox list index to indicate that they don't actually know the name of the mailbox, and the mailbox list index should try to figure it out and rename the mailbox to its proper name.

LAYOUT=index: Don't write corrupted mailbox names to box-name header. This way when opening a mailbox the box-name header isn't overwritten by a corrupted name. Keep track of the corrupted names with MAILBOX_LIST_INDEX_FLAG_CORRUPTED_NAME flag in list index records. The flag isn't removed until the mailbox is renamed.

LAYOUT=index: Update mailbox name to mailbox index's header when opening. This way if the mailbox list index gets lost, a recent mailbox name is still available.

lib-storage: Prevent renaming mailbox under itself. This resulted earlier in a loop, which broke the mailbox index. Note that IMAP already prevented this, so it could only be triggered by other tools, like doveadm.

lib: Changed unlink_directory() API to return error string. There are many different reasons why it could fail, which a simple errno can't very clearly indicate.

LAYOUT=index: Make sure error is preserved if created mailbox can't be added to list index. mailbox_delete() could overwrite the error.

lib-storage: Added MAIL_STORAGE_CLASS_FLAG_NO_LIST_DELETES and MAILBOX_LIST_FLAG_NO_DELETES

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

LAYOUT=index: Fixed error handling in mailbox creation race condition. If two processes create the same mailbox, the other one ends up being deleted on failure. However, if the deletion itself also failed the state becomes a big ambiguous. We don't want to return MAIL_ERROR_EXISTS in that case, because the caller may try to open the mailbox with the inconsistent state and fail. So we'll instead return the original mailbox_delete() error to the caller.

lib-storage: If mailboxes' vsizes are used, keep them updated also in mailbox list index. This allows looking them up quickly without opening the actual mailbox indexes.

LAYOUT=index: Reversed d977a746819d - use storage's list_index_*() callbacks after all. Just because we have all the mailbox information in the mailbox list index doesn't mean that we necessarily trust the folder mail counts and such to be correct. Setting mailbox_list_index_very_dirty_syncs=yes pretty much reverts to the earlier behavior.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-storage: Recent change broke deleting mailboxes with LAYOUT=index

lib-storage: LAYOUT=index now first creates the backend mailbox and only then adds it to list index. This avoids any race conditions with mailbox creation and opening it.

lib-storage: LAYOUT=index no longer keeps list index locked while creating mailbox. Mailbox opening can be slow and complicated and could even try to lock the list index again. So it's a bit more racy now, but all mailbox formats can already handle races with mailbox creation.

lib-storage: Partially reverted previous change. Added mailbox_list_index_sync_delete() instead.

lib-storage: Added mailbox_list_index_delete_entry()

lib-storage: LAYOUT=index doesn't reserve '~' as internal separator anymore. The index doesn't reserve any character as hierarchy separator, so the internal separator can change at any time. Use the namespace's configured hierarchy separator as the internal separator to avoid reserving any characters. If namespace separator isn't configured, fallback to the original '~' so this change shouldn't break anything.

lib-storage: LAYOUT=index small code cleanup

lib-storage: Fixed earlier LAYOUT=index change to refresh index before opening a view to it. Fixes an assert-crash.

lib-storage: Fixed some race condition crashes with LAYOUT=index

lib-storage: Removed unnecessary code. mailbox_dir_name is never NULL, and when it's empty it can be handled exactly the same as when it's non-empty.

Updated copyright notices to include year 2014.

lib-storage: Error handling fix for layout=index when mailbox creation fails.

LAYOUT=index: Fixed race condition during mailbox creation.

lib-storage: Don't crash if backend doesn't have subscriptions file.

layout=index: Fixed listing subscriptions.

layout=index: Don't crash on mailbox_update() if the mailbox path couldn't be found.

layout=index: Fixed mailbox_exists()

layout=index: Don't return a path for \Noselect mailboxes.

LAYOUT=index: Index is the only source for mailbox info, don't try any syncing with storage.

lib-storage: Fixed mailbox_update() when using mailbox_list_index=yes

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.