Updated copyright notices to include the year 2018.

lib-storage: Add INDEXCACHE=<path> to mail_location This allows configuring a different directory for dovecot.index.cache files than the rest of the index files.

global: remove unnecessary ENOENT checks from unlink_directory() calls

global: Replace random_fill_weak with random_fill They are now the same thing

lib-storage: Hide and rmdir \NoSelect leaf mailboxes with NO-NOSELECT If the leaf is successfully rmdir()ed, rmdir() also its parents. This doesn't work perfectly with if there are multiple levels of \NoSelect mailboxes. For example with "a/b/c" the listing will already have returned "a" and "a/b" before it reaches the "a/b/c" code, which will rmdir all of them, but it's a bit too late at that point. It's too much work to fix though, and the situation will be fixed on the next list anyway.

lib-storage: Add setting to disable \NoSelect mailboxes Enabled using mail_location = ...:NO-NOSELECT Trying to create \NoSelect "dir/" will result just creating "dir", similar to how Maildir++ layout already did it. Deleting a mailbox will delete all of its \NoSelect parents.

lib-storage: Mailbox rename shouldn't auto-rmdir parent index dirs with ITERINDEX For example: - create a/b - rename a/b c This resulted in "a" existing in mail root directory, but not in index directory. With ITERINDEX this meant that the "a" was lost.

lib-storage: When index dir rmdir() fails with ENOTEMPTY, retry it for 1 second This helps to avoid leaving those index directories lying around with NFS. Hopefully within the 1 second any existing processes that have been keeping those files open have finished their task. Especially IMAP IDLE will take 0.5 seconds to start syncing indexes and realize that they're deleted.

lib-storage: Fix ITERINDEX to leave \NoSelect parents after deleting child mailbox For example if "a/b" was created and deleted, "a" should be left behind. (Or at least it shouldn't have left "a" to mail root directory and kept it invisible since it didn't exist in index dir.)

lib-storage: Fix mailbox delete to not delete childrens' INDEX or CONTROL dirs If mail_location had separate INDEX and/or CONTROL set, deleting a mailbox with children caused the childrens' index and/or control directories to be deleted (but the mail/ALT directories weren't). I'm not sure why the _FLAG_MAILBOX_FILES was treated as a special case earlier. It shouldn't make a difference.

lib-storage: mailbox_list_delete_mailbox_nonrecursive() - Fix error handling It should return error on unexpected readdir(), closedir() and unlink() failures. Also fix handling a race condition with another process deleting the mailbox at the same time.

lib-storage: mailbox_list_delete_trash() - Don't ignore errors

lib-storage: Add mailbox_list_delete_finish_ret() This simplifies deletion logic for mailbox list backends.

lib-storage: mailbox_list_delete_finish() - Return whether anything was deleted

Updated copyright notices to include the year 2017.

global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)"

lib: Changed unlink_directory() API to return error string. There are many different reasons why it could fail, which a simple errno can't very clearly indicate.

lib-storage: Minor error message fix

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Added UNLINK_EISDIR() helper macro.

Updated copyright notices to include year 2014.

"Mailbox doesn't exist" error mixed up using storage and virtual mailbox names. This could have allowed a user to figure out existence of a mailbox without having lookup ACL.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.

unlink_directory(): Added UNLINK_DIRECTORY_FLAG_SKIP_DOTFILES flag.

lib-storage: Added initial implementation for layout=index. The idea is that all of the mailbox names only exist in the mailbox list index. Storage directories use mailbox GUIDs. This avoids all kinds of race conditions with mailbox renames. mailbox_list_index=yes is required for this layout to work. There are probably still some race conditions within the indexing code itself. Also error recovery is missing.

lib-storage: mailbox_get_path() and friends can now return an error. An upcoming "index" mailbox_list backend uses mailbox GUIDs as the directory names. Doing a name => GUID lookup may fail, so the path lookup may fail. This is a somewhat annoying change and perhaps it can be removed in future, but for now it looks like it can't be avoided.

lib-storage: Fixed attempting to delete a non-symlink with Solaris Also fixed error message to say it's about unlink(), not stat().

Marked functions parameters that are allowed to be NULL. Some APIs were also changed. The non-obvious APIs where NULL parameter was changed to "" are master_service_init() and auth_master_user_list_init(). These checks can currently be enabled only on a patched clang: http://llvm.org/bugs/show_bug.cgi?id=6786