lib-storage: Replace mail_transaction_commit_changes.changed with changes_mask This allows better finding out what changed in the transaction.

lib-storage: Remove mailbox_transaction_context.nontransactional_changes Nothing cares about them. It was only set for POP3 UIDL change with Maildir. In theory dsync replication would want to replicate such a change, but it doesn't actually support changing UIDLs for existing mails. Other mailbox formats don't support it anyway.

lib-storage: Set mailbox_transaction_context.flags earlier Set it in index_transaction_init() so plugins' transaction_begin() methods see it after calling super.transaction_begin().

lib-storage: Add and use MAIL_STORAGE_CONTEXT_REQUIRE Satisfies static analyzers

Updated copyright notices to include the year 2018.

lib-storage: Set index error on transaction commit() callback The commit callback is setting errors to storage. However, it's being called from mail_index_transaction_commit() whose callers are expecting the error to be in index. If that index error was attempted to be used, it could have been wrong or NULL. Fix this by setting the same storage error also to the index.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

lib-storage: Add reason to mailbox.transaction_begin()

lib-storage: Add mailbox_transaction_set_reason()

lib-storage: Fix potential dict transaction leak on transaction rollback.

lib-storage: Always create mail_save_context.dest_mail This allows removing similar mail_alloc() from storage backends and plugins that need it. As a side effect, this changes mbox code to always assign UIDs to saved mails. This shouldn't be much of a problem, since it happened practically always already.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

dbox: Optimize POP3 MAIL_FETCH_UIDL_BACKEND. We keep track of the highest UID known to have POP3 UIDL in index's header. If saving adds a newer message, it'll also update the header. When fetching UIDL_BACKEND, we can need to check only mails with lower UIDs. There are some race conditions here, but normally UIDLs are set only once during migration so it shouldn't matter.

lib-dict: dict_transaction_commit*() returns now error string

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.

lib-storage: Changed mailbox_attribute_get/set() APIs to have a transaction and update index. The _get() doesn't currently actually use the transaction. It was mainly put there for future use where it could be useful. It's also possible that _iter() will need a transaction also. For now these decisions seem good enough.

lib-storage: Saving/copying no longer discards private message flags.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.