Updated copyright notices to include the year 2018.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

lib-storage: Fix sorting mails with the same primary sort key The sorting order may have been wrong when there was a combination of: * Messages were sorted by a string (e.g. Subject) * Some messages had the same sort key (e.g. same base subject) * Within the messages with the same sort key, some of the messages already had the "sort-*" index number in Dovecot indexes, but some of them didn't. The result was that Dovecot found that the two messages had exactly the same sort key. It should have continued with the secondary sort key (e.g. message sequence number), but it didn't.

lib-storage: Fix sort index writing to not leave sort_id=0 gaps This fixes errors like: Error: INBOX: Broken sort-f indexes, resetting

lib-storage: Add details to "Broken sort-* indexes" error

lib-storage: Fix assert-crash in SORT caused by earlier changes Broken by 0a6a527f0c42b5478d80ac53ab357885676fd516 Fixes: Panic: file index-sort-string.c: line 668 (index_sort_add_ids_range): assertion failed: (str != NULL)

lib-storage: Optimize error handling for SORT If a lot of mails have failed in a large mailbox, this check reduces the CPU usage significantly.

lib-storage: Sort code cleanup - Change index_sort_get_string() to return bool None of the callers cared about the difference between "expunged" vs "error".

lib-storage: Sort code cleanup - pass node to index_sort_get_string()

lib-storage: Add mail_sort_max_read_count setting. This controls how many slow mail accesses sorting can perform before it fails: a NO [LIMIT] Requested sort would have taken too long The SORT reply is still returned, but it's likely not correct.

lib-storage: Fix error handling when sorting mails. All errors were treated the same as if message had been expunged. This caused potentially wrong results to be sent to the client without any indication that they're wrong.

spelling fixes

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

global: uint32_t:1 -> bool:1 They were uint32_t because I wanted to be sure that there wouldn't be any padding added to the struct. But this should be true also with bool:1.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Remove now-unnecessary direct stdlib.h #includes.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.

Added asserts to binary searches to make sure we don't go to infinite loop. Using idx=left+(right-left)/2 would have worked also to allow 4GB sizes, but since none of the places in the code are likely to reach 2GB we might as well just add an assert. (Also if they do reach 2GB, it could be possible that they could reach also above 4GB and cause problems. Better to see an early error.)

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.