imapc: Fix assert-crash after detecting that multiple expunged mail reappear The first imapc_mailbox_set_corrupted() call started a reconnect. The second call crashed with: Panic: file imapc-client.c: line 414 (imapc_client_mailbox_reconnect): assertion failed: (!box->reconnecting)

imapc: Fix deleting mailbox Broken by f8f30bd27e41e1041a8de0b97f35d7d75e0a412e

imapc: Fix sending initial FETCH after reconnection SELECTs mailbox Move sending the FETCH when the SELECT returns tagged OK reply instead of delaying it until mailbox is next synced. Most importantly this allows sending the FETCH before any retried commands that are also sent after SELECT receives tagged reply.

imapc: Move imapc_mailbox_fetch_state*() to imapc-mailbox.c Mainly to make the next commit smaller.

imapc: Handle untagged UIDVALIDITY immediately This is part of the changes to fix mailbox resyncing after reconnect.

imapc: Fix leaking mail_index_view on delayed expunge handling Fixes: Panic: Leaked view for index (in-memory index): Opened in imapc-mailbox.c:47

Updated copyright notices to include the year 2018.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

lib-storage: convert imapc to use container_of

lib-storage: Storage backend sync_init()s no longer need to check if mailbox is open The previous change guarantees it.

imapc: Don't send UID FETCH 1:* after SELECT if mailbox is empty

imapc: Fix potential crash if initial sync fails. Happened at least if mailbox had 0 mails and a failing mailbox_sync() was called twice. Fixes: Panic: file imapc-sync.c: line 477 (imapc_sync_index): assertion failed: (mbox->sync_fetch_first_uid == 1)

imapc: Avoid resending duplicate FETCH when reconnecting during the initial sync

imapc: Try to merge STOREs together as much as possible when syncing

imapc: Don't send NOOP on sync if MAILBOX_SYNC_FLAG_FAST is set Fast syncing should do only the minimal amount of work.

imapc: include imapc-client.h in imapc-storage.h It was already required to be able to successfully include imapc-storage.h.

imapc: Add imapc_mailbox.capabilities Use it instead of imapc_client_get_capabilities(). Simplifies the following patch.

imapc: Rename imapc_storage_has_modseqs() to imapc_mailbox_has_modseqs() Simplifies the following patch.

Updated copyright notices to include the year 2017.

imapc: Don't send NOOP immediately after SELECT NOOP is normally used by mailbox syncing to check if there are any changes done by other concurrent IMAP sessions. But doing it immediately after SELECT is unnecessary, because nothing could have changed.

imapc: Fix assert that checks if mail is expunged locally. The EXPUNGE may have been sent while imapc_sync_index() was issuing remote imapc commands. It would end up being in delayed_expunged_uids, so the assert needs to check that too. Fixes: Panic: file imapc-sync.c: line 290 (imapc_initial_sync_check): assertion failed: (mail_index_is_expunged(view, lseq))

imapc: Added support for imapc_features=modseq If the remote server supports CONDSTORE or QRESYNC extensions we'll use the remote's MODSEQ and HIGHESTMODSEQ counts. There are some situations where the HIGHESTMODSEQ isn't updated exactly correctly on an open mailbox, so this feature shouldn't be fully relied on. It was primarily implemented for dsync+imapc support - both for preserving modseqs and also for HIGHESTMODSEQ lookups.

imapc: Don't mark the initial sync done if it wasn't successful.

imapc: Don't ignore FETCH, SEARCH and EXPUNGE returning NO failures in syncing. Especially if the FETCH 1:* (FLAGS) didn't succeed, we expunged all the mails from local index.

imapc: Fixed assert-crash in mailbox syncing, if mailbox couldn't be opened. Usually meaning that syncing was attempted when IMAP server couldn't be connected to. Fixes the assert: Panic: file imapc-client.c: line 439 (imapc_client_get_capabilities): assertion failed: (conn != NULL)

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

imapc: Don't assert-crash when trying to sync a mailbox with MAILBOX_FLAG_SAVEONLY. We can just skip the sync, because we don't do anything except save mails.

imapc: If imapc_features has gmail-migration, fetch X-GM-MSGID at startup and cache it. This works only if index files haven't been disabled.

imapc: Merged gmail-pop3 and gmail-labels-keyword features into a single gmail-migration feature There's really no other reason to use them except for migration.

imapc: With gmail-labels-keyword feature add the $GMailHaveLabels only to \All mailbox This is primarily intended for migration, and with this behavior dsync can be run just once so it's faster.

imapc: Implemented imapc_features=gmail-pop3 that also migrates pop3_deleted_flag. This also caused gmail-pop3-uidl feature to be renamed to simply gmail-pop3, which includes both the features.

imapc: Added imapc_features=gmail-labels-keyword This is a bit kludgy feature mainly intended for migrations from GMail. Unfortunately I couldn't figure out any nicer way to do this for now. GMail's "All Mail" folder contains all messages in all folders, but it also contains some messages that don't exist in other folders. For migrations we want to copy only those messages that don't exist elsewhere. This can now be achieved with something like: doveadm -o imapc_features='gmail-labels-keyword ...' \ backup -F '-$GmailHaveLabels' mdbox:~/mdbox Note that dsync can't handle inserting mails into folders, so if doveadm backup is already run once and one of the existing mails loses all labels, doveadm backup will delete the whole folder and start again.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

imapc: Cache LIST replies for a while to be able to immediately ask for mailbox flags/existence. Besides giving better performance, this will fix bugs in some servers where LISTing a single mailbox doesn't necessarily return it. (In this case a mailbox named "in" wasn't returned, but I think Dovecot has had bugs related to this also.)

Updated copyright notices to include year 2014.

imapc: Merge identical FETCH commands together (only updating UID range)

imapc: Avoid sending unnecessary IDLEs that are immediately aborted.

imapc: Reorganize code so that imapc_list works without imapc_storage. Most importantly fixes crashes when imapc_list is trying to lookup hierarchy separator before storage is created.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.

lib-storage: Renamed mail_storage_set_index_error() to mailbox_set_index_error()

lib-index: Removed MAIL_INDEX_SYNC_TYPE_APPEND. No backend cares about it.

Don't write "keyword reset" records to transaction log anymore. These are a bit problematic for dsync's keyword merging to handle.