imapc: Fix crash when untagged FETCH reply doesn't have key-value pairs The last key with the missing value is just silently ignored.

imapc: Fix sending initial FETCH after reconnection SELECTs mailbox Move sending the FETCH when the SELECT returns tagged OK reply instead of delaying it until mailbox is next synced. Most importantly this allows sending the FETCH before any retried commands that are also sent after SELECT receives tagged reply.

imapc: gmail-migration: Fetch X-GM-MSGID for new mails as well I'm not sure why it was originally restricted only for the initial FETCH. Fetching GUIDs for new mails can be just as useful.

imapc: Move imapc_mailbox_fetch_state*() to imapc-mailbox.c Mainly to make the next commit smaller.

imapc: Handle untagged UIDVALIDITY immediately This is part of the changes to fix mailbox resyncing after reconnect.

imapc: If mailbox select fails, rollback any changes done to it Required by the following changes that start adding changes immediately after SELECT. If the initial syncing doesn't finish successfully, these changes need to be reverted.

imapc: Fix leaking mail_index_view on delayed expunge handling Fixes: Panic: Leaked view for index (in-memory index): Opened in imapc-mailbox.c:47

imapc: Fix imap_features=no-msn-updates to not fail on SELECT The initial EXISTS reply shouldn't be ignored, only the following ones.

Updated copyright notices to include the year 2018.

imapc: Add imapc_features=no-msn-updates This is a stricter version of fetch-msn-workarounds. The MSNs aren't trusted at all. This means any new untagged EXISTS and EXPUNGE replies are ignored, as well as untagged FETCH replies that don't include UID. A potential downside with this feature is that UID FETCH/STORE commands sent to expunged messages will likely fail without the IMAP client being notified of the EXPUNGEs. New mails are also not noticed, so this should be used only when it's known that the clients don't keep the connection open for long.

imapc: Make sure a valid UIDVALIDITY is returned by SELECT Fixes errors such as: Error: Synchronization corrupted index header (in-memory index): uidvalidity=0, but next_uid=9

imapc: Fix infinite reconnection when server keeps sending corrupted state When corrupted state was found, imapc_client_mailbox_reconnect() is called to reconnect. This call skipped the normal "is it safe to reconnect?" checks causing potentially infinite reconnections.

imapc: include imapc-client.h in imapc-storage.h It was already required to be able to successfully include imapc-storage.h.

imapc: Support imapc_features=search without ESEARCH extension

imapc: Rename imapc_storage_has_modseqs() to imapc_mailbox_has_modseqs() Simplifies the following patch.

Updated copyright notices to include the year 2017.

imapc: Don't allow "*" in SEARCH replies Doesn't fix anything, but makes the parsing a bit more correct.

imapc: Cleanup - change delayed_expunged_uids to seq_range. This simplifies the next commit.

imapc: Fixed EXPUNGE handling when imapc_features didn't have modseq

imapc: Added support for imapc_features=modseq If the remote server supports CONDSTORE or QRESYNC extensions we'll use the remote's MODSEQ and HIGHESTMODSEQ counts. There are some situations where the HIGHESTMODSEQ isn't updated exactly correctly on an open mailbox, so this feature shouldn't be fully relied on. It was primarily implemented for dsync+imapc support - both for preserving modseqs and also for HIGHESTMODSEQ lookups.

imapc: Added imapc_features=fetch-msn-workarounds This can be used to work around broken servers that send invalid MSNs. This avoids errors like: imapc: Mailbox 'INBOX' state corrupted: FETCH UID mismatch (78976 != 82589)

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

imapc: Removed commented out code. It was probably accidentally committed debug code.

imapc: Set storage's error to "internal error" if we detect mailbox state corruption. This fixes "unknown internal error" in at least syncing code when an expunged message reappears.

imapc: Fix to previous change - labels are strings and not atoms. Allow also atoms just in case

imapc: Ignore \Muted GMail label

imapc: If imapc_features has gmail-migration, fetch X-GM-MSGID at startup and cache it. This works only if index files haven't been disabled.

imapc: Fixed STATUS_FIRST_RECENT_UID to return the (mostly) correct UID.

imapc: Added imapc_features=search support for sending SEARCH commands. Currently requires the remote server to support ESEARCH (but this would be easy to avoid). This is only minimally tested for now, so bugs may exist (especially related to sub-queries).

imapc: Merged gmail-pop3 and gmail-labels-keyword features into a single gmail-migration feature There's really no other reason to use them except for migration.

imapc: Implemented imapc_features=gmail-pop3 that also migrates pop3_deleted_flag. This also caused gmail-pop3-uidl feature to be renamed to simply gmail-pop3, which includes both the features.

imapc: Added imapc_features=gmail-labels-keyword This is a bit kludgy feature mainly intended for migrations from GMail. Unfortunately I couldn't figure out any nicer way to do this for now. GMail's "All Mail" folder contains all messages in all folders, but it also contains some messages that don't exist in other folders. For migrations we want to copy only those messages that don't exist elsewhere. This can now be achieved with something like: doveadm -o imapc_features='gmail-labels-keyword ...' \ backup -F '-$GmailHaveLabels' mdbox:~/mdbox Note that dsync can't handle inserting mails into folders, so if doveadm backup is already run once and one of the existing mails loses all labels, doveadm backup will delete the whole folder and start again.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

imapc: Avoid crashing if server happens to send invalid resp-text-codes. If [KEY VALUE] is missing the VALUE, just set it to "" instead of NULL. Found by Coverity

Updated copyright notices to include year 2014.

imapc: Merge identical FETCH commands together (only updating UID range)

imapc: Don't crash if server sends EXISTS while mailbox isn't selected.

imapc: If APPEND to selected mailbox doesn't send EXISTS, try if NOOP sends it. This makes Dovecot behave better with Courier.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.

lib-storage: Renamed mail_storage_set_index_error() to mailbox_set_index_error()

Added array_append_zero() to write a zero-filled record to an array. Replaced (void)array_append_space() calls with it.

imapc: Removed brokenly used explicit data stack frame. Fixes crashes when a message has more than 8 keywords.

Use timeout_add_short() for sub-second timeouts. Fail at compile time if timeout_add() is <1s. In future timeout_add() could perhaps also be made less precise, so that it would try to group timeouts to run around at the same time.

Updated copyright notices to include year 2012.