global: don't cast NULL to void * NULL is guaranteed to be a void * thanks to dd6043c05e32a8e8db1233ed711a2c74d1477a89.

Updated copyright notices to include the year 2018.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

imapc: Add imapc_features=fetch-empty-is-expunged When FETCH returns an empty mail, the mail is assumed to be expunged.

global: use i_close_fd{,_path}() instead of open-coding them

global: start relying on [io]_stream_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_unref(&E); - } + i_stream_unref(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_unref(&E); - } + o_stream_unref(&E);

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

lib-storage: convert struct imapc_mail casts to container_of

lib-storage: convert missed imapc casts to container_of

lib-storage: convert imapc to use container_of

imapc: Prefech - Initialize cached stream only if needed If the mail is immediately accessed for other purposes (e.g. fetching message flags), there's no need to go through all the trouble of initializing the mail stream.

imapc: Fix prefetching specific headers FETCH BODY[HEADER.FIELDS ...] shouldn't be used if imapc_features doesn't include fetch-headers. Also neither this nor BODY[HEADER] should be sent if we already have header/body stream.

imapc: Avoid sending FETCH BODY[HEADER] when BODY[] is already being fetched This probably only shows up in some special situations with plugins.

imapc: include imapc-client.h in imapc-storage.h It was already required to be able to successfully include imapc-storage.h.

imapc: Add imapc_features=fetch-bodystructure This allows using the remote IMAP server's BODY and BODYSTRUCTURE replies.

imapc: Use IMAPC_COMMAND_STATE_AUTH_FAILED to indicate auth failure

imapc: Error handling wasn't setting storage error everywhere. This would have used the previous error, which might not have been correct.

lib-storage: Add mail.mail_stream_opened and .mail_metadata_accessed These allow determining after mail_*() calls how efficiently they were performed.

Updated copyright notices to include the year 2017.

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

imapc: Fixed crash caused by pool_unref() API change. Calling pool_unref() set the mail_private->pool=NULL, which crashed in index_mail_free(). Fixed this by removing the unnecessary ref/unref entirely. We're already waiting in imapc_mail_close() for all the existing FETCHes to finish, so the callback will always have only valid mails with valid pools.

imapc: Don't try to FETCH uncommitted mails, because it would attempt to FETCH uid=0

imapc: If FETCH didn't send our wanted data, log the tagged FETCH reply text.

imapc: Don't use fetch-fix-broken-mails for NO [LIMIT] FETCH replies

imapc: Remove X-Message-Flag filtering if imapc_features has rfc822.size

imapc: Don't use fetch-fix-broken-mails for OK and NO [SERVERBUG] FETCH replies Hopefully no servers are actually returning OK without returning a FETCH reply. If they are, maybe we need another workaround.. In any case Yahoo IMAP sometimes loses state and starts returning OK without FETCH replies to all UID FETCH requests (and BADs to FETCHes). It also may return NO [UNAVAILABLE] for both permanent and temporary FETCH failures, so we can't do anything with that. I added NO [SERVERBUG] because that's what Dovecot responds to temporary failures. I'm not sure how useful that check is though.

imapc: Prefetching shouldn't send FETCH requests for headers that are already cached.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

imapc: If FETCH commands fail, have imapc_mail_fetch() always return failure. Earlier it may have returned success and imapc would later complain about a missing FETCH field.

imapc: Various optimization fixes to fetching messages' virtual size.

imapc: Added imapc_features=zimbra-workarounds Zimbra (at least v5.0.18_GA_3011.RHEL4_64) can return different headers depending on whether the whole message body was fetched or only (partial) headers. This probably happens only for invalid characters that are translated into '?'. With this workaround enabled we don't use FETCH BODY.PEEK[], but we do FETCH (BODY.PEEK[HEADER] BODY.PEEK[TEXT]) and merge the results together. This way the results are always consistent and headers don't suddenly change.

imapc: Prefetching wasn't done for headers if there weren't also other fields.

imapc: Don't flush prefetch FETCH command before it has mail_prefetch_count number of mails.

imapc: Make sure we don't flush prefetch FETCH command unneededly.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

imapc: Avoid hanging when running into server problems. imapc_mail_fetch_flush() caused imail->fetch_count to drop to 0, but imapc_mailbox_run() still started imapc_client_run() which was doing nothing.

imapc: Fixed crash when FETCH command immediately failed due to connection error.

Updated copyright notices to include year 2014.

imapc: Merge identical FETCH commands together (only updating UID range)

imapc: Fixes to imapc_feature fetch-headers

imapc: When sending FETCH, always request also missing wanted_fields. This avoids sending multiple FETCH commands when prefetch hadn't already fetched everything.

imapc: Avoid FETCH INTERNALDATE for getting save_date when we already know received_date.

imapc: Don't send FETCHes for data that is already in cache.

imapc: Crashfix for previous change

imapc: Added imapc_feature fetch-header. It uses FETCH BODY.PEEK[HEADER.FIELDS (...)] whenever possible instead of fetching the entire header.

imapc: Reorganize code so that imapc_list works without imapc_storage. Most importantly fixes crashes when imapc_list is trying to lookup hierarchy separator before storage is created.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.