Updated copyright notices to include the year 2018.

imapc: Don't skip listing "INBOX" when INBOX/ namespace prefix is used. The INBOX was still listed as part of the autocreated mailboxes, unless MAILBOX_LIST_ITER_NO_AUTO_BOXES was used.

lib-storage: imapc - use MAILBOX_LIST_PROP_NO_LIST_INDEX mailbox list index does not work with imapc, so disable it. Panic: file mail-storage.c: line 1858 (mailbox_get_metadata): assertion failed: ((items & MAILBOX_METADATA_GUID) == 0 || !guid_128_is_empty(metadata_r->guid))

lib-storage: imapc - Fix spelling mistakes Original work by @jsoref

global: Remove dead code Found with clang static analyzer.

imapc: If mailbox iteration fails, make sure error message isn't lost.

imapc: Don't reconnect on DELETE if auth failure was already seen.

imapc: Remove root_sep_lookup_failed cache The auth_failed_* should already be enough for this. This removal also fixes the storage error message to be auth_failed_reason when possible.

imapc: Change auth_failed boolean to more specific auth_failed_state Since we now rely on auth_failed_state being initialized to zero, explicitly set IMAPC_COMMAND_STATE_OK to be defined as 0.

imapc: Remove auth_failed check from imapc_list_get_storage_name() Reverts 9949dc3649ac7a00289f6bf0662c793bee3d4286. It doesn't seem to be actually needed at least now, and it's breaking: * SELECT INBOX -> failure due to remote server being down * SELECT INBOX -> NO [CANNOT] Invalid mailbox name: Name is empty

lib-storage: Explicitly name function pointers in mailbox lists This allows adding more fields to struct mailbox_list_vfuncs without compiler warnings.

imapc: include imapc-client.h in imapc-storage.h It was already required to be able to successfully include imapc-storage.h.

imapc: Make sure client is logged in when checking capabilities Especially with imapc_features=delay-login the capability could have been looked at before the client was even connected.

lib-storage: Set internal error in imapc_list_get_hierarchy_sep

lib-storage: Return empty value in imapc_list_get_storage_name on auth error Avoids clobbering authentication error.

lib-storage: Do not clobber error with imapc

lib-storage: Add and use default mailbox iterator The idea is to allow mail plugins to see also the non-existent autoboxes by feeding them thru the iterator. Fixes problem where autocreated boxes are not seen by ACL plugin.

imapc: Use LOGOUT to cleanly disconnect from server. This makes it clearer in the remote server's logs whether the disconnection was intentional or not. Use a hardcoded 5 second timeout for LOGOUT. It should be enough time for the server to finish sending the tagged reply.

imapc: Allow using LAYOUT=none without crashing.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

imapc: Log server disconnection error only once.

global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)"

lib-storage: Deduplicate code into mailbox_list_settings_init_defaults()

imapc: Use struct mail_namespace.user_set

imapc: don't mix positional and designated initialization

imapc: Mark most of the commands retriable.

imapc: If root separator lookup fails, fail all further lookups. We already returned a potentially wrong separator (since there's no way to return error), so we don't want to continue and possibly make things worse.

imapc: Added missing error handling to subscriptions list refreshing.

imapc: Fixed mailbox name escaping for CREATE, DELETE, RENAME, SUBSCRIBE, UNSUBSCRIBE

imapc: Fixed escaping/unescaping mailbox names. This fixes accessing mailbox names with '%' (the escape_char). It also fixes local namespace separator being different from the remote separator.

imapc: Don't duplicate standard mailbox flags in LIST replies. We added the standard \NoSelect, \NonExistent, \NoInferiors and \Subscribed to special_use string, which caused them to be sent duplicated.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

imapc: Fixed crash if imapc_host or imapc_password setting was missing. Instead of giving a nice error message about it. Found by Coverity.

imapc: Fixed handling escape-char The current code should now handle all kinds of mailbox names correctly, including: ~/foo %7e/bar

imapc: Fixed check to see if prefix!="" in previous commit.

imapc: Don't return mailbox list entries that would result in name="". So basically don't return namespace prefix if imapc_list_prefix="".

imapc: If login is aborted at deinit, don't log an error.

imapc: Don't wait for login to succeed at mailbox list creation. The failure will be visible in the next command. This wait was here mainly for imap, but cbdfca7d24a6 implements the wait in imap process directly. Other (current) protocols don't need such wait at all. Most importantly this change allows doveadm to handle imapc login failures by seeing them as MAIL_ERROR_PERM errors when listing mailboxes or opening a mailbox. This allows it to return a different exit code from temporary failure (which it is not).

imapc: If authentication fails, preserve the error message as storage/list error. This isn't very helpful yet, because the mailbox list creation itself fails.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

imapc: If connection isn't in selected state when deleting mailbox, don't try to UNSELECT it.

imapc: Cache LIST replies for a while to be able to immediately ask for mailbox flags/existence. Besides giving better performance, this will fix bugs in some servers where LISTing a single mailbox doesn't necessarily return it. (In this case a mailbox named "in" wasn't returned, but I think Dovecot has had bugs related to this also.)

Updated copyright notices to include year 2014.

imapc: Fixed assert-crash when listing INBOX and imapc_list_prefix was set.

imapc: Don't crash if imapc_password is missing.

imapc: Don't log unnecessary errors at deinit about aborted hiearchy separator lookup. The lookup is done asynchronously at startup. It doesn't matter if we never get around to finishing it.

imapc: Abort pending commands before any deinitialization to avoid crashes.

imapc: Reorganize code so that imapc_list works without imapc_storage. Most importantly fixes crashes when imapc_list is trying to lookup hierarchy separator before storage is created.

imapc: Code cleanup: Don't access imapc settings via storage.

imapc: Fixed list iteration when namespace and backend separators differed.

imapc: Minor code cleanup

imapc: If imapc isn't the inbox=yes namespace, do the login and initial LIST in background.

imapc: When deleting a mailbox, unselect the current one just in case they're the same.

imapc: Index dirs were being wrongly deleted when imapc_list_prefix was set.

imapc: If imapc_list_prefix is set, don't skip it in filesystem paths. Most importantly this fixes the index path when accessing the imapc_list_prefix mailbox itself (so the indexes won't be in the mail root dir, where they don't get deleted when mailbox is deleted).

imapc: Return correct mailbox list flags for the imapc prefix mailbox itself.

imapc: Allow accessing the imapc_list_prefix itself.

imapc: Don't assert-crash when trying to access imapc_list_prefix itself.

imapc: Pass through SPECIAL-USE LIST flags if imapc is in INBOX namespace.

imapc: Don't assert-crash when ACL plugin tries to lookup "" mailbox.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.