global: Use only explicit int -> bool conversions These were checked with a patched clang.

global: Require comparisons to be strict boolean expressions * No implicit integer -> boolean or pointer -> boolean conversions * !expr can be used only if expr is boolean type These were checked with a patched clang. It found various actual bugs, which were fixed by the previous commits.

Remove now-unnecessary direct stdlib.h #includes.

Removed all invocations of strtoll() and friends.

lib-otp: OTP_MAX_WORD_LEN wasn't actually enforced, any word lengths could have been used. Doesn't look like this could have caused any real problems. Found by Coverity

Renamed buffer_create_*data() to buffer_create_from_*data() for consistency. Especially i_stream_create_from_data() was a very similar function, which made it difficult to remember which one should have "from" and which one shouldn't.

Marked functions parameters that are allowed to be NULL. Some APIs were also changed. The non-obvious APIs where NULL parameter was changed to "" are master_service_init() and auth_master_user_list_init(). These checks can currently be enabled only on a patched clang: http://llvm.org/bugs/show_bug.cgi?id=6786

Avoid casting away const qualifiers wherever possible. --HG-- branch : HEAD

buffer_create_[const_]data() API change: Take buffer_t as parameter instead of allocating it. --HG-- branch : HEAD

Added OTP and S/KEY authentication mechanisms. Patch by Andrey Panin. --HG-- branch : HEAD