global: don't cast NULL to void * NULL is guaranteed to be a void * thanks to dd6043c05e32a8e8db1233ed711a2c74d1477a89.

Updated copyright notices to include the year 2018.

global: use i_rand_limit() and i_rand_minmax() when possible

global: Replace rand with i_rand

lib-mail: istream-header-filter - Fix HEADER_FILTER_ADD_MISSING_EOH with empty input The result for "" should be "\n", not "\n\n". The second "\n" would belong to the mail body. This fixes calculating hashes for incremental dsync when mail didn't have Date or Message-ID headers, resulting in e.g.: Warning: Deleting mailbox 'INBOX': UID=1 already exists locally for a different mail: Headers hashes don't match (e1c06d85ae7b8b032bef47e42e4c08f9 vs 68b329da9893e34099c7d8ad5cb9c940)

lib-mail: Fix duplicate HEADER_FILTER_ADD_MISSING_EOH callback call If headers weren't modified, the second reading of the istream shouldn't call any callbacks.

Updated copyright notices to include the year 2017.

lib-mail: header filter should call callback for added EOH If we add a EOH because there wasn't one and HEADER_FILTER_ADD_MISSING_EOH was specified, we should invoke the callback for it. Otherwise, it is unnecessarily difficult for consumers to add a header since there is no way to know if EOH will be present ahead of time.

lib-mail: refactor header filter test code

global: Use const for all test_functions[] arrays

global: Use "static const" for all struct tests[] arrays

global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)"

global: Avoid unnecessary unsigned integer wraps. Avoids complains from clang -fsanitize=integer

lib-mail: stop calling str_append_n and memcmp with NULL in tests

lib-mail: Fixed istream-header-filter calling callback(hdr=NULL) It should do it on the following parsings as well if there were any callbacks that were called, or if the hdr==NULL callback added any headers. This is important because the hdr==NULL call could do some cleanups.

lib-mail: istream-header-filter - Don't return -2 too early We returned -2 after we already added the data to the buffer. We should have returned -2 only on the next read() call if nothing was skipped.

lib-mail: Fixed istream-header-filter callback's matched with eoh Reversed the matched-parameter handling for hdr->eoh, so it's consistent with non-eoh headers.

lib-mail: Fixed istream-header-filter unit test names

lib-mail: istream-header-filter - fixed adding headers at eoh

lib-mail: istream-header-filter: Fixed stat() with HEADER_FILTER_HIDE_BODY

lib-mail: istream-header-filter HEADER_FILTER_ADD_MISSING_EOH fixes When using HEADER_FILTER_CRLF_PRESERVE, add CR to the EOH if the previous header line ended with CRLF. When header ends to a header without newline, add two newlines so we can get the actual EOH added.

lib-mail: istream-header-filter: Fixed stat() with HEADER_FILTER_END_BODY_WITH_LF

lib-mail: More fixes to istream-header-filter with large input. Don't assume that when reading the header the second time we'll get exactly the same header blocks as the first time. This commit also prevents the filter callback from switching the matching-decision on non-first header line. This shouldn't be needed and it could just cause confusion. (It also made it a bit easier to implement this fix.)

lib-mail: Improved istream-header-filter unit test. Existing code already assumes that the callback is called for all the header data. So it's not used just for filtering headers but also parsing the header contents. Make this assumption now explicit as a unit test.

lib-mail: istream-header-filter didn't limit memory usage. A large header was always added to hdr_buf, ignoring any max_buffer_size limits.

lib-mail: Code cleanup to istream-header-filter unit test The exclude_headers arrays were used in a confusing way. The X-Drop header wasn't actually even used in the exclude_headers.

lib-mail: Reading from istream-header-filter second time reverted callback's eoh change.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-mail: Fixed istream-header-filter when callback excluded multiple headers. This only affected pop3-migration plugin.

lib-mail: Fixed modifying headers with i_stream_header_filter_add() If the stream was read twice, the second time the callback wasn't called and the header wasn't modified.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.