Updated copyright notices to include the year 2018.

global: Add flags parameter to i_stream_create() and set it to 0 This just changes the API - the following changes add the new flag.

lib-mail: istream-attachment-extractor - Don't modify buffer during failure If i_stream_read() returns -1 because the attachment file couldn't be created, don't add the trailing data to the main istream. It's not useful, and the following extra checks will cause it to assert-crash.

global: Replace o_stream_nfinish() with o_stream_finish() whenever possible

global: start relying on buffer_free(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - buffer_free(&E); - } + buffer_free(&E);

global: start relying on pool_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - pool_unref(&E); - } + pool_unref(&E);

global: start relying on [io]_stream_destroy(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_destroy(&E); - } + i_stream_destroy(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_destroy(&E); - } + o_stream_destroy(&E);

global: start relying on i_close_fd(-1) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != -1) - i_close_fd(&E); + i_close_fd(&E);

global: Add/change switch case "fall through" comments These fix warnings with gcc 7's -Wimplicit-fallthrough

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-mail: istream-attachment-extractor - use EIO for internal errors These happen only if the attachment writing failed for some reason. The input stream itself can't have any errors, so EINVAL isn't proper.

lib-mail: istream-attachment-extractor - remove unnecessary code It's enough to set the stream_errno.

global: Handle broken Content-Type headers consistently. 1) Only the first Content-Type header is used. (Simpler than using the last.) 2) Invalid Content-Types are parsed as far as we can. This is mainly to make sure they aren't treated as missing Content-Types, which could cause them to become text/plain.

lib-mail: Fixed infinite loop in istream-attachment-extractor Broken by 7f74811b7. Pretty much any larger attachment going through this istream had a good potential of going into an infinite loop.

global: Make sure i_stream_read() calls handle 0 and -2 return values correctly.

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

global: Use i_stream_get_max_buffer_size() wherever possible After 7be8ba0c0 it's no longer correct to access stream->max_buffer_size directly. These changes fix using istream-chain with various wrapper streams.

lib: istream - migrate to i_stream_read_more() Scripted to find all the low-hanging-fruit (single line calls), but hand-checked: git grep i_stream_read_data.*,\ 0\) | sed s/:.*// | \ xargs sed -i -e 's/i_stream_read_data(\(.*\), \(.*\), \(.*\), 0)/i_stream_read_more(\1, \2, \3)/' Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-mail: return void from message_parser_deinit()

lib-mail: Minor code cleanup to message_parser_deinit() calls.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-mail: Improved istream-attachment-extractor error logging.

lib-mail: Fixed crash in istream-attachment-extractor error handling path

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-mail: istream-attachment-extractor didn't correctly handle increasing base64 line length. Based on patch by Pavel Stano

lib-mail: istream-attachment-extractor handled mixed LFs vs CRLFs correctly. Unless all the lines have the same newlines, the attachment can't be recreated back exactly the same.

Updated copyright notices to include year 2014.

Fixes and improvements to istream-attachment-extractor error handling. If an attachment saving failed, the mail was still saved to disk, just without the attachments.

istream-attachment-extractor: Fixed handling attachment as the message body without MIME. Don't crash at the end after parsing the base64 data.

iostreams: Added close_parent flag to close() handler and clarified close/destroy APIs. This makes it unambiguous how things work: Unless you explicitly call [io]_stream_close(), the parent streams won't be closed. This is what most (hopefully all!) of the existing code expects. I was wondering a bit if [io]_stream_destroy() should simply have been removed and replaced with [io]_stream_unref() calls, since they would have worked basically everywhere, but there might be some places where it's better to have explicitly closed the stream (and where closing the parent stream doesn't matter).

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.