lib-lda: Parse Return-Path header using RFC5322 (IMF) "path" syntax, rather than RFC5321 (SMTP) "Path" syntax. SMTP does not allow white space, which causes all kinds of trouble when the address is parsed from a header field.

lib-lda: Require context in mail-deliver Satisfies static analyzers

Updated copyright notices to include the year 2018.

lib-lda: Properly check whether MAIL FROM is the NULL sender <>. There's a function for that, since comparison with NULL pointer is not sufficient.

lib-lda: Added SMTP parameter fields to struct mail_deliver_context. This moves the original recipient field inside the SMTP parameters. This also affects both lda and lmtp. Changes are applied there accordingly.

lib-lda: Changed struct mail_deliver_context address fields to use the new struct smtp_address type.

lib-lda: Renamed struct mail_deliver_context fields for consistency with lib-smtp. New fields are added in subsequent commits.

lib-lda: Use hostname and postmaster_address settings from mail_storage_settings where possible.

lib-storage: Renamed duplicate to mail_duplicate. This makes more sense given where this is now located.

lib-lda: Moved most of mail_deliver_save_open() to lib-storage. This prevents the need to link Pigeonhole lib-sieve to lib-lda, which makes no sense for IMAPSIEVE. This also allows lib-sieve to have more control over how mailboxes are opened.

lib-storage: Add reason to mailbox.transaction_begin()

lib-storage: Add reason to mailbox_transaction_begin() Remove mailbox_transaction_set_reason().

lib-lda: Fix crash if syncing save destination mailbox fails

global: Add mailbox_set_reason() calls Added to the most important places.

global: Log internal storage error on failure

lib-lda: Fix pigeonhole testsuite to not crash

lib-lda: Fix delivery logging when Sieve performs multiple actions Previous code assumed that it would work like: - save/copy - transaction commit - mail_deliver_ctx_get_log_var_expand_table() - repeat for transaction 2 While it really works: - transaction 1: save/copy - transaction 2: save/copy - transaction 1: commit - mail_deliver_ctx_get_log_var_expand_table() - transaction 2: commit - mail_deliver_ctx_get_log_var_expand_table() So the cache needs to be stored per transaction. This code still wouldn't work correctly if Sieve saved mails multiple times within the same transaction, but that doesn't happen (at least currently).

lib-lda: Refactor - mail_deliver_log_update_cache() doesn't need entire deliver_ctx

lib-lda: Refactor - Add struct mail_deliver_mailbox

lib-lda: Do not involve mail-deliver plugin unnecessarely If no mail delivery by LDA/LMTP is being done, do not hook into the process. Fixes signal 11 crash with lazy-expunge.

lib-lda: Code cleanup - remove unnecessary dest_mail check

lib-lda: Don't set mail_deliver_context.dest_mail too early. It must be NULL for the caller, unless save_dest_mail==TRUE

lib-lda: Implement %{storage_id} correctly

lib-lda: Fix deliver_log_format variables with Sieve With Sieve it was using src_mail for getting the values, which weren't correct especially if Sieve had modified the mail.

lib-lda: Code cleanup - mail_deliver_open_mail() now uses uid parameter

lib-lda: Remove %{storage_id} setting for now. It doesn't work with Sieve. The following patches add it back properly.

lib-lda: Redesign mail_deliver_context.var_expand_table cache

lib-lda: Avoid using mailbox_save_set_dest_mail()

lib-lda: Remove unused mail_deliver_get_log_var_expand_table()

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib: API change - var_expand*() now returns error string. This allows callers to fail properly if the format string is invalid.

global: Try to initialize var_expand_tab[] directly. This avoids accidents with the array numbering being wrong.

lib-lda: Support %{storage_id} in deliver_log_format

lib-lda: Code cleanup - move code to mail_deliver_open_mail() No functional changes. On its own this is a rather useless cleanup, but simplifies the next patch.

Remove t_malloc in favour of t_malloc_no0 Using either t_malloc_no0 or t_malloc0 makes it clear whether the allocated memory is zeroed or not.

lib-lda: remove forced logging of session_id

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-lda: Fixed crash in mail_deliver_get_log_var_expand_table(). Discovered by clang static analyzer. This caused crashes with older versions of Pigeonhole.

lib-lda: Added %{to_envelope} to deliver_log_format

lib-lda: Assume that the caller sets delivery_time_started This is required because parts of the delivery time may be done at the time the user is being initialized, so it needs to be set before the user init is done.

lib-lda: mail_deliver_log() now updates the %{delivery_time} instead of using the first cached value. The first time the cached values are set the transaction isn't committed and the mailbox isn't synced.

lda, lmtp: Added delivery_time and session_time variables to deliver_log_format session_time is meaningful only with LMTP. The delivery_time is separate for each mail delivery. The results are in milliseconds now. If needed we could add a new %modifier that converts it into secs.millisecs.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.

lib-lda: Fixed passing through error message when mailbox couldn't be opened.

lda/lmtp: If mail delivery fails with tempfail, don't fallback to saving to INBOX.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.