Updated copyright notices to include the year 2018.

lib-index: Replace mail_index_set_log_rotation() with mail_index_set_optimization_settings() This allows more easily adding optimization-related settings.

lib-index: Avoid opening .log.2 file if .log was reset After a reset there's no point in trying to read the older log files. This avoids trying to open .log.2 at least for newly created mailboxes when trying to lookup log file sequence 1 (since due to some bug/feature the log files start from sequence 2).

lib-index: Fix wrong mail_index_modseq_header automatically It happens only on the next sync, although that isn't actually guaranteed to happen. Still, it happens almost always so this should be good enough.

lib-index: Fix mail_index_get_modification_time() to work when index isn't open. index->filepath may be NULL after a failed index open, and it's a bit unsafe to trust that index->log->filepath isn't NULL either. So just build the full path from elements that are definitely non-NULL. Also stat() only dovecot.index.log, because it's always supposed to exist. If it doesn't, something's broken and stat()ing dovecot.index doesn't make much sense. This commit removes mail_transaction_log_get_mtime(), which is no longer needed. Fixes: Panic: file mail-index.c: line 931 (mail_index_file_set_syscall_error): assertion failed: (filepath != NULL)

lib-index: If refreshing finds dovecot.index.log gone, assume the mailbox was deleted Don't try to recreate the log file again. It can just cause further problems. A way to reproduce this problem with NFS when INDEX dir is specified: * create mailbox foo, select foo, IDLE * delete mailbox foo --> foo's index is recreated back by IDLEing process

lib-index: Fix compiler warning with 32bit time_t

lib-index: Track .log.2 rotation time in index header This avoids unnecessarily stat()ing the file. Also it's a bit better since it's tracking the actual rotation time, not the mtime of what the .log file happened to have at the time of rotation. The initial rotation timestamp is written only to the dovecot.index header without going through dovecot.index.log. This works, because the dovecot.index is written practically always after a log rotation. For the rare cases when it doesn't happen, the dovecot.index.log.2 just gets deleted later after the next log rotation.

lib-index: Check .log.2 rotation only when syncing Instead of also whenever appending transactions to .log file. This shouldn't change the behavior much, and it's needed for the following change to work correctly.

lib-index: Use nfs_safe_stat() to avoid having to handle stat() ESTALE error Slightly simplifies the code.

lib-index: Don't ignore mail_transaction_log_move_to_memory() failure

lib-index: mail_transaction_log_file_map() - return reason/error string This can help figuring out why some error happened when more context is provided in the caller's error messages.

lib-index: Don't increase modseq for backend/dirty flag changes These flags are used only for internal changes and they shouldn't be triggering any modseq changes. To avoid modseqs from unexpectedly shrinking, the new modseq counting behavior is enabled only for newly rotated transaction log files that have a new minor_version.

lib-index: Code cleanup - expand LOG_WANT_ROTATE() macro There was no reason it had to be a macro. Also this fixes off-by-one error when checking for log_rotate_min_size.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-index: Compiler warning fix

lib-index: Compiler warning fix.

lib-index: Add mail_index_set_log_rotation()

lib-index: Improve errors - return reason in mail_transaction_log_refresh()

lib-index: Improve errors - return reason in mail_transaction_log_file_open()

lib-index: Add more information to "Missing middle file" error.

lib-index: mail_transaction_log_find_file() - remove wrong optimization. When opening the index, it's possible that: process A: .log is opened with seq=1 process B: Rotates the .log and writes a new dovecot.index with log_file_seq=2 process A: dovecot.index is opened. mail_transaction_log_view_set() now wants to file log_file_seq=2 with mail_transaction_log_find_file(), but because open_count==0, the .log isn't refreshed.

lib-index: If mail_transaction_log_lock_head() locking took long, include reason string in warning

lib-index: Small improvements to logging the reason for long transaction log lock waits

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-index: Replaced some unlink()s with i_unlink*()s where we could. This changes some mail_index_set_error() calls to i_error()s, but because these unlink() failures don't actually fail the operation it doesn't matter. In fact it may be even better that it doesn't overwrite the existing index->error if it exists.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-index: If transaction log is unexpectedly recreated while it was locked, log a nice error. Instead of just assert-crashing.

lib-index: Include reason string in warnings about keeping transaction log locked for too long.

lib-index: Replaced some automatic transaction log unlocks with asserts. Some earlier Dovecot versions were read-locking transaction logs and this was useful there. But now we only do exclusive locking for the log head, so it's an error not to explicitly unlock the files.

Updated copyright notices to include year 2014.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.