Updated copyright notices to include the year 2018.

global: Use t_buffer_create sed -i -e 's/buffer_create_dynamic(pool_datastack_create(), */t_buffer_create(/g'

lib,lib-index: Use #ifdef with WORDS_BIGENDIAN Some were missing from the last change.

global: Use #ifdef instead of #if with WORDS_BIGENDIAN This is to not rely on undefined WORDS_BIGENDIAN being evaluated as 0.

global: Use PRI* macros and %zu instead of casting

global: start relying on buffer_free(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - buffer_free(&E); - } + buffer_free(&E);

global: Add/change switch case "fall through" comments These fix warnings with gcc 7's -Wimplicit-fallthrough

lib-index: Fix wrong mail_index_modseq_header automatically It happens only on the next sync, although that isn't actually guaranteed to happen. Still, it happens almost always so this should be good enough.

lib-index: Code cleanup - move code to get_modseq_next_offset_at() In preparation for making the next commit smaller.

lib-index: Fix modseq tracking with multiple flag updates The earlier code was checking only the first flag record update. If the first one had only internal flag changes but (some of) the rest didn't, the modseq wasn't counted correctly. This was probably pretty rare.

lib-index: Fix modseq tracking for MAIL_INDEX_MAIL_FLAG_UPDATE_MODSEQ This is used to increase modseq for mails when their private flags change. Use an already existing MAIL_TRANSACTION_FLAG_UPDATE_IS_INTERNAL() that does this properly. (This change preserves another bug, which is fixed in the next commit.)

lib-index: Add missing colon to log text It's added elsewhere

lib-index: Don't ignore mail_transaction_log_move_to_memory() failure

lib-index: Fix start_offset > sync_offset error handling for in-memory indexes

lib-index: Improve "start_offset > current sync_offset" error message. Try to make it clear what is the root cause of it.

lib-index: mail_transaction_log_file_get_highest_modseq_at() - return error string This can help figuring out why some error happened when more context is provided in the caller's error messages.

lib-index: mail_transaction_log_file_map() - return reason/error string This can help figuring out why some error happened when more context is provided in the caller's error messages.

lib-index: Don't increase modseq for backend/dirty flag changes These flags are used only for internal changes and they shouldn't be triggering any modseq changes. To avoid modseqs from unexpectedly shrinking, the new modseq counting behavior is enabled only for newly rotated transaction log files that have a new minor_version.

lib-index: Add macros to check if transaction log file version is new enough. The version numbers are 8bit, so we can generate a single 16bit number out of them.

lib-index: clear file->mmap_size only after logging it Logging the error with size=0 loses information.

lib-index: don't reset ioloop_time on mmap error The variables seems to have been in the wrong order.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-index: Fix assert-crash if .log creation unexpectedly fails at the end Pretty much the only reason for this to happen is if the index directory was deleted while another process still had the index open. Even this doesn't normally trigger this crash, because there are other checks earlier that usually catch it. So it crashes only in some race conditions. Fixes: Error: rename(.../dovecot.index.log.newlock, .../dovecot.index.log) failed: No such file or directory Panic: file mail-transaction-log-file.c: line 105 (mail_transaction_log_file_free): assertion failed: (!file->locked)

lib-index: Make sure buffer is not null before freeing Fixes signal 11 crash under stress.

lib-index: mail_transaction_log_file_sync(): Don't mix I/O errors and corruption

lib-index: Fix assert-crash after "log file shrank" error. Fixes: Panic: file buffer.c: line 316 (buffer_set_used_size): assertion failed: (used_size <= buf->alloc)

lib-index: Limit mmap errors in txn log file to 1/s

lib-index: Improve errors - return reason in mail_transaction_log_file_open()

lib-index: If mmap() fails, include the attempted size in the error.

lib-index: Added mail_index_transaction_get_highest_modseq()

lib-index: Make sure an already-corrupted index/log isn't written

lib-index: Fixed mail_index_modseq_get_next_log_offset() when accessing .log.2 file->sync_offset was set only after header, so sync_highest_modseq was also same as initial_modseq. The previous code then just returned offset pointing to sync_offset, which was too early.

lib-index: Make sure new dovecot.index.log files start tracking modseqs. This will make mail_index_modseq_get_next_log_offset() work correctly even if modseqs haven't been explicitly enabled.

global: Replace buffer_get_used_size(buf) with buf->used Doesn't make any diffence to code generation, but it's somewhat simpler code. It's also more consistent since most of the code nowadays uses the ->used.

lib-index: If transaction log was locked for at least 30 secs, log a warning (not at 3min) This is because we log a warning about it already when locking it took 30 seconds, so it's useful to see which process was actually keeping the lock.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-index: mail_transaction_log_file_map() didn't properly check start_offset If it was too high, it still returned successful mapping. This could have caused an assert-crash later on when the start_offset was actually attempted to be used.

lib-index: Replaced some unlink()s with i_unlink*()s where we could. This changes some mail_index_set_error() calls to i_error()s, but because these unlink() failures don't actually fail the operation it doesn't matter. In fact it may be even better that it doesn't overwrite the existing index->error if it exists.

Make Coverity happier.

lib-index: Added an assert. It seems to be triggering later on, but not sure how it's happening.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-index: If transaction log is unexpectedly recreated while it was locked, log a nice error. Instead of just assert-crashing.

lib-index: Detect broken log_file_tail_offset updates without assert-crashing.

lib-index: Include reason string in warnings about keeping transaction log locked for too long.

lib-index: Replaced some automatic transaction log unlocks with asserts. Some earlier Dovecot versions were read-locking transaction logs and this was useful there. But now we only do exclusive locking for the log head, so it's an error not to explicitly unlock the files.

lib-index: If locking transaction log times out, show the PID which has it locked.

lib-index, lib-storage: Fixed race conditions with deleting mailbox. Now only one process can successfully finish mailbox_mark_index_deleted().

lib-index: Don't update log_file_tail_offset unnecessarily. Update it only if we're already writing to transaction log anyway or if we're required to update the offset because mail_index_sync_commit() has increased it past non-external transactions (this is especially important with mdbox map index).

Updated copyright notices to include year 2014.

lib-index: Fixed modseq updates when modseq was over 32bits long

lib-index: mail_index_attribute_[un]set() adds changed attributes' keys to transaction log. This provides them both a modseq (so their changes become visible) as well as an efficient way to see what attributes have changed by reading the transaction log. The values themselves aren't written to the log, because they could be large.

Replaced all -1U and (unsigned int)-1 with UINT_MAX. It's somewhat clearer this way. Also clang's -fsanitize=integer gives runtime errors about -1U (but not about explicit casts, so no need to change (type)-1 casts).

lib-index: Fixed assert-crash on some error conditions.

lib-index: Give a better error message if index is readonly and log is tried to be locked.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.