Updated copyright notices to include the year 2018.

lib-index: Fix -Wstrict-bool warnings with --enable-devel-checks

lib-index: Add mail_index_base_optimization_settings

global: start relying on buffer_free(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - buffer_free(&E); - } + buffer_free(&E);

lib-index: Remove tracking of mail_index_modseq_sync.highest_modseq It's no longer necessary after the previous changes.

lib-index: Add MAIL_INDEX_OPEN_FLAG_NO_DIRTY This way mailbox format backends that don't need dirty flags can use them for other purposes.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-index: fsck now adds MAIL_INDEX_HDR_FLAG_FSCKD to header. It can only be removed by an explicit header update.

Fix -Wstrict-bool compiler warnings.

lib-index: Improve error messages when transaction log is unexpectedly lost

lib-index: Don't break indexes on syscall failures during index refreshing. Especially mmap() failures due to out of memory could have triggered this. We treated the open as successful, which meant that an empty index was opened.

lib-index: Fixes to handling resized records.

lib-index: Added header-size asserts

Removed buffer_reset(). It was just a wrapper to buffer_set_used_size() and its comment was a bit confusing (or obsolete), since it wasn't actually immediately zeroing out the buffer.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-index: If header is corrupted after syncing, log the reason why.

lib-index: Added reason_r parameter to mail_transaction_log_view_set() This is used to improve some of the error messages about index corruption.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-index: Remove assert that can never happen.

lib-index: Don't assert-crash if expunge event handling finds that everything is already expunged.

mail-index: use _REC_AT_SEQ not _MAP_IDX in loops from [seq1..seq2] [seq1-1..seq2) becomes [seq1..seq2] Don't decrement before starting, and include the upper bound. Signed-off-by: Phil Carmody <phil@dovecot.fi>

mail-index: use _REC_AT_SEQ not _MAP_IDX in loops over every record Just change the loop bounds from [0..count) to [1..count], and make the loop variale explicitly a seq. Signed-off-by: Phil Carmody <phil@dovecot.fi>

mail-index: trivial robomatic migration from _MAP_IDX to new helper All users which have a '-1' in their MAIL_INDEX_MAP_IDX have been changed to the new mail_index_rec_at_seq() helper using this sed script: $ sed -ie 's/MAIL_INDEX_MAP_IDX(\([^,]*[^)]*[^ ]\) \?- \?1)/MAIL_INDEX_REC_AT_SEQ(\1)/' src/lib-index/*.[ch] No other users have been changed. Signed-off-by: Phil Carmody <phil@dovecot.fi>

mail-index: optimise memmoves in expunge, only move each region once Rather than shifting things back and back and back with potentially O(N^2) (more precisely O(count*rec_count')) work factor, move each slice of memory only once, directly where we want it to end up (O(rec_count') work factor). Based on draft patch by Timo Sirainen. Signed-off-by: Phil Carmody <phil@dovecot.fi>

mail-index: trivial paranoia check in expunge loop We will later be moving the zone between the current seqs and the (end of the) previous seqs - this check ensures that the range is indeed monotonic, and thus that zone is positive in size. It can be zero right at the start, if the first seqs is (1,...) Based on draft patch by Timo Sirainen. Signed-off-by: Phil Carmody <phil@dovecot.fi>

mail-index: Preparatory HACK - reverse the loop order in the expunge This is the final step before the actual optimisation of the memmoves. HACK, as it it de-optimises the moves so as much as possible gets moved as many times as possible. It clears the path for a later patch which optimises them far better. Based on draft patch by Timo Sirainen. Signed-off-by: Phil Carmody <phil@dovecot.fi>

mail-index: hoist initialisation of mail index map out of expunge loop Based on draft patch by Timo Sirainen. Signed-off-by: Phil Carmody <phil@dovecot.fi>

mail-index: explicitly inline contents of sync_expunge() To later optimise the memmoves, we will need to be aware of previous seqs. It's easier to just have the guts inlined, so too much state doesn't need to be passed around. For review, this change is best viewed with a whitespace-insensitive diff, to verify that the new contents of the loop are identical to the contents of the now-absorbed function. Based on draft patch by Timo Sirainen. Signed-off-by: Phil Carmody <phil@dovecot.fi>

mail-index: call all expunge handlers first Firstly, the init checking only needs to be done once. More importantly, moving this preparatory stage into its own per-seqs loop means there's less to juggle when we optimise the memmoving loop in subequent patches. Based on draft patch by Timo Sirainen. Signed-off-by: Phil Carmody <phil@dovecot.fi>

mail-index: move expunge handler init into helper function Preparatory for later optimisation patches where the call to this will be lifted out of the expunge(seq1,seq2) inner function and done once for the whole range of seqs in one go. Based on draft patch by Timo Sirainen. Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-index: Optimize removing large number of expunges.

lib-index: Small code cleanup

Updated copyright notices to include year 2014.

lib-index: Fixed modseq updates when modseq was over 32bits long

lib-index: Replaced assert-crash with "index corrupted" error.

lib-index: Silently ignore next_uid shrinking without treating them as errors.

lib-index: Don't bother tracking if header/records were changed. They aren't really needed. When mail_index_write() is called, we already know we want to update the index.

lib-index: Backported MAIL_TRANSACTION_ATTRIBUTE_UPDATE from v2.2

lib-index: mail_index_attribute_[un]set() adds changed attributes' keys to transaction log. This provides them both a modseq (so their changes become visible) as well as an efficient way to see what attributes have changed by reading the transaction log. The values themselves aren't written to the log, because they could be large.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.