Updated copyright notices to include the year 2018.

global: Change calls to array_idx_modifiable to array_idx_get_space. Only calls that require space allocation are to be changed.

lib-index: Remove tracking of mail_index_modseq_sync.highest_modseq It's no longer necessary after the previous changes.

lib-index: Fix setting highest_modseq correctly in mail_index_modseq_header The internally counted ctx->highest_modseq wasn't correct if all of the records weren't synced. This could have happened for various reasons. Since the view's current log seq/offset is used for the header, we can also use the current highest_modseq from the view as well and it's guaranteed to be correct. This fixes various potential problems with using QRESYNC and CONDSTORE extensions. It also fixes potential errors with unhibernating imap clients, including: Error: .../dovecot.index.log: Transaction log changed unexpectedly, can't get modseq

lib-index: Update per-flag modseq value a bit more correctly. This changes the code to be similar to the per-mail modseq updating in mail_index_modseq_update(). It probably wasn't exactly wrong previously either, but this change is required for the following commits.

lib-index: Fix checking if modseq header is up-to-date We were almost always assuming that it is.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-index: Add more information to "Missing middle file" error.

lib-index: mail_index_modseq_get_next_log_offset() shouldn't return offset beyond view's head This also allows removing the same workaround from dsync code.

lib-index: Added header-size asserts

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-index: Added reason_r parameter to mail_transaction_log_view_set() This is used to improve some of the error messages about index corruption.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-index: modseq -> {log file, offset} lookup often ignored dovecot.index.log.2 This caused the code to think that the modseq was too old and fall back into slower sync. So this change should fix the dsync "Modseq .. nom longer in transaction log" warnings as well as improve IMAP QRESYNC efficiency.

mail-index: trivial robomatic migration from _MAP_IDX to new helper All users which have a '-1' in their MAIL_INDEX_MAP_IDX have been changed to the new mail_index_rec_at_seq() helper using this sed script: $ sed -ie 's/MAIL_INDEX_MAP_IDX(\([^,]*[^)]*[^ ]\) \?- \?1)/MAIL_INDEX_REC_AT_SEQ(\1)/' src/lib-index/*.[ch] No other users have been changed. Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.

lib-index: Don't bother tracking if header/records were changed. They aren't really needed. When mail_index_write() is called, we already know we want to update the index.

lib-index: Backported MAIL_TRANSACTION_ATTRIBUTE_UPDATE from v2.2

lib-index: mail_index_attribute_[un]set() adds changed attributes' keys to transaction log. This provides them both a modseq (so their changes become visible) as well as an efficient way to see what attributes have changed by reading the transaction log. The values themselves aren't written to the log, because they could be large.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.

Renamed buffer_create_*data() to buffer_create_from_*data() for consistency. Especially i_stream_create_from_data() was a very similar function, which made it difficult to remember which one should have "from" and which one shouldn't.