lib-index: Add and use CACHE_TRANS_CONTEXT_REQUIRE Satisfies static analyzers

Updated copyright notices to include the year 2018.

global: Change calls to array_idx_modifiable to array_idx_get_space. Only calls that require space allocation are to be changed.

global: Use t_buffer_create sed -i -e 's/buffer_create_dynamic(pool_datastack_create(), */t_buffer_create(/g'

global: Fix spelling mistakes in comments Original work by @andreasschulze and @jsoref

lib-index: Add mail_index_cache_optimization_settings

global: start relying on buffer_free(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - buffer_free(&E); - } + buffer_free(&E);

lib-index: Add mail_cache_close_mail() to smartly drop cached data with INDEX=MEMORY Instead of reseting the entire transaction buffer when 256 kB is reached, just drop mails have have been marked closed with mail_cache_close_mail(). If that's not enough, continue deleting forcibly until the buffer is below 256 kB. This is especially important when mail_prefetch_count>0 and INDEX=MEMORY. In that case there can be multiple mails that are being added to cache and used later on. If they were dropped from cache too early, the work would have to be done all over again.

lib-index: Fix cache lookups from uncommitted transactions with in-memory indexes This especially fixes mail_get_header_stream() with imapc and imapc_features=fetch-headers, because it works by first fetching the specific headers and putting them to the cache transaction, then later on relying on index_mail_get_header_stream() to get them from the transaction. Before this fix they wouldn't be found, which triggered another unnecessary FETCH BODY.PEEK[HEADER].

global: Use i_realloc_type() wherever possible

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-index: Fix potential error when reading from uncommitted cache transaction If dovecot.index.cache is compressed during the transaction, the new cache fields mapping doesn't necessarily match what is in the transaction. Fixes: Error: Corrupted index cache file .../dovecot.index.cache: field index too large (27 >= 17) Although there may be other cache corruption errors it also fixes.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-index: Delay unlocking cache compression until changes to transaction log are committed. This should fix race condition with two processes compressing the file at the same time with same file_seq and becoming confused.

lib-index: mail_cache_lock() partial rewrite. require_same_reset_id is no longer needed, if it ever was. If we're locking the cache file, we always want the latest one. The logic of locking in general was somewhat confusing and it probably didn't always successfully lock when it should have, because the reset_id happened to match an old file.

lib-index: Don't keep cache file locked for as long while syncing index. The earlier code was required for updating the cache offsets, but this code no longer exists. Now we just need to update the record counts in the header, which can be done quickly at the end of the sync.

Updated copyright notices to include year 2014.

lib-index: Recent change broke cache transactions for more than 1 mail.

lib-index: Support a small in-memory cache even with INDEX=MEMORY

lib-index: mail_cache_lookup*() can now finds also the latest mail_cache_add()ed data.

lib-index: mail_cache_lookup*() can now return fields recently added with mail_cache_add() Previously it was returning them if they had already been written to dovecot.index.cache, but not if they were still in the in-memory buffer. This avoids caching/parsing the same field multiple times when messages aren't accessed in ascending order (e.g. when sorting messages).

Replaced all -1U and (unsigned int)-1 with UINT_MAX. It's somewhat clearer this way. Also clang's -fsanitize=integer gives runtime errors about -1U (but not about explicit casts, so no need to change (type)-1 casts).

lib-index: Avoid getting expunged-status in index lookups when not necessary. This especially improves dsync performance.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.