global: start relying on mailbox_header_lookup_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - mailbox_header_lookup_unref(&E); - } + mailbox_header_lookup_unref(&E);

global: don't cast NULL to void * NULL is guaranteed to be a void * thanks to dd6043c05e32a8e8db1233ed711a2c74d1477a89.

Updated copyright notices to include the year 2018.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-imap-storage: Check that UID is assigned before caching

lib-storage: remove set_cache_corrupted_reason from mail_vfuncs Change set_cache_corrupted signature to what set_cache_corrupted_reason used to be.

Use mail_get_*stream_because() wherever possible.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

lib-imap-storage: Fixed fetching partial headers for message/rfc822 part Again broken by 333602c40.

lib-imap-storage: Don't sort uninitialized array on invalid header list.

lib-imap-storage: Removed wrong assert. Now that we're no longer putting the headers through istream-header-filter it doesn't necessarily have CRLFs. Broken by 333602c40.

lib-imap-storage: Don't double-filter HEADER.FIELDS (..) headers.

lib-imap-storage: Minor error logging cleanup/fix. We read from input, not from mail_input. In theory it could have the actual error instead of mail_input (although right now it couldn't).

global: Code cleanup - remove unnecessary errno changes. These were left behind from changing %m to [io]_stream_get_error()

lib-imap-storage: Allow HEADER.FIELDS(..) without space before '(' This is to allow doveadm fetch to use it. Attempting to do this without a space in IMAP already fails elsewhere: x fetch 1 body.peek[header.fields(from to)] x BAD Error in IMAP command FETCH: Invalid characters in atom

Use mail_set_cache_corrupted_reason() wherever possible.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-imap-storage: Added imap_msgpart_contains_body()

imap: FETCH BODY.PEEK[HEADER.FIELDS (..)] didn't set wanted_headers optimization. Primarily this fixes imapc's prefetching.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Use i_stream_get_error() wherever possible instead of %m

When creating istream-error, give an error string whenever possible.

lib-imap-storage: Don't waste effort getting mail's physical size if it can't be done quickly.

lib-imap-storage: Reverted previous change. It broke FETCH BODY [n.HEADER.FIELDS ..]

lib-imap-storage: Minor code cleanup

Updated copyright notices to include year 2014.

lib-imap-storage: Fixed leaking istream on error conditions. Caught by Tomasz Potęga

imap: Don't assert-crash on FETCH BODY[MIME] (return BAD instead)

imap: Don't crash with invalid FETCH BODY[sections]

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.