lib-imap-client: Fix IO after enabling SSL io_add_istream() needs to be used with the SSL istream, otherwise it can cause hangs.

lib-imap-client: continue imapc operation on parsing errors.

lib-imap-client: Avoid "Unknown tag" errors for aborted commands If mailbox is closed before all command replies were received, the commands were aborted but they'll still receive the replies from server. Remember the aborted commands' tag numbers so they can be ignored.

lib-imap-client: Fix reason text when unselecting mailbox aborts commands

lib-imap-client: Add asserts for reconnect_command_count

lib-imap-client: Delay sending more commands while SELECT is running

lib-imap-client: After reconnection send retried commands last Previously only SELECT was sent before others. This allows sending more commands on reconnection before the retried commands.

Updated copyright notices to include the year 2018.

global: timeout_remove(NULL) is a no-op

global: Use t_buffer_create sed -i -e 's/buffer_create_dynamic(pool_datastack_create(), */t_buffer_create(/g'

global: Fix spelling mistakes in comments Original work by @andreasschulze and @jsoref

global: use i_close_fd{,_path}() instead of open-coding them

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

global: start relying on io_remove{,_closed}(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - io_remove(&E); - } + io_remove(&E); @@ expression E; @@ - if (E != NULL) { - io_remove_closed(&E); - } + io_remove_closed(&E);

lib-imap-client: Support sending IMAP ID command including unique x-session-ext-id

lib-imap-client: Log an info-line when connected to remote server Include the remote IP:port ad local IP:port. This allows matching the connection with the remote server's logs (or e.g. haproxy logs).

lib-imap-client: Fix hang when imapc_client_get_capabilities() is called without connection

lib-imap-client: Change server IP only on connect() failures Also log an warning-level message about it. This is mainly useful to see that a slow connection could be caused by a connect() timeout. Since more IPs are still available, it's not yet an error.

imapc: Fix infinite reconnection when server keeps sending corrupted state When corrupted state was found, imapc_client_mailbox_reconnect() is called to reconnect. This call skipped the normal "is it safe to reconnect?" checks causing potentially infinite reconnections.

lib-imap-client: Avoid infinite reconnection loops when retrying command fails reconnect_command_count wasn't calculated correctly, because the SELECT and potentially other following sync commands weren't included in it.

lib-imap-client: Include "ms" in reconnect warning message

lib-imap-client: Fix reconnection There was already code for reconnection. We just shouldn't have gone very far in imapc_connection_connect() if we were still waiting for reconnection delay to pass.

lib-imap-client: Remove hardcoded IMAPC_CONNECT_RETRY_WAIT_MSECS We have a setting for it now.

lib-imap-client: Disconnection during LOGIN should still have state=disconnected It's not an authentication failure, which would imply that the user or password was wrong.

lib-imap-client: Make command tag counter externally accessible This allows unit tests to reset it.

lib-imap-client: Call the public login callback exactly once. Previously it was also called only once, as long as there were only a single imap connection. (The current imapc code wouldn't create more than one connection.) It was a bit confusing what the expectation was, so now the callback is never called more than once.

lib-imap-client: Change connect_retry_interval_secs to _msecs This allows caller to provide better precision.

lib-imap-client: Use struct timeval for tracking last_connect time. This provides better accuracy when calculating how much time there's left until reconnection.

imapc: Use IMAPC_COMMAND_STATE_AUTH_FAILED to indicate auth failure

lib-imap-client: Do not reset ips when reconnecting Avoids infinite loop

imapc: Fix memory leak in disconnected state

imapc: Compiler warning fix for 32bit systems

lib-imap-client: Make authentication failures more consistent This way they always say the same prefix, which is easier to spot.

lib-imap-client: Call login_callback on all authentication failures

lib-imap-client: Fix reconnection This patch fixes reconnections to actually consider all IP addresses first and then delay for interval and retry at most retry count times.

lib-imap-client: Remove io earlier to avoid hammering If connection has failed and reconnection is not yet possible, io has to be removed here, otherwise it will keep hammering the callback.

lib-imap-client: Make retry count and interval configurable

imapc: Use LOGOUT to cleanly disconnect from server. This makes it clearer in the remote server's logs whether the disconnection was intentional or not. Use a hardcoded 5 second timeout for LOGOUT. It should be enough time for the server to finish sending the tagged reply.

global: Fix ssl_set usage Remove verify_remote_cert, as it's always TRUE now. Set allow_invalid_cert to TRUE if verification is not required.

lib-imap-client: pass the reply text to the auth-failed state change callback

lib-imap-client: invoke state change callback on "authentication success"

lib-imap-client: add callback to notify consumers about state changes Add a callback to notify imapc users about failures. Currently, the only failure defined is "authentication failed".

lib-imap-client: centralize authentication failed error logging

imapc: Fix re-sending retryable commands after reconnect

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

*-login, imapc: Fix new lib-sasl API usage Forgot to include these in a669d351502e15802b121e1a0bd83f27d1d95f01

lib-imap-client: Fixed boolean vs integer mixup in debug message format argument. Found with Clang -Wstrict-bool.

imapc: Minor debug logging improvement

imapc: Don't retry a failed reconnection before 10 secs have passed This mainly avoids a lot of unnecessary connect attempts within a short time period, for example if the caller attempts to perform some work for all the mailboxes.

imapc: Fix infinite reconnect loop to remote server that is down This happened only in some situations. Usually there would have bene some command in the queue, which would cause the reconnect-check to fail.

global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)"

global: Use i_strchr_to_next() wherever useful.

imapc: Added imapc_max_line_length to limit maximum memory usage. The default is still unlimited, but this should be set to something smaller for untrusted servers.

global: Removed redundant corking in ostream flush callbacks.

lib-ssl-iostream: Changed require_valid_cert -> allow_invalid_cert We should default to being safe.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

o_stream_send_istream() API changed again The new API enforces the caller to correctly handle all the possible situations. It also makes in unambiguous whether to wait for input or output stream.

lib-imap: imap-parser: Made the fatal result parameter of imap_parser_get_error() optional.

global: Simplify code with the new o_stream_send_istream() API

imapc: Support retrying after connect() failure.

imapc: Support retrying after connect/authentication timeouts.

imapc: Support retrying for non-mailbox commands.

imapc: Prepare for non-mailbox command retrying: Set reconnect_command_count earlier This probably doesn't fix itself anything yet, but is needed for the following changes.

imapc: Fixed checking of whether same IMAP command keeps crashing server. reconnect_command_count was counting only the post-login commands, but we were decreasing it also for pre-login commands. This caused it to shrink to 0 too early.

imapc: Code cleanup - Use a common function for checking/logging if we want to reconnect or disconnect

imapc: If command times out, reconnect and retry if possible.

imapc: Added support for PROXYAUTH command by setting imapc_features = proxyauth This can be useful when talking to Sun/Oracle IMAP server, which wants you to use LOGIN+PROXYAUTH to perform master user logins, instead of supporting the standard SASL PLAIN authentication.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

imapc: Treat literal8 input the same as regular literal. This is mainly for migrating away from broken servers (a patched Cyrus) that send literal8 if a (corrupted) message contains NULs.

lib-imap-client: If connect() fails immediately, log an error and retry the next IP. Only if all IPs fail return a full failure. This is mainly intended to skip IPv6 addresses when IPv6 connectivity doesn't work.

lib-imap-client: Allow reconnecting to IMAP server even if there had been no idle moments.

lib-imap-client: Removed unused pending_box_command_count

lib-imap-client: If we get disconnected and reconnect, log it as warning instead of as error.

imapc: Added throttling settings to imapc_features=throttle:a:b:c This change could be reverted once good settings are found.

lib-imap-client: Implemented a bit more complicated [THROTTLING] behavior. The throttling is now more continuous and decreases more slowly.

lib-imap-client: Fixed GMail [THROTTLED] detection. It's not a resp-text-code, but appended at the end of line.

lib-imap-client: Get capabilities again after reconnection to server. This is needed most importantly if we're not using plaintext authentication to log in.

lib-imap-client: Improved error message a bit if server disconnects.

lib-imap-client: Implemented support for GMail [THROTTLED] resp-text-code. If we receive it, start throttling future commands by waiting exponentially longer until we no longer receive [THROTTLED]. Max wait time is currently 16 seconds.

lib-imap-client: Added imapc_command_get_tag()

lib-imap-client: Compiler warning fixes

imapc: Added imapc_sasl_mechanisms setting The first supported SASL mechanism is used, otherwise the login fails entirely.

lib-imap-client: Use lib-sasl to perform the AUTHENTICATE command handling.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

imapc: If connection isn't in selected state when deleting mailbox, don't try to UNSELECT it.

lib: Moved rawlog dir stat()s to iostream_rawlog_create() internally. This is required to allow TCP rawlogs to actually work.

imapc: Avoid crashing if server happens to send invalid resp-text-codes. If [KEY VALUE] is missing the VALUE, just set it to "" instead of NULL. Found by Coverity

Updated copyright notices to include year 2014.