global: don't cast NULL to void * NULL is guaranteed to be a void * thanks to dd6043c05e32a8e8db1233ed711a2c74d1477a89.

Updated copyright notices to include the year 2018.

global: Fix spelling mistakes in comments Original work by @andreasschulze and @jsoref

lib-http: test-http-client-errors - fix typo in error message

lib-http: Detect istream errors correctly. i_stream_is_eof() returns TRUE also when streams have an error, so all errors were logged the same as a regular disconnection.

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

global: start relying on i_close_fd(-1) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != -1) - i_close_fd(&E); + i_close_fd(&E);

lib-http: client: Fixed request-specific attempt timeout. This is the timeout applied to a single request attempt. Using http_client_request_set_attempt_timeout_msecs() this can be set for a specific request. However, this was mostly ignored for requests that weren't in the process of handling response payload. Instead, the global request_timeout_msecs client setting was used. Also amended the (currently manual) test suite with tests that demonstated the problem and now verify the fix.

lib-http: client: Fix aborting a request that has a delayed error. Caused by recent changes in delayed error handling.

lib-http: client: Implemented http_client_request_url_str() function that accepts an URL string rather than a pre-parsed URL object. If the provided HTTP URL is invalid, the callback with the error is called some time later from the ioloop. This change also amends the test-http-client-errors test suite with a new test for this new feature.

lib-http: test-http-client-errors: Added test for using https:// while SSL is not configured.

lib-http: test-http-client-errors: Always use the proper error status code definitions rather than an integer literal.

lib-http: client: Fixed peer reconnection failure handling. The addressed problem occurs in a very specific situation in which the original successful connection is dropped, yet a new connection fails. It manifests as an assertion failure or panic: Panic: file ioloop-epoll.c: line 189 (io_loop_handler_run_internal): assertion failed: (msecs >= 0) Panic: BUG: No IOs or timeouts set. Not waiting for infinity. The timing is very critical. However, this doesn't mean that the occurrence of this problem is very unlikely; it can happen frequently under high load.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

global: Use const for all test_functions[] arrays

lib-http: client: Added test for premature connection loss to test-http-client-errors.

lib-http: client: Added test for normal connection backoff behavior to test-http-client-errors.

lib-http: client: Fixed assert failure occurring when a new connection fails for a peer that has active connections. Fixes: Panic: file http-client-queue.c: line 481 (http_client_queue_connection_failure): assertion failed: (queue->cur_peer == NULL)

lib-http: test-http-client-errors: Add test for server that returns error status early while client is still sending blocking payload.

lib-http: Added blocking client support to test-http-client-errors.

lib-http: Fixed potential segfault problem in test-http-client-errors. Found by Coverity.

lib-http: Added DNS-related tests to test-http-client-errors.

lib-http: Made test-http-client-errors more reliable.

lib-http: client: Added tests for manual handling of connection loss retries to test-http-client-errors.

lib-http: client: Added test for http_client_request_delay_msecs() in test_http_client_errors.

global: Require comparisons to be strict boolean expressions * No implicit integer -> boolean or pointer -> boolean conversions * !expr can be used only if expr is boolean type These were checked with a patched clang. It found various actual bugs, which were fixed by the previous commits.

lib-http: client: Created test program that triggers most possible error conditions.