lib-http: client: Make sure all ioloop objects are created on the ioloop that the client/context is switched to.

lib-http: queue: Update the correct timout while dropping a request from the delay queue. The absolute request timeout rather than the delay timeout was updated for the removal of the request from the delay queue.

Updated copyright notices to include the year 2018.

lib-http: client: Replace http_*_debug() with e_debug()

lib-http: client: Remove redundant debug logging checks

lib-http: client: Add support for event API

global: timeout_remove(NULL) is a no-op

lib-http: client: Added identifier to client log messages.

lib-http: client: shared context: Allow sharing peer state between clients.

lib-http: client: shared context: Allow sharing host lookups between clients.

lib-http: client: Avoid direct access to host object members from queue.

lib-http: client: Simplified initiation of connection setup upon request submission.

lib-http: client: Created separate http_client_queue_get() function. Before, this was combined in http_client_queue_create() which caused a large code block to be indentet. Separating creation and obtaining the current instance makes the code cleaner.

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

lib-http: client: queue: Improved construction of timeout log message. Earlier change used a literal prefix size, rather than inferring the size from the actual prefix string.

lib-http: client: Improved absolute request timeout error message. Now mentions that it is the absolute timeout. Provides the request statistics also provided for the regular attempt timeout message.

lib-http: client: Only drop queued requests when a DNS lookup fails; not also the ones that are already in progress.

lib-http: client: Fixed i_unreached() failure occurring when a host's list of IPs changes while a connection is still pending. In that case, the IP of the pending connection may no longer be associated with that host. If the IP was not found anymore, the i_unreached() error occurred.

spelling fixes

lib-http: client: Fixed peer reconnection failure handling. The addressed problem occurs in a very specific situation in which the original successful connection is dropped, yet a new connection fails. It manifests as an assertion failure or panic: Panic: file ioloop-epoll.c: line 189 (io_loop_handler_run_internal): assertion failed: (msecs >= 0) Panic: BUG: No IOs or timeouts set. Not waiting for infinity. The timing is very critical. However, this doesn't mean that the occurrence of this problem is very unlikely; it can happen frequently under high load.

Updated copyright notices to include the year 2017.

lib-http: client: Fixed assert failure occurring when a new connection fails for a peer that has active connections. Fixes: Panic: file http-client-queue.c: line 481 (http_client_queue_connection_failure): assertion failed: (queue->cur_peer == NULL)

lib-http: client: Destroy host and associated queue objects after no more requests remain and an idle timeout expires.

lib-http: client: Implemented host name lookup TTL. Host name lookups will now be performed again when the results have expired. Without access to TTL information from DNS lookups, all lookups will use the same default TTL for now.

lib-http: client: Added http_client_queue_requests_active(). It counts how many active requests a queue has.

lib-http: client: Create queue->pending_peers array from the beginning. This simplifies the code, since the pending peers array is always used.

lib-http: client: Link peers to queue earlier: during connection attempts. This makes sure that queues keep track of which peers are doing stuff on its behalf. This is important to be able to manage the active peers when a new host name lookup was performed; if a peer is no longer listed in the returned IPs it should be dropped.

lib-http: client: Unlink all queues from peer when it is disconnected. Before, queues were only destroyed when the whole client was destroyed. This change and subsequent changes prepare for being able to destroy a queue when it becomes unused.

lib-http: client: Added more debug logging about the submission of delayed requests.

lib-http: Changed http_client_request_error to set request to NULL It's going to internally unreference it, so the caller should be aware of it also. I also changed request state check to be an assert, since I don't think there's any safe way this could work otherwise.

lib-http: Queue's delayed timeout handler wasn't removed after work was done.

lib-http: If connect fails, include attempt count and total time in error. This will produce errors such as: 9002 connect(1.2.3.4:801) failed: Connection timed out in 1.001 secs (4 attempts in 4.706 secs)

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

http-client: Added support for using an HTTP proxy running on a unix socket.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-http: client: Fixed assertion failure in http_client_queue_fail(). Don't explicitly clear the request array after looping through all requests, since new requests may be added during the loop, not only removed.

lib-http: client: Assertion in http_client_queue_fail() was wrong. It is not guaranteed that all queue lists are empty, because new requests can be submitted from the callbacks. Changed this into a proper invariant check, which asserts tbat the number of requests in sub-queues add up to the total number in the main queue.

lib-http: client: Fixed behavior for max_connect_attempts with fewer IPs than attempts. This was broken by earlier 'fix'.

lib-http: client: With the recent addition of a connection attempt limit, connection failures weren't always handled correctly.

lib-http: client: Added support for absolute request timeout. Requests cannot survive beyond this deadline.

lib-http: client queue: Start using new timeval_cmp_margin function for delay handling.

lib-http: client: The http_client_queue_fail() function aborted requests in an unsafe manner. Copied queues before freeing the requests, because the destroyed requests modify the queue.

lib-http: client: Fixed crash occurring sometimes when delay timeout expired. Forgot to drop destroyed requests from delay queue.

lib-http: client: Added support for attempting a single IP several times. Also limits the number of attempts when there are many IPs.

lib-http: Fixed a hang Patch by Stephan Bosch

lib-http: Added debug logging.

Updated copyright notices to include year 2014.

lib-http: Removed assert Time can't be relied on exactly.

http: Implemented delayed requests scheduling. Requests can now be (re)submitted with a delay. The request is not sent until the delay time expires. This facilitates handling the Retry-After header in responses. This can either be performed automatically if the indicated delay is not too long or explicitly by the code using lib-http.

http-client: Changed struct http_client_host_port into a struct http_client_queue object. Peer and request objects now reference the queue object directly rather than the host object. This way, there is no need to find the matching host:port in the host anymore. This makes the queueing structure more intuitive and more efficient. This is a first step towards support for connecting to HTTP services through unix sockets or directing requests at specific hosts (so not from the URL). This patch also fixes a potential timeout leak (to_connect) in http_client_host_port (now http_client_queue) and makes sure it is moved during switch_ioloop(). Finally it updates the structure comment at the top of http-client.c.