lib-http: client: Make sure all ioloop objects are created on the ioloop that the client/context is switched to.

lib-http: client: Call switching ioloop for shared peer from shared client context. Before, it was called from the client peer.

Updated copyright notices to include the year 2018.

lib-http: client: peer: Properly handle claiming an existing connection. If no other connections were being created, request handling was not restarted. This problem sometimes caused the client to hang. Fixed by calling http_client_peer_connection_success() upon claiming an existing connection.

lib-http: client: Replace http_*_debug() with e_debug()

lib-http: client: Remove redundant debug logging checks

lib-http: client: Add support for event API

global: timeout_remove(NULL) is a no-op

lib-http: client: Added identifier to client log messages.

lib-http: client: shared context: Allow sharing peer state between clients.

lib-http: client: peer: Moved http_client_peer_reset_backoff_timer() function. This is a preparation for a subsequent change.

lib-http: client: peer: Moved http_client_peer_increase_backoff_timer() function. This is a preparation for a subsequent change.

lib-http: client: peer: Moved http_client_peer_start_backoff_timer() function. This is a preparation for a subsequent change.

lib-http: client: peer: Moved http_client_peer_connect_backoff() function. This is a preparation for a subsequent change.

lib-http: client: peer: Moved http_client_peer_get() function. This is a preparation for a subsequent change.

lib-http: client: peer: Moved http_client_peer_drop() function. This is a preparation for a subsequent change.

lib-http: client: peer: Moved http_client_peer_close() function. This is a preparation for a subsequent change.

lib-http: client: peer: Moved http_client_peer_unref() function. This is a preparation for a subsequent change.

lib-http: client: peer: Moved http_client_peer_ref() function. This is a preparation for a subsequent change.

lib-http: client: peer: Moved http_client_peer_disconnect() function. This is a preparation for a subsequent change.

lib-http: client: peer: Moved http_client_peer_create() function. This is a preparation for a subsequent change.

lib-http: client: Moved connection pool handling from peer to separate object.

global: Remove dead code Found with clang static analyzer.

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

lib-http: client: Drop peer immediately if it has no more linked queues and it is not connected and not waiting for a backoff timeout. It is currently unlikely to happen at this point, but it is better to make sure it is handled appropriately. The pending shared HTTP client changes will make this a likely event. This surfaced as a problem for the HTTP proxy.

lib-http: client: Respect the connection idle timeout, even when all queues have unlinked from a peer. Otherwise, the DNS TTL timeout dictates the connection idle timeout in some situations.

Updated copyright notices to include the year 2017.

lib-http: client: Treat connections that get disconnected prematurely as connection failures. This means that the backoff time is increased when this happens. A premature disconnection happens when the connection is disconnected before any data is received from the server.

lib-http: client: Moved connection backoff timer management to separate functions.

lib-http: client: Prevent infinite event loop involving the request handler. Could happen when a backoff time is active.

lib-http: client: Created http_client_peer_drop() function that closes a peer object gracefully. It checks whether any connections are still present. It checks whether a backoff timer is still active. This change and subsequent changes prepare for being able to destroy a queue when it becomes unused. All peers linked to such a queue are unlinked and dropped when inactive and unlinked.

lib-http: client: Unlink all queues from peer when it is disconnected. Before, queues were only destroyed when the whole client was destroyed. This change and subsequent changes prepare for being able to destroy a queue when it becomes unused.

lib-http: client: Improved logging of connection loss handling in peer.

lib-http: client: If a peer object is no longer linked to a queue, don't close it until all connections are inactive. The peer object is canceled, rather than closed. Which means that any newly started and idle connections are closed immediately. Requests may be pending though. This is only relevant when hosts/queues are removed at some point. This is a preparational change for having a maximum lifetime on hosts/queues, in which case this becomes a possibility.

lib-http: client: Added debug messages that indicate when a queue is linked/unlinked to a peer.

lib-http: client: Added function that counts how many connections are active within a peer.

lib-http: client: Fixed bug in handling of lost connections while returning from another ioloop. At one instance the http_client_connection_is_ready() function could have destroyed the connection while the caller still depended on it. Renamed the http_client_connection_is_ready() function to http_client_connection_check_ready(). This now returns -1 when the connection got destroyed. Before it returned a bool that just indicated whether the connection was ready or not. So, there is no need anymore to preserve a connection reference while calling this function.

lib-http: client: Reworked connection close handling. Now, the peer is immediately notified of the lost connection. Before, this step was only taken when the connection was fully dereferenced. To prevent recursive notifications between peer and connection, handling the loss of a connection is deferred to the request handler. When a peer is freed, any associated lingering connections have conn->peer set to NULL.

lib-http: client: Improved labeling of debug messages. Request label is corrected. Labels are now pre-composed and stored.

lib-http: client: peer: Improved debug message that shows the loss of a connection.

lib-http: client: Made peer object reference-counted to prevent invalid memory access in request handling routine. Resetting the peer->handling_requests flag risked triggering a segfault, since the peer object could be deleted from within the request handler loop.

lib-http: client: Fixed handling of stalled connections that emerge when the client ioloop hasn't run for a long time. Inside the peer's request handler routine, the connections are verified after the ioloop continues. If they turn out to be broken, they self-destruct while the handler routine is active, leading to problems. Solved by referencing the connection and retrying the connection statistics loop when a connection is lost in the process.

lib-http: client: Fixed crash happening when connection hits an error while handling a new request. At this point the connection dies within the peer request handler loop. Before, the dying connection could free the peer when it ended up being obsolete. But because it was still in the loop, a segfault occurred as the loop continued. Fixed by deferring the the deallocation of the peer from the connection_lost() function to the request handler loop itself if it is active.

lib-http: Always set *_obj=NULL first in deinit functions (mainly for consistency) This doesn't usually matter, but in case deinit calls some callback they may be trying to access the partially destroyed object.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-http: client: Tunneled https peer addresses were not compared properly. The https_name field was ignored in that case.

lib-http: client: Fixed bug that caused queues to be duplicated over time when host has multiple IPs. The peer address comparison did not account for the fact that the initial queue address has no IP assigned.

lib-http: client: Improved hash function for peer addresses.

http-client: Added support for using an HTTP proxy running on a unix socket.

lib-http: Added more debug logging. Patch by Stephan Bosch.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-http: client: Implemented maximum for connection backoff time. Without a maximum, the backoff time grows exponentially to enormous values, because it isn't reset until the connection succeeds. This causes recovery from connection failures to become very slow. Current maximum is one minute.

lib-http: client: If peer is unlinked from queue and no other links remain, close any pending connections. Those pending connections would no longer serve any purpose.

lib-http: client: Fixed behavior of connection backoff timer when multiple IPs are returned for hostname. Peer backoff data was lost because peer was destroyed quickly. Now the peer object is retained during the backoff period, so that new connection attempts adhere to the backoff period.

lib-http: client: Fixed recovery after connection failure. If a parallel already connected connection was active, the queue wasn't notified of the failure. Only pending connections should be considered in this case and not established ones.

lib-http: client: Implemented support for connection failure backoff.

Updated copyright notices to include year 2014.

http-client: Changed struct http_client_host_port into a struct http_client_queue object. Peer and request objects now reference the queue object directly rather than the host object. This way, there is no need to find the matching host:port in the host anymore. This makes the queueing structure more intuitive and more efficient. This is a first step towards support for connecting to HTTP services through unix sockets or directing requests at specific hosts (so not from the URL). This patch also fixes a potential timeout leak (to_connect) in http_client_host_port (now http_client_queue) and makes sure it is moved during switch_ioloop(). Finally it updates the structure comment at the top of http-client.c.

lib-http: http-client: Added support for tunneling SSL conntections through proxy.

lib-http: Added support for creating CONNECT tunnels through HTTP.

lib-http: Fixed client connection and peer log labels to show proper IPv6 peers. The labels did not put IPv6 addresses in square brackets.

lib-http: http-client: Fixed request scheduling and connection management.

lib-http: Fix/cleanup to handling connect failures. There was some kind of double-error handling which messed up things.

lib-http: Fixed tracking number of pending connections to host-port.

lib-http: Added more debug messages.

lib-http: Minor code cleanup.

lib-http: Fixed hang when many connections were being created and closed.

lib-http: Added soft_connect_timeout_msecs setting to connect to multiple IPs in parallel. Based on patch by Stephan Bosch.

lib-http: If connect to peer failed, don't recreate a new connection to handle pending requests. The new connection would very likely fail as well. Another peer for the host should pick up the requests.

lib-http: Don't create a new HTTP connection when there is already one connecting.

lib-http: Crashfix for previous change.

lib-http: Prepare for TLS SNI support.

lib-http: Pass connect failures all the way to request callback's error string.

lib-http: Simplify error handling by delaying connect() failures.

lib-http: Removed unused code.

lib-http: Each peer doesn't need a separate ssl context, enough to have one for http_client. Also removed #ifdefs for building with SSL support. lib-ssl-iostream nowadays dynamically loads the SSL library when needed, and also handles failures if Dovecot was built without SSL support.

lib-http: Added ssl_ca setting to specify the CA certificate directly.

lib-http: Free peer if it can't be connected to and it has no pending requests.

lib-http: If host can't be connected to, don't keep retrying with more than one connection. This also fixes infinitely trying to reconnect to host and retry.

lib-http: Fixed hangs with urgent requests.

lib-http: Avoid hanging on urgent requests. Patch by Timo & Stephan. There are still some problems though, all urgent requests don't seem to get a new connection.

lib-http: Track peers using a linked list also. Mainly because this makes it much easier to debug using gdb. The overhead isn't that much extra either.

Replaced all -1U and (unsigned int)-1 with UINT_MAX. It's somewhat clearer this way. Also clang's -fsanitize=integer gives runtime errors about -1U (but not about explicit casts, so no need to change (type)-1 casts).

lib-http: Minor improvements.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.