global: start relying on str_free(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - str_free(&E); - } + str_free(&E);

Updated copyright notices to include the year 2018.

lib-fs: Add fs_file/iter_init_parent()

lib-fs: Split allocation from fs.iter_init() to a separate fs.iter_alloc()

lib-fs: Split allocation from fs.file_init() to a separate fs.file_alloc()

global: Fix spelling mistakes in comments Original work by @andreasschulze and @jsoref

lib-fs: fs-metawrap - Don't try to write to an already finished ostream Fixes a crash after recent changes when trying to write an empty file via fs-metawrap.

global: start relying on [io]_stream_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_unref(&E); - } + i_stream_unref(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_unref(&E); - } + o_stream_unref(&E);

Updated copyright notices to include the year 2017.

fs-metawrap: Don't assert-crash when trying to write an empty file. Fixes: Panic: file fs-metawrap.c: line 401 (fs_metawrap_write_stream_finish): assertion failed: (file->super_output->offset > 0 || file->super_output->stream_errno != 0)

fs-metawrap: Fixed assert that checks we don't create empty files. If the entire write failed, offset could be 0.

lib-fs: Do not abort parent of parent

lib-fs: Add fs_write_stream_abort_parent and use it Will do all the things abort_error does, but leaves error untouched. You are expected to set one yourself.

fs-api: Add and use fs_write_stream_abort_error This lets caller to specify error instead of setting it with fs_error. Doing it like this lets us percolate the error upwards.

fs-metawrap: Added assert to make sure we don't create empty files. It seems like this could be happening in some situation.

lib-fs: Added fs_get_nlinks() Although fs_stat() could return this, its caller can't indicate whether it actually wants the link count. Usually fs_stat() is used only to get the file's size. In some backends it's not cheap to get the link count, so adding this function allows the caller to explicitly ask for it.

fs-metawrap: Use fs_wrapper_*() wherever possible

lib-fs: Added fs_switch_ioloop()

lib-fs: fs_wait_async() can't fail, so make it return void. The individual requests can timeout, but not the waiting itself.

fs-metawrap: Removed unnecessary code. As mentioned in a0cf7d392, this can't happen.

fs-metawrap: Removed unnecessary code. The caller already set success==FALSE if ostream was closed.

fs-metawrap: Fixed buffer size while reading metadata header. It's not enough to have the buffer size set to "large enough" at the time of the stream creation, because i_stream_set_max_buffer_size() could be called afterwards.

lib-fs: Don't duplicate backend name in fs_init() errors. fs_init() already adds the "backend: " prefix to the error_r, so the callers shouldn't do it again.

global: Use o_stream_nsend_istream() where useful We can skip all of the io error handling and just leave it to o_stream_nfinish().

lib-fs: Make sure fs-metawrap catches all write errors. The full istream may not have been written in case ostream only partially wrote the data (e.g. out of disk space?)

fs-metawrap: Minor code cleanup temp_output==NULL, so these calls are equal.

fs-metawrap: Propagate fs_write_stream_abort() to parent always It needed to be done also when temp_output==NULL, because we had already started sending it to parent, but async parent wasn't being finished.

lib-fs: fs-metawrap stat() error handling improvement. We can't just treat i_stream_get_size() returning 0 as the reason being istream is async and not fully read. It might be, but it might also be because of other reasons. And since we're closing the istream we couldn't even properly finish up the async handling. So for now just return an error if we see this happening.

lib-fs: Fixed fs_get_metadata() with fs-metawrap If mail was already read to EOF.

lib-fs: fs-metawrap stat() and get_metadata(): use existing istream if possible This may reduce reads from parent fs, but it's at least required for the following commit.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-fs: Improved fs-metawrap's fs_stat() error message.

fs-metawrap: If written file unexpectedly shrinks, return error instead of assert-crash. This shouldn't be happening, but we can't fully control it so an error is better.

fs-metawrap: Don't assert-crash when writing an empty file.

lib-fs: Minor code cleanup Both temp_output and super_output are NULL so it doesn't matter which we use, but this change makes it use the intended variable.

lib-fs: Optimized fs_stat() for fs-metawrap after writing a file.

lib-fs: Added FS_METADATA_OBJECTID macro.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-fs: fs-metawrap now supports adding more metadata fields while file is being saved. This potentially adds yet another temporary file write though.

fs-metawrap: Fixed iteration wrapping, broken by earlier changes.

lib-fs: fs-metawrap now fully wraps fs_iter_* to fix tracking struct fs.iters

fs-metawrap: Add FS_PROPERTY_COPY_METADATA property for wrapped fs backends. This is because if we simply use the parent copy the metadata gets copied as well.

lib-fs: Fixed metawrap_fs.copy() to work with FS_PROPERTY_COPY_METADATA backends. This is done by simply copying the entire file with the metadata included instead of rewriting it.

Updated copyright notices to include year 2014.

lib-fs: Added fs_file_close() to explicitly close all streams that the file has open.

fs-metawrap: Fixed fs_copy_finish_async() wrapping

lib-fs: Always keep the error in the parentmost fs. This fixes problems with getting the correct error message when wrapper filesystems are used.

lib-fs: fs-metawrap should prefetch using the same file as it uses for reading.

fs-metawrap: Don't duplicate work if fs_get_metadata() is called multiple times.

fs-metawrap: Memory leak fixes

fs-metawrap: Set underlying file async only for fs_read_stream() lookups.

fs-metawrap: Delay writing the metadata headers until first data is written. Also some other read/write fixes.

lib-fs: Added FS_OPEN_FLAG_SEEKABLE. Globally handle fs_read_stream() seekability and waits.

fs-metawrap: Fixed stat() to work when parent file's input stream didn't have a parent.

fs-metawrap: Error handling fixes

lib-fs: Added "metawrap" wrapper to implement metadata as headers in the file content.