Updated copyright notices to include the year 2018.

global: Use PRI* macros and %zu instead of casting

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

dict-client: Support multiple values for lookups

lib-dict: Add support for lookup to return multiple values Implements only the initial stubs to the drivers.

dict-client: When failing to resend commands after reconnect, their success is uncertain. It's possible that the writes before the disconnection did actually finish successfully. If any of them were commits, we need to return DICT_COMMIT_RET_WRITE_UNCERTAIN.

dict-client: Pass through transaction timestamp to dict-server

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

dict-client: Don't timeout lookups without waiting 1sec in dict ioloop. What could have happened was: - dict-client sends a request to dict-server - dict-client process starts doing something else - dict-server answers - dict-client process continues doing something else for over 30 seconds, not reading the dict-server answer - dict-client process gets back to dict ioloop, which runs the timeout before checking if there is anything available for reading. Now we'll wait for 1 second in the last dict ioloop before assuming that there's a timeout.

dict-client: dict_lookup*() deleted the first byte of the result.

lib-dict: Add extra NULL-check to make static analyzer happier str_array_length() already checked NULL internally though.

dict-client: Server can now send command replies in any order. This way one slow lookup doesn't block all the other ones. This change keeps backwards compatibility in the dict protocol for both client and server.

dict-client: Include reconnection-status in slow dict lookup messages.

dict-client: Add warn_slow_msecs setting This allows configuring the default 5 seconds "slow dict lookup" warning.

dict-client: Add time spent in dict-server to "slow dict lookup" messages. This way you can see if the slowness was due to some communication problem between dict-client/server or internally in dict server. This change keeps backwards compatibility in the dict protocol for both client and server.

dict-client: Code cleanup - handle tab-unescaping before callbacks.

dict-client: Use io_wait_timer for tracking wait times. This way the "dict wait" time includes all ioloop waits that wait on the dict-client, not just in dict_wait().

dict-client: When dict-server times out, log ioloop/lock waits.

dict-client: Code cleanup to timeout handling. No functional changes.

dict-client: Dict server timeout may have occurred too early.

dict-client: Forward dict_iterate_set_limit() to dict server

dict-client: Code cleanup - remember all iteration flags

dict-client: Fix logging how much time was spent in other ioloops in slow lookup warnings. The warning's idea is to show why the lookup could have been slow. We differentiate between time spent in dict_wait() waiting only for the dict result and time spent in other ioloops waiting for potentially other things as well (and time spent waiting for locks during this time). The previous code didn't work right when multiple ioloops were used, which happened sometimes. Also changed %u to %d just in case some calculation is wrong. It's nicer to get a slightly negative value rather than a huge positive one.

global: Use i_strchr_to_next() wherever useful.

lib-dict: Duplicate result value in mempool Duplicate the result value already in callback to avoid it getting lost during async calls. Reported & tested by Pierre Jaury.

dict-client: Fixed lock and ioloop wait timings in log messages. Previously it was logging the total amount of time spent on lock waits or on ioloop during the existence of the entire process, rather than how much time the command itself was spending on those. This wasn't very useful. Now it also tries to separate the time spent on the main ioloop and in dict_wait().

dict-client: Don't return "Dict server timeout" too early. This could have happened when many dict commands were being run without the timeout being reset in the middle.

dict-client: Remove timeout when there are only background commands. Normally the timeout wasn't added in the first place, but it was if a non-background command was added first and it was followed by a background command.

dict-client: Don't crash if dict-server returns broken reply. Just treat missing <tab>value as empty value.

dict-client: In slow query warnings, log time spent in ioloop and lock waits. Possibly we want to remove the warnings entirely if most of the time has been spent on lock waits (or alternatively: not spent in ioloop).

lib-dict: Added dict_transaction_no_slowness_warning()

dict-client: Keep transaction's pointer in command until it's finished.

dict-client: Improve "slow dict operation" warnings in error conditions. There's no need to log both an error and a warning.

dict-client: Improved timeout error message.

dict-client: Fixed error message for failed synchronous dict_lookup() The error message was allocated from data stack, but freed too early.

dict-client: Don't keep a request timeout when there are only background commands.

dict-client: When we get disconnected, reconnect and re-send commands.

dict-client: Improved timeout error message

dict-client: Fixed hang in async iteration if it failed.

lib-dict: Added DICT_COMMIT_RET_WRITE_UNCERTAIN

lib-dict: Added enum dict_commit_ret.

dict-client: Improved logging for slow queries. Especially commits now say what the first query within the commit was.

dict-client: Attempt to connect to dict socket for 1 second before failing.

dict-client: Make sure query's start_time is up-to-date.

dict-client: Don't log slow background async commit/iteration replies. If a caller has already finished iteration, or does async commit without a callback, it means that it started the query without caring when it finishes. The caller may already have been doing blocking work while waiting for the dict reply. We don't want to log a warning, because it could be completely wrong.

dict-client: When skipping connect() due to earlier failure, preserve the original error.

dict-client: If commit fails to send BEGIN, don't try sending anything else. Fixes memory leak and also fixes overwriting the original error message.

lib-dict: Explicitly specify used dict_vfuncs methods for drivers. This allows adding more methods without modifying all the existing drivers.

lib-dict: Added dict_switch_ioloop()

lib-dict: dict-client rewrite to support async operations

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

dict-client: Fixed idle_msecs setting.

dict-client: Use standard str_tabescape-functions There's no reason to reimplement them here separately.

lib-dict: dict_transaction_commit*() returns now error string

lib-dict: Changed internal transaction_commit() to return void Somewhat simplifies the code now that it doesn't have to both call a callback and return the same ret.

lib-dict: dict_iterate_deinit() returns now error string

lib-dict: Changed dict_wait() to return void. If it encounters any failures, it should just make sure to abort any pending async requests before returning.

dict-client: dict_wait() can't really fail

dict: Pass through dict_lookup() error from dict server to client

lib-dict: dict_lookup() returns now error string

lib-dict: Moved/removed explicit stack frames in dict drivers. Added them back to dict_set/unset/atomic_inc() in dict.c. Others are unlikely to be called many times.

dict-client: Added idle_msecs=<n> parameter This can be useful when connected to dict-async server where extra idling connections don't matter so much as with blocking dict servers.

lib-dict: remove dict_append() Remove all *_dict_append and redis_append functions and corresponding command from lib-dict.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

dict-client: Avoid crash if server disconnects during transaction commit. Found by Coverity.

dict-client: Verify that the correct transaction ID is returned for commit reply.

dict-client: Improved broken iterate reply logging.

dict-client: If dict iteration was aborted, the rest of the connection state became broken. We never continued skipping over the rest of the iteration, instead the iteration replies were treated as replies to the following commands.

dict-client: Catch more invalid protocol replies.

dict-client: Disconnect from server on unexpected errors.

Remove now-unnecessary direct stdlib.h #includes.

dict-client: Prefix relative socket paths with base_dir.

lib-dict: Added async API for lookup and iteration.

lib-dict: Fixed crash when transaction failed due to dict server disconnection.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-dict: Changed dict.init() API to take struct dict_settings and added dict_init_full(). This allows giving more settings to dict in future as needed. Unfortunately it also breaks the internal dict API, but there aren't really any plugins widely using it, so it's not a big problem.

Updated copyright notices to include year 2014.

lib-dict: Error handling fixes to asynchronous transactions.

lib-dict: Fixed hang if async commit's callback did more dict access. Specifically this fixes a hang with dict-quota plugin when user didn't exist and quota was changed before calculating it.

Oops :) Update copyrights to 2013 without breaking all .c files.