Updated copyright notices to include the year 2018.

global: Replace o_stream_nfinish() with o_stream_flush()

global: use i_close_fd{,_path}() instead of open-coding them

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

lib: lib-signals: Removed explicit notification of ioloop change through lib_signals_reset_ioloop() in favor of implicit method. Before, if the ioloop changed, the application had to explicitly notify lib-signals using lib_signals_reset_ioloop(). This is error-prone and requires doing this all over the Dovecot code base. Now, lib-signals registers an ioloop switch callback that deals with this implicitly. The application can detach lib-signals from the ioloop explicitly if delayed signal handling is not required/desired in the new ioloop. Specific delayed signal handlers can be exempt from this automated behavior using a flag, meaning that such signal handlers need to be moved between ioloops explicitly.

global: Add asserts to make static analyzer happier.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-auth: Minor debug logging improvement. Include "PASS" or "USER" in the prefix to make it clear what the reply is for.

global: Replaced t_strsplit_tab() calls with t_strsplit_tabescaped() This is useful especially in auth code to support LFs in extra fields. Other pieces of code were also tab-escaping strings, but never unescaping them. Usually it didn't matter, because nobody would use the escaped characters. Still, the code wasn't exactly behaving correctly. One downside to this change is that it's now possible to pass through TABs, CRs and LFs through the various protocols. In theory this shouldn't cause any problems, but combined with other bugs this could trigger some security problems.

global: Code cleanup - Use t_strsplit_tabescaped() to avoid str_tabunescape()

lib-auth: Avoid crash after user iteration if connection failed.

lib-auth: Unescape passdb/userdb extra fields. This only affected \001, \t, \r and \n characters which were left tab-escaped (e.g. \t as "\001t").

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

global: Use [io]_stream_get_error() insted of %m

doveadm-auth: If auth_debug setting is enabled, send "debug" field to auth lookups. The idea is that you could enable auth_debug for specific requests with e.g.: doveadm -o auth_debug=yes user user@example.com

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Remove now-unnecessary direct stdlib.h #includes.

lib-auth: auth_master_pass/user_lookup() now returns -2 for user-specific errors. Compared to -1 which are about a more generic error with auth process communication. If -2 is returned the lookup could still succeed for another user.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.

lib-auth: auth_master_cache_flush() always waited for timeout before finishing.

lib-auth: Fixed infinite looping if user listing failed because auth process disconnected.

lib-auth: Recent cleanup commit was actually cleaning up too much.

lib-auth: Don't leave stale pointers to stack lying around in memory.

lib-auth: Previous changes didn't set the current ioloop correctly, causing problems.

lib-auth: auth_master_user_list_*() shouldn't create ioloop if it already exists.

lib-auth: Another crashfix to auth_master_user_list_*()

lib-auth: Don't crash in auth_master_user_list_*() if socket can't be connected to.

lib-auth: auth_master_user_list_*() no longer reads the entire user list into memory.

Replaced all -1U and (unsigned int)-1 with UINT_MAX. It's somewhat clearer this way. Also clang's -fsanitize=integer gives runtime errors about -1U (but not about explicit casts, so no need to change (type)-1 casts).

Oops :) Update copyrights to 2013 without breaking all .c files.