global: Flip MAIL_STORAGE_SERVICE_FLAG_DISALLOW_ROOT to ..._ALLOW_ROOT

Updated copyright notices to include the year 2018.

lda: Do not replace the NULL sender with a default <MAILER-DAEMON> address. Only do this substitution locally where a NULL sender would cause problems, not everywhere else. This e.g. causes problems when determining whether to send a rejection somewhere; attempts would be made to mail <MAILER-DAEMON>. Also other envelope-based (Sieve) tests would get confused.

lib-lda: Added SMTP parameter fields to struct mail_deliver_context. This moves the original recipient field inside the SMTP parameters. This also affects both lda and lmtp. Changes are applied there accordingly.

lib-lda: mail-send: Changed recipient argument type of mail_send_rejection() to struct smtp_address.

lib-lda: Changed struct mail_deliver_context address fields to use the new struct smtp_address type.

lda: Renamed variables and parameters for consistency with lib-smtp.

lib-lda: Renamed struct mail_deliver_context fields for consistency with lib-smtp. New fields are added in subsequent commits.

global: stop including fd-set-nonblock.h & fd-close-on-exec.h directly

lib-smtp: smtp-submit: Made submission_timeout a setting rather than a function parameter. This makes it configurable.

lda/lmtp: Parse SMTP submit settings.

lda: main: main(): Put result from mail_user_var_expand_table() in a variable. Keeps code more compact, as this function is going to be called several times.

lib-storage: Add reason to mailbox_transaction_begin() Remove mailbox_transaction_set_reason().

global: Log internal storage error on failure

global: Replace mail_storage_service_user_free() with _unref()

lib-lda: Fix deliver_log_format variables with Sieve With Sieve it was using src_mail for getting the values, which weren't correct especially if Sieve had modified the mail.

lib: Add error_r to t_abspath and its callers

lib: Rename abspath to path-util

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib: API change - var_expand*() now returns error string. This allows callers to fail properly if the format string is invalid.

lda: Fixed data stack usage in initialization. For example -p parameter was broken. Broken by 0679f8a70.

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

global: Fixed slighty wrong i_stream_read_data() with _read_bytes() These calls were reading one byte more than they were intended to read. This didn't really cause any problems, but now they're correct.

lib: istream - migrate to i_stream_read_more() Scripted to find all the low-hanging-fruit (single line calls), but hand-checked: git grep i_stream_read_data.*,\ 0\) | sed s/:.*// | \ xargs sed -i -e 's/i_stream_read_data(\(.*\), \(.*\), \(.*\), 0)/i_stream_read_more(\1, \2, \3)/' Signed-off-by: Phil Carmody <phil@dovecot.fi>

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Remove now-unnecessary direct stdlib.h #includes.

Replaced unlink() calls with i_unlink*() wherever possible.

lda: Removed unnecessary/duplicate 'k' from getopt_args This caused assert-crash at startup after ff17864ba6e0.

lib-lda: Assume that the caller sets delivery_time_started This is required because parts of the delivery time may be done at the time the user is being initialized, so it needs to be set before the user init is done.

lda/lmtp: Added a hardcoded LDA_SUBMISSION_TIMEOUT_SECS=30 timeout for SMTP client. Maybe we could have a new setting if needed later on, but we've been working pretty successfully without any timeout for a long time..

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lda, lmtp: Use mail_deliver_context.tempfail_error first if it exists (instead of storage error).

Handle "out of disk space" and "out of user quota" as separate cases. "Out of disk space" is a temporary error that should be logged as error and the failure should be sent to user as "Internal server error". Obsolete the use of MAIL_ERROR_NOSPACE and MAIL_ERRSTR_NO_SPACE. Use the clearer MAIL_ERROR_NOQUOTA and MAIL_ERRSTR_NO_QUOTA instead.

Removed unnecessary #includes.

Updated copyright notices to include year 2014.

lda/lmtp: If mail delivery fails with tempfail, don't fallback to saving to INBOX.

lda, lmtp: postmaster_address = postmaster@%d works now.

Oops :) Update copyrights to 2013 without breaking all .c files.